Revert specific handling at setup for macs with apple chips (#4591)

This commit is contained in:
Rishabh Saxena 2021-06-07 16:23:18 +05:30 committed by GitHub
parent 57487947f3
commit 2e6b262f29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 10 deletions

View File

@ -152,7 +152,6 @@
"scripts": {
"analyze": "source-map-explorer 'build/static/js/*.js'",
"start": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT HOST=dev.appsmith.com craco start",
"start-m1": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT HOST=0.0.0.0 craco start",
"build": "./build.sh",
"build-local": "craco --max-old-space-size=4096 build --config craco.build.config.js",
"build-staging": "REACT_APP_ENVIRONMENT=STAGING craco --max-old-space-size=4096 build --config craco.build.config.js",

View File

@ -87,14 +87,6 @@ case "${uname_out}" in
"
;;
Darwin*) machine=Mac
# workaround for apple silicon until host.docker.interal works as expected
if [[ "$(uname -m)" = "arm64" ]]; then
# if no server was passed
if [[ -z $1 ]]; then
server_proxy_pass="http://"$(ipconfig getifaddr en0)":8080"
fi
client_proxy_pass="http://"$(ipconfig getifaddr en0)":3000"
fi
echo "
Starting nginx for MacOS...
"

View File

@ -71,7 +71,6 @@ On your development machine, please ensure that:
- By default your client app points to the local api server - `http://host.docker.internal:8080` for MacOS or `http://localhost:8080` for Linux. Your page will load with errors if you don't have the api server running on your local system. To setup the api server on your local system please follow the instructions [here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ServerSetup.md)
- In case you are unable to setup the api server on your local system, you can also [use Appsmith's staging API server](#if-you-would-like-to-hit-a-different-appsmith-server).
- In case you are using a M1 chip Macbook please run the client with `yarn start-m1`.
#### If yarn start throws mismatch node version error