Revert "chore: Linter check for dangling it.only tests" (#24122)
Reverts appsmithorg/appsmith#23991 Reverting because lint check is failing in our test suite. Will raise another PR along with lint check passing
This commit is contained in:
parent
398d9d157d
commit
2c9fc117c6
|
|
@ -76,20 +76,6 @@ eslintConfig.overrides = [
|
||||||
getRestrictedSyntaxOverrideForCodeEditor(eslintConfig),
|
getRestrictedSyntaxOverrideForCodeEditor(eslintConfig),
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
|
||||||
files: ["**/*.test.js", "*.test.ts", "*.test.tsx"],
|
|
||||||
rules: {
|
|
||||||
"no-restricted-syntax": [
|
|
||||||
"error",
|
|
||||||
{
|
|
||||||
selector:
|
|
||||||
'CallExpression[callee.object.name="it"][callee.property.name="only"], CallExpression[callee.object.name="describe"][callee.property.name="only"]',
|
|
||||||
message:
|
|
||||||
"Reason: Dangling *.only tests skip other tests in the file and reduce test coverage.",
|
|
||||||
},
|
|
||||||
],
|
|
||||||
},
|
|
||||||
},
|
|
||||||
];
|
];
|
||||||
|
|
||||||
function getRestrictedImportsOverrideForCodeEditor(eslintConfig) {
|
function getRestrictedImportsOverrideForCodeEditor(eslintConfig) {
|
||||||
|
|
|
||||||
|
|
@ -13,19 +13,5 @@
|
||||||
"@typescript-eslint/no-non-null-assertion": "error",
|
"@typescript-eslint/no-non-null-assertion": "error",
|
||||||
"cypress/unsafe-to-chain-command": "off",
|
"cypress/unsafe-to-chain-command": "off",
|
||||||
"@typescript-eslint/adjacent-overload-signatures": "off"
|
"@typescript-eslint/adjacent-overload-signatures": "off"
|
||||||
},
|
}
|
||||||
"overrides": [
|
|
||||||
{
|
|
||||||
"files": ["**/*[sS]pec.js", "**/*[sS]pec.ts"],
|
|
||||||
"rules": {
|
|
||||||
"no-restricted-syntax": [
|
|
||||||
"error",
|
|
||||||
{
|
|
||||||
"selector": "CallExpression[callee.object.name=\"it\"][callee.property.name=\"only\"], CallExpression[callee.object.name=\"describe\"][callee.property.name=\"only\"]",
|
|
||||||
"message": "Reason: Dangling *.only tests skip other tests in the file and reduce test coverage."
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user