From 2c9fc117c6c4da8cf1f9554f70b0e45e71aceb8f Mon Sep 17 00:00:00 2001 From: Rajat Agrawal Date: Tue, 6 Jun 2023 19:29:03 +0530 Subject: [PATCH] Revert "chore: Linter check for dangling it.only tests" (#24122) Reverts appsmithorg/appsmith#23991 Reverting because lint check is failing in our test suite. Will raise another PR along with lint check passing --- app/client/.eslintrc.js | 14 -------------- app/client/cypress/.eslintrc.json | 16 +--------------- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/app/client/.eslintrc.js b/app/client/.eslintrc.js index a263150ee5..a9e7e7978b 100644 --- a/app/client/.eslintrc.js +++ b/app/client/.eslintrc.js @@ -76,20 +76,6 @@ eslintConfig.overrides = [ getRestrictedSyntaxOverrideForCodeEditor(eslintConfig), }, }, - { - files: ["**/*.test.js", "*.test.ts", "*.test.tsx"], - rules: { - "no-restricted-syntax": [ - "error", - { - selector: - 'CallExpression[callee.object.name="it"][callee.property.name="only"], CallExpression[callee.object.name="describe"][callee.property.name="only"]', - message: - "Reason: Dangling *.only tests skip other tests in the file and reduce test coverage.", - }, - ], - }, - }, ]; function getRestrictedImportsOverrideForCodeEditor(eslintConfig) { diff --git a/app/client/cypress/.eslintrc.json b/app/client/cypress/.eslintrc.json index ced39001e9..662da81ece 100644 --- a/app/client/cypress/.eslintrc.json +++ b/app/client/cypress/.eslintrc.json @@ -13,19 +13,5 @@ "@typescript-eslint/no-non-null-assertion": "error", "cypress/unsafe-to-chain-command": "off", "@typescript-eslint/adjacent-overload-signatures": "off" - }, - "overrides": [ - { - "files": ["**/*[sS]pec.js", "**/*[sS]pec.ts"], - "rules": { - "no-restricted-syntax": [ - "error", - { - "selector": "CallExpression[callee.object.name=\"it\"][callee.property.name=\"only\"], CallExpression[callee.object.name=\"describe\"][callee.property.name=\"only\"]", - "message": "Reason: Dangling *.only tests skip other tests in the file and reduce test coverage." - } - ] - } - } - ] + } }