chore: [map chart widget] update the label counts and snapshot in spec (#31648)

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Maps"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8231075012>
> Commit: `07f432e3206c6b370265078607b285e94eb0aacd`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8231075012&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->












<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated MapChart widget test cases, including selector changes and
modified assertions.
- **New Features**
- Enhanced the MapChart Widget to render charts using SVG for improved
performance and quality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
balajisoundar 2024-03-11 16:34:34 +05:30 committed by GitHub
parent 394093f6d5
commit 2c7b3684d6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
23 changed files with 6 additions and 14 deletions

View File

@ -12,7 +12,7 @@ import EditorNavigation, {
EntityType,
} from "../../../../../support/Pages/EditorNavigation";
const _mapChartCaption = "g[class*='-caption'] text";
const _mapChartCaption = "text:last-child";
const _mapChartPlot = (text: string) =>
"//text()[contains(., '" + text + "')]/..";
@ -33,7 +33,6 @@ describe(
it("2.1 Update the Map type to different types and verify - part1", function () {
// Change the map type to World with Antarctica and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "World with Antarctica");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 7);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -43,7 +42,6 @@ describe(
// Change the map type to World and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "World");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 6);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -53,7 +51,6 @@ describe(
// Change the map type to Europe and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "Europe");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 47);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -63,7 +60,6 @@ describe(
// Change the map type to North America and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "North America");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 26);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -73,7 +69,6 @@ describe(
// Change the map type to South America and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "South America");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 16);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -85,7 +80,6 @@ describe(
it("2.2 Update the Map type to different types and verify - part2", function () {
// Change the map type to Oceania and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "Oceania");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 15);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -95,7 +89,6 @@ describe(
// Change the map type to Africa and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "Africa");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 56);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -105,7 +98,6 @@ describe(
// Change the map type to USA and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "USA");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 51);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -115,7 +107,6 @@ describe(
// Change the map type to Asia and verify the number of entities
propPane.SelectPropertiesDropDown("Map type", "Asia");
agHelper.AssertElementLength(viewWidgetsPage.mapChartEntityLabels, 49);
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
@ -205,7 +196,7 @@ describe(
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
agHelper.GetNClick(_mapChartPlot("RU"), 0, true);
agHelper.GetNClick(_mapChartPlot("RU: 1.30"), 0, true);
agHelper.ValidateToastMessage("Data Point Russian Federation Clicked");
deployMode.NavigateBacktoEditor();
EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget);
@ -218,7 +209,7 @@ describe(
deployMode.DeployApp(
locators._widgetInDeployed(draggableWidgets.MAPCHART),
);
agHelper.GetNClick(_mapChartPlot("CN"), 0, true);
agHelper.GetNClick(_mapChartPlot("CN: .40"), 0, true);
agHelper.ValidateToastMessage("Converted to Js and clicked China");
deployMode.NavigateBacktoEditor();
EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget);
@ -230,7 +221,7 @@ describe(
{
minValue: 2,
maxValue: 3,
code: "#FFFFF",
code: "#000",
},
];
propPane.MoveToTab("Style");

View File

@ -34,6 +34,6 @@
"Chartlabel": ".t--draggable-chartwidget g text",
"FusionChartlabel": ".t--draggable-chartwidget g:nth-child(5) text",
"pickMyLocation": ".t--draggable-mapwidget div[title='Pick My Location']",
"mapChartEntityLabels": ".t--draggable-mapchartwidget g[class*='-entityLabels'] text",
"mapChartEntityLabels": ".t--draggable-mapchartwidget text",
"listWidget": ".t--draggable-listwidget"
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 56 KiB

After

Width:  |  Height:  |  Size: 71 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 58 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 62 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 50 KiB

After

Width:  |  Height:  |  Size: 55 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 80 KiB

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 59 KiB

After

Width:  |  Height:  |  Size: 61 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 74 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 57 KiB

After

Width:  |  Height:  |  Size: 64 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 56 KiB

After

Width:  |  Height:  |  Size: 61 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 70 KiB

After

Width:  |  Height:  |  Size: 70 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 KiB

After

Width:  |  Height:  |  Size: 41 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 45 KiB

After

Width:  |  Height:  |  Size: 42 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 43 KiB

After

Width:  |  Height:  |  Size: 50 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 56 KiB

After

Width:  |  Height:  |  Size: 61 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 43 KiB

After

Width:  |  Height:  |  Size: 39 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 79 KiB

After

Width:  |  Height:  |  Size: 57 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.5 KiB

After

Width:  |  Height:  |  Size: 17 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 56 KiB

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 50 KiB

After

Width:  |  Height:  |  Size: 55 KiB

View File

@ -65,6 +65,7 @@ export default function EchartComponent(props: MapChartComponentProps) {
chartContainer.current!,
{},
{
renderer: "svg",
width: props.width,
height: props.height,
},