Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix mongodb datasource test. (#1783)

Browse Source 
1. Fix mongodb datasource cypress test failure.
2. Against certain mongodb instances, we expect to receive an exception of type "unauthorized" when testing datasource. Earlier, this case was caught and whitelisted until the recent change to replace mongodb infra with reactive mongodb infra.
This commit is contained in:
Sumit Kumar 2020-11-18 16:55:39 +05:30 committed by GitHub
parent 941be8c58d
commit 2c6d1bb361
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/server/appsmith-plugins/mongoPlugin/src/main/java/com/external/plugins/MongoPlugin.java vendored
View File

@ -341,7 +341,19 @@ public class MongoPlugin extends BasePlugin {
})
.then(Mono.just(new DatasourceTestResult()))
.onErrorResume(error -> {
return Mono.just(new DatasourceTestResult(error.getMessage()));});
/**
* 1. Return OK response on "Unauthorized" exception.
* 2. If we get an exception with error code "Unauthorized" then it means that the connection to
* the MongoDB instance is valid. It also means we don't have access to the admin database,
* but that's okay for our purposes here.
*/
if(error instanceof MongoCommandException &&
((MongoCommandException) error).getErrorCodeName().equals("Unauthorized")) {
return Mono.just(new DatasourceTestResult());
}
return Mono.just(new DatasourceTestResult(error.getMessage()));
});
}
@Override