Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test: updated dataSourceCommands file (#33628)

Browse Source 
RCA: There are many unused commands within dataSourceCommands.js file

Solution:
Checked the dataSourceCommands in both CE and EE repository and we are
removing those commands which are not used in any tests as part of
cleanup activity

Equivalent EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4280


/ok-to-test tags="@tag.All"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9184573870>
> Commit: 5b15c17728d13ccb6324346204421e0fb8c746bc
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9184573870&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
This commit is contained in:
NandanAnantharamu 2024-05-28 14:43:26 +05:30 committed by GitHub
parent 987736e8f6
commit 2b57e86a74
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

106
app/client/cypress/support/dataSourceCommands.js
View File

@ -25,41 +25,10 @@ export const initLocalstorage = () => {
}); });
}; };
Cypress.Commands.add("testSaveDeleteDatasource", () => {
// Instead of deleting the last datasource on the active datasources list,
// we delete the datasource that was just created (identified by its title)
cy.get(datasourceEditor.datasourceTitle)
.invoke("text")
.then((datasourceTitle) => {
// test datasource
cy.get(".t--test-datasource").click();
cy.wait("@testDatasource");
// .should("have.nested.property", "response.body.data.success", true)
// .debug();
// save datasource
cy.get(".t--save-datasource").click();
cy.wait("@saveDatasource").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
// select datasource to be deleted by datasource title
cy.get(".t--edit-datasource").click({ force: true });
// delete datasource
dataSources.DeleteDSDirectly(200);
});
});
Cypress.Commands.add("NavigateToDatasourceEditor", () => { Cypress.Commands.add("NavigateToDatasourceEditor", () => {
dataSources.NavigateToDSCreateNew(); dataSources.NavigateToDSCreateNew();
}); });
Cypress.Commands.add("NavigateToActiveDatasources", () => {
AppSidebar.navigate(AppSidebarButton.Data);
});
Cypress.Commands.add("testDatasource", (expectedRes = true) => { Cypress.Commands.add("testDatasource", (expectedRes = true) => {
cy.get(".t--test-datasource").click({ force: true }); cy.get(".t--test-datasource").click({ force: true });
cy.wait("@testDatasource") cy.wait("@testDatasource")
@ -243,34 +212,6 @@ Cypress.Commands.add(
}, },
); );
Cypress.Commands.add(
"fillUsersMockDatasourceForm",
(shouldAddTrailingSpaces = false) => {
const userMockDatabaseName = shouldAddTrailingSpaces
? `${datasourceFormData["mockDatabaseName"] + " "}`
: datasourceFormData["mockDatabaseName"];
const userMockHostAddress = shouldAddTrailingSpaces
? `${datasourceFormData["mockHostAddress"] + " "}`
: datasourceFormData["mockHostAddress"];
const userMockDatabaseUsername = shouldAddTrailingSpaces
? `${datasourceFormData["mockDatabaseUsername"] + " "}`
: datasourceFormData["mockDatabaseUsername"];
agHelper.ClearNType(datasourceEditor["host"], userMockHostAddress);
agHelper.ClearNType(datasourceEditor["databaseName"], userMockDatabaseName);
cy.get(datasourceEditor["sectionAuthentication"]).click();
agHelper.ClearNType(
datasourceEditor["password"],
datasourceFormData["mockDatabasePassword"],
);
agHelper.ClearNType(datasourceEditor["username"], userMockDatabaseUsername);
},
);
Cypress.Commands.add( Cypress.Commands.add(
"fillSMTPDatasourceForm", "fillSMTPDatasourceForm",
(shouldAddTrailingSpaces = false) => { (shouldAddTrailingSpaces = false) => {
@ -325,13 +266,6 @@ Cypress.Commands.add("fillAmazonS3DatasourceForm", () => {
); );
}); });
Cypress.Commands.add("createAmazonS3Datasource", () => {
cy.NavigateToDatasourceEditor();
cy.get(datasourceEditor.AmazonS3).click();
cy.fillAmazonS3DatasourceForm();
cy.testSaveDatasource();
});
Cypress.Commands.add("ReconnectDatasource", (datasource) => { Cypress.Commands.add("ReconnectDatasource", (datasource) => {
cy.xpath(`//span[text()='${datasource}']`).click(); cy.xpath(`//span[text()='${datasource}']`).click();
}); });
@ -360,46 +294,6 @@ Cypress.Commands.add("createNewAuthApiDatasource", (renameVal) => {
cy.wait(2000); cy.wait(2000);
}); });
Cypress.Commands.add("deleteAuthApiDatasource", (renameVal) => {
//Navigate to active datasources panel.
dataSources.DeleteDatasourceFromWithinDS(renameVal);
});
Cypress.Commands.add("createGraphqlDatasource", (datasourceName) => {
cy.NavigateToDatasourceEditor();
//Click on Authenticated Graphql API
cy.get(apiEditorLocators.createGraphQLDatasource).click({ force: true });
//Verify weather Authenticated Graphql Datasource is successfully created.
cy.wait("@saveDatasource").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
// Change the Graphql Datasource name
cy.get(".t--edit-datasource-name").click();
cy.get(".t--edit-datasource-name input")
.clear()
.type(datasourceName, { force: true })
.should("have.value", datasourceName)
.blur();
// Adding Graphql Url
cy.get("input[name='url']").type(datasourceFormData.graphqlApiUrl);
// save datasource
cy.get(".t--save-datasource").click({ force: true });
cy.wait("@saveDatasource").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
});
Cypress.Commands.add("createMockDatasource", (datasourceName) => {
cy.get(".t--mock-datasource").contains(datasourceName).click();
});
Cypress.Commands.add("datasourceCardContainerStyle", (tag) => { Cypress.Commands.add("datasourceCardContainerStyle", (tag) => {
cy.get(tag) cy.get(tag)
.should("have.css", "min-width", "150px") .should("have.css", "min-width", "150px")