Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: update column position check in TableV2 freeze column test (#41130)

Browse Source 
## Description
<ins>Problem</ins>

The freeze column test in TableV2 is failing due to incorrect column
position checks.

<ins>Root cause</ins>

The test logic for verifying column positions does not accurately
reflect the expected behavior after columns are frozen.

<ins>Solution</ins>

This PR handles updating the column position check logic in the TableV2
freeze column test to ensure it correctly validates the positions of
columns after freezing.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/16494079609>
> Commit: b0496c58d9df265e06e8090667d865bc0957c39a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16494079609&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Thu, 24 Jul 2025 10:56:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Updated test to verify the frozen column appears in the correct
position after table data changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Rahul Barwal 2025-07-28 11:32:03 +05:30 committed by GitHub
parent 8ce52fe39e
commit 2934bc6aa4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/freeze_column_query_change_spec.js
View File

@ -46,8 +46,9 @@ describe(
cy.openPropertyPane(WIDGET.TABLE); cy.openPropertyPane(WIDGET.TABLE);
cy.updateCodeInput(PROPERTY_SELECTOR.tableData, TABLE_DATA_STATIC); cy.updateCodeInput(PROPERTY_SELECTOR.tableData, TABLE_DATA_STATIC);
cy.wait(1000);
//Check the id column is still frozen to the right: //Check the id column is still frozen to the right:
cy.checkColumnPosition("customColumn1", 5); cy.checkColumnPosition("customColumn1", 4);
}); });
it("1.3 Check if the custom + common columns retain their positon", () => { it("1.3 Check if the custom + common columns retain their positon", () => {