From 2729bbff286c5098b9d582daed7a448a99e6ab5b Mon Sep 17 00:00:00 2001 From: Saroj <43822041+sarojsarab@users.noreply.github.com> Date: Wed, 19 Apr 2023 17:40:09 +0530 Subject: [PATCH] ci: Fix for ci-merge-check.yml issues (#22564) ## Description - Fix for ci-merge-check.yml issues ## Type of change - ci-merge-check.yml ## How Has This Been Tested? - Github actions ## Checklist: ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --- .github/workflows/ci-merge-check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-merge-check.yml b/.github/workflows/ci-merge-check.yml index 8b0edd17cf..ff8b5a100e 100644 --- a/.github/workflows/ci-merge-check.yml +++ b/.github/workflows/ci-merge-check.yml @@ -56,14 +56,14 @@ jobs: id: verify_checks run: | if [ ${{ steps.ci_test_result_status.outputs.ci_test_result }} == 1 ]; then - if [ ${{ steps.ci_test_result_status.outputs.ci_test_status }} > 0 ]; then + if [ ${{ steps.ci_test_result_status.outputs.ci_test_status }} -gt 0 ]; then echo "msg=Looks like there are some Cypress failures. Can't Merge" >> $GITHUB_OUTPUT exit 1 - elif [ ${{ steps.ci_test_result_status.outputs.perf_test_status }} > 0 ]; then + elif [ ${{ steps.ci_test_result_status.outputs.perf_test_status }} -gt 0 ]; then echo "msg=Looks like Perf-Test is failed. Contact perf team to get their confirmation. Can't Merge" >> $GITHUB_OUTPUT exit 1 fi - elif [ ${{ steps.suite_status_check.outputs.status2 }} > 0 ]; then + elif [ ${{ steps.suite_status_check.outputs.status2 }} == 0 ]; then echo "msg=Looks like you forgot to run /ok-to-test on the latest commit. Can't Merge" >> $GITHUB_OUTPUT exit 1 elif [ ${{ steps.pr_status_check.outputs.status }} != 0 ]; then