diff --git a/app/client/src/pages/Editor/DataSourceEditor/index.tsx b/app/client/src/pages/Editor/DataSourceEditor/index.tsx index 20bba563f3..9d077cf1d9 100644 --- a/app/client/src/pages/Editor/DataSourceEditor/index.tsx +++ b/app/client/src/pages/Editor/DataSourceEditor/index.tsx @@ -453,7 +453,6 @@ class DatasourceEditorRouter extends React.Component { formConfig, formData, formName, - history, isFormDirty, isInsideReconnectModal, isSaving, @@ -492,29 +491,6 @@ class DatasourceEditorRouter extends React.Component { ); } - // for saas form - if (pluginType === "SAAS") { - // todo check if we can remove the flag here - if (isInsideReconnectModal) { - return ( - - ); - } - history.push( - saasEditorDatasourceIdURL({ - pageId, - pluginPackageName, - datasourceId, - }), - ); - return null; - } // Default to DB Editor Form return ( @@ -567,14 +543,17 @@ class DatasourceEditorRouter extends React.Component { datasourceId, deleteTempDSFromDraft, formData, + history, isDeleting, isInsideReconnectModal, isNewDatasource, isPluginAuthorized, isSaving, + pageId, pluginId, pluginImage, pluginName, + pluginPackageName, pluginType, setDatasourceViewMode, showDebugger, @@ -586,6 +565,30 @@ class DatasourceEditorRouter extends React.Component { return ; } + // for saas form + if (pluginType === "SAAS") { + // todo check if we can remove the flag here + if (isInsideReconnectModal) { + return ( + + ); + } + history.push( + saasEditorDatasourceIdURL({ + pageId, + pluginPackageName, + datasourceId, + }), + ); + return null; + } + return (
{ e.preventDefault(); }} > - {(!viewMode || createFlow) && ( + {(!viewMode || createFlow || isInsideReconnectModal) && ( <> {/* This adds information banner when creating google sheets datasource, this info banner explains why appsmith requires permissions from users google account */} @@ -425,9 +425,6 @@ class DatasourceSaaSEditor extends JSONtoForm { datasource={datasource} description={googleSheetsInfoMessage} pageId={pageId} - style={{ - paddingTop: "24px", - }} /> ) : null} {/* This adds error banner for google sheets datasource if the datasource is unauthorised */} @@ -440,7 +437,7 @@ class DatasourceSaaSEditor extends JSONtoForm { description={authErrorMessage} pageId={pageId} style={{ - paddingTop: "24px", + marginTop: "16px", }} /> ) : null} @@ -450,10 +447,11 @@ class DatasourceSaaSEditor extends JSONtoForm { {""} )} - {viewMode && ( + {viewMode && !isInsideReconnectModal && ( {datasource && isGoogleSheetPlugin && !isPluginAuthorized ? (