fix: Fix undefined section values in datasource card (#23884)
The isNil function only checks for undefined values like strings but not for objects, hence switching this with isEmpty. Fixes #23679 #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
This commit is contained in:
parent
8ace8a36df
commit
260236bdbf
|
|
@ -1,7 +1,7 @@
|
|||
import type { Datasource } from "entities/Datasource";
|
||||
import { isStoredDatasource, PluginType } from "entities/Action";
|
||||
import React, { memo, useCallback, useEffect, useState } from "react";
|
||||
import { debounce, isNil } from "lodash";
|
||||
import { debounce, isEmpty } from "lodash";
|
||||
import { useDispatch, useSelector } from "react-redux";
|
||||
import CollapseComponent from "components/utils/CollapseComponent";
|
||||
import {
|
||||
|
|
@ -366,7 +366,7 @@ function DatasourceCard(props: DatasourceCardProps) {
|
|||
</ButtonsWrapper>
|
||||
</DatasourceCardHeader>
|
||||
</DatasourceCardMainBody>
|
||||
{!isNil(currentFormConfig) && (
|
||||
{!isEmpty(currentFormConfig) && (
|
||||
<CollapseComponentWrapper
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
import type { Datasource } from "entities/Datasource";
|
||||
import { isStoredDatasource } from "entities/Action";
|
||||
import React from "react";
|
||||
import { isNil } from "lodash";
|
||||
import { isEmpty } from "lodash";
|
||||
import { useSelector } from "react-redux";
|
||||
import { Colors } from "constants/Colors";
|
||||
import { useParams } from "react-router";
|
||||
|
|
@ -153,7 +153,7 @@ function DatasourceCard(props: DatasourceCardProps) {
|
|||
/>
|
||||
</ButtonsWrapper>
|
||||
</DatasourceCardHeader>
|
||||
{!isNil(currentFormConfig) ? (
|
||||
{!isEmpty(currentFormConfig) ? (
|
||||
<RenderDatasourceInformation
|
||||
config={currentFormConfig[0]}
|
||||
datasource={datasource}
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user