feat: add loading spinner for action execution (#24078)
When action execution is triggered, we show no signs or indications of the action running in other parts of the page except for the run button, This PR introduces a spinner in the ResponseView for both APIs and Queries. Fixes #23956 - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
d741628997
commit
2480a3c3fc
|
|
@ -5,8 +5,7 @@ import {
|
|||
createMessage,
|
||||
} from "@appsmith/constants/messages";
|
||||
import ActionAPI from "api/ActionAPI";
|
||||
import { Button } from "design-system";
|
||||
import { TextType, Text } from "design-system-old";
|
||||
import { Button, Spinner, Text } from "design-system";
|
||||
import styled from "styled-components";
|
||||
import type { EditorTheme } from "./CodeEditor/EditorConfig";
|
||||
import LoadingOverlayScreen from "./LoadingOverlayScreen";
|
||||
|
|
@ -29,6 +28,10 @@ const LoadingProgressWrapper = styled.div`
|
|||
height: 100%;
|
||||
`;
|
||||
|
||||
const InProgressText = styled(Text)`
|
||||
text-align: center;
|
||||
`;
|
||||
|
||||
const handleCancelActionExecution = () => {
|
||||
ActionAPI.abortActionExecutionTokenSource.cancel();
|
||||
};
|
||||
|
|
@ -46,9 +49,10 @@ const ActionExecutionInProgressView = ({
|
|||
<LoadingProgressWrapper>
|
||||
<LoadingOverlayScreen theme={theme} />
|
||||
<LoadingOverlayContainer>
|
||||
<Text textAlign="center" type={TextType.P1}>
|
||||
<Spinner size="md" />
|
||||
<InProgressText kind="body-m" renderAs="p">
|
||||
{createMessage(ACTION_EXECUTION_MESSAGE, actionType)}
|
||||
</Text>
|
||||
</InProgressText>
|
||||
<Button
|
||||
className={`t--cancel-action-button`}
|
||||
kind="secondary"
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user