From 211dc11ffb2c707cf2cabd7c8a993fa4732ba333 Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Mon, 12 Aug 2024 20:45:30 +0530 Subject: [PATCH] fix: View mode canvas margin (#35619) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Removes the extra margin added in the View Mode when Navigation is as Sidebar. It was noticed that the width of the sidebar was already accounted for and was reduced from the available width unnecessarily Fixes #35618 ## Automation /ok-to-test tags="@tag.IDE" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 9778e836c9c8b13e4f6f0971ff36407f452b5d08 > Cypress dashboard. > Tags: `@tag.IDE` > Spec: >
Mon, 12 Aug 2024 10:18:59 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Improvements** - Enhanced the auto-resizing behavior of the app's canvas by streamlining the parameters used in the resizing hook, potentially improving performance and user experience. --- app/client/src/pages/AppViewer/AppPage/AppPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/src/pages/AppViewer/AppPage/AppPage.tsx b/app/client/src/pages/AppViewer/AppPage/AppPage.tsx index 0c24edd103..5dd3f5f5cc 100644 --- a/app/client/src/pages/AppViewer/AppPage/AppPage.tsx +++ b/app/client/src/pages/AppViewer/AppPage/AppPage.tsx @@ -34,7 +34,7 @@ export function AppPage(props: AppPageProps) { }, [isAnvilLayout, canvasWidth]); const pageViewWrapperRef = useRef(null); - useCanvasWidthAutoResize({ ref: pageViewWrapperRef, sidebarWidth }); + useCanvasWidthAutoResize({ ref: pageViewWrapperRef }); useEffect(() => { AnalyticsUtil.logEvent("PAGE_LOAD", {