Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

In case of no mustache bindings are found in dynamic path list, throw invalid dynamic binding reference error. (#3394)

Browse Source
This commit is contained in:
Trisha Anand 2021-03-04 15:35:46 +05:30 committed by GitHub
parent 39e4990a7f
commit 20ed017a58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/server/appsmith-server/src/main/java/com/appsmith/server/services/LayoutActionServiceImpl.java
View File

@ -346,6 +346,13 @@ public class LayoutActionServiceImpl implements LayoutActionService {
// Only extract mustache keys from leaf nodes // Only extract mustache keys from leaf nodes
if (parent != null && isLeafNode) { if (parent != null && isLeafNode) {
Set<String> mustacheKeysFromFields = MustacheHelper.extractMustacheKeysFromFields(parent); Set<String> mustacheKeysFromFields = MustacheHelper.extractMustacheKeysFromFields(parent);
// We found the path. But if the path does not have any mustache bindings, throw the error
if (mustacheKeysFromFields.isEmpty()) {
throw new AppsmithException(AppsmithError.INVALID_DYNAMIC_BINDING_REFERENCE, widgetType,
widgetName, widgetId, fieldPath, pageId, layoutId);
}
dynamicBindings.addAll(mustacheKeysFromFields); dynamicBindings.addAll(mustacheKeysFromFields);
} }
} }