Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Remove Excel download option from Table widget (#38996)

Browse Source
This commit is contained in:
Rahul Barwal 2025-02-04 16:13:57 +05:30 committed by GitHub
parent 3bbdcbc257
commit 1de24080a5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
View File

@ -36,8 +36,9 @@ describe(
//cy.verifyDownload("Table1.csv") //cy.verifyDownload("Table1.csv")
table.ValidateDownloadNVerify("Table1.csv", "Michael Lawson"); table.ValidateDownloadNVerify("Table1.csv", "Michael Lawson");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("Table1.xlsx", "Michael Lawson"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("Table1.xlsx", "Michael Lawson");
}); });
it("2. Verify Searched data - download csv and download Excel", function () { it("2. Verify Searched data - download csv and download Excel", function () {
@ -51,16 +52,18 @@ describe(
//cy.verifyDownload("Table1.csv") //cy.verifyDownload("Table1.csv")
table.ValidateDownloadNVerify("Table1.csv", "byron.fields@reqres.in"); table.ValidateDownloadNVerify("Table1.csv", "byron.fields@reqres.in");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("Table1.xlsx", "Ryan Holmes"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("Table1.xlsx", "Ryan Holmes");
table.RemoveSearchTextNVerify("2381224", "v2"); table.RemoveSearchTextNVerify("2381224", "v2");
table.DownloadFromTable("Download as CSV"); table.DownloadFromTable("Download as CSV");
table.ValidateDownloadNVerify("Table1.csv", "2736212"); table.ValidateDownloadNVerify("Table1.csv", "2736212");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("Table1.xlsx", "Beef steak"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("Table1.xlsx", "Beef steak");
}); });
it("3. Verify Filtered data - download csv and download Excel", function () { it("3. Verify Filtered data - download csv and download Excel", function () {
@ -75,8 +78,9 @@ describe(
//cy.verifyDownload("Table1.csv") //cy.verifyDownload("Table1.csv")
table.ValidateDownloadNVerify("Table1.csv", "Beef steak"); table.ValidateDownloadNVerify("Table1.csv", "Beef steak");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("Table1.xlsx", "tobias.funke@reqres.in"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("Table1.xlsx", "tobias.funke@reqres.in");
agHelper.GetNClick(table._filterBtn); agHelper.GetNClick(table._filterBtn);
table.RemoveFilterNVerify("2381224", true, false, 0, "v2"); table.RemoveFilterNVerify("2381224", true, false, 0, "v2");
@ -84,8 +88,9 @@ describe(
table.DownloadFromTable("Download as CSV"); table.DownloadFromTable("Download as CSV");
table.ValidateDownloadNVerify("Table1.csv", "Tuna Salad"); table.ValidateDownloadNVerify("Table1.csv", "Tuna Salad");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("Table1.xlsx", "Avocado Panini"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("Table1.xlsx", "Avocado Panini");
}); });
it("4. Import TableFilter application & verify all filters for same FirstName (one word column) + Bug 13334", () => { it("4. Import TableFilter application & verify all filters for same FirstName (one word column) + Bug 13334", () => {

5
app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
View File

@ -206,8 +206,9 @@ describe(
table.DownloadFromTable("Download as CSV"); table.DownloadFromTable("Download as CSV");
table.ValidateDownloadNVerify("data_table.csv", "USB Stick (Green)"); table.ValidateDownloadNVerify("data_table.csv", "USB Stick (Green)");
table.DownloadFromTable("Download as Excel"); // @rahulbarwal temporarily commenting download as excel feature till we have a proper fix to the issue: https://github.com/appsmithorg/appsmith/issues/38995
table.ValidateDownloadNVerify("data_table.xlsx", "USB Stick (Leaf)"); // table.DownloadFromTable("Download as Excel");
// table.ValidateDownloadNVerify("data_table.xlsx", "USB Stick (Leaf)");
table.OpenFilter(); table.OpenFilter();
table.RemoveFilter(); table.RemoveFilter();
agHelper agHelper

4
app/client/src/widgets/TableWidgetV2/component/header/actions/Download.tsx
View File

@ -91,10 +91,6 @@ const dowloadOptions: DownloadOptionProps[] = [
label: "Download as CSV", label: "Download as CSV",
value: "CSV", value: "CSV",
}, },
{
label: "Download as Excel",
value: "EXCEL",
},
]; ];
const downloadDataAsCSV = (props: { const downloadDataAsCSV = (props: {