From 1a4961d0890686bd59fb764d86fe832f10a562e2 Mon Sep 17 00:00:00 2001 From: Rajat Agrawal Date: Fri, 12 May 2023 15:49:13 +0530 Subject: [PATCH] =?UTF-8?q?chore:=20Increase=20delay=20before=20discarding?= =?UTF-8?q?=20cell=20value=20in=20flaky=20table=20property=20p=E2=80=A6=20?= =?UTF-8?q?(#23160)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #23161 > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description > Add a TL;DR when description is extra long (helps content team) > > Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation > and context. List any dependencies that are required for this change > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed Co-authored-by: Aishwarya UR --- .../Widgets/TableV2/TableV2_PropertyPane_spec.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/client/cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js b/app/client/cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js index 1aff14d101..02586c65dd 100644 --- a/app/client/cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js +++ b/app/client/cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js @@ -459,9 +459,9 @@ describe("Table Widget V2 property pane feature validation", function () { cy.enterTableCellValue(4, 1, "1{enter}"); cy.get(".bp3-popover-content").should("not.exist"); - cy.wait(500); + cy.wait(1500); cy.discardTableRow(5, 1); - cy.wait(500); + cy.wait(1500); // Value isn't required in Row Index 2 cy.editTableCell(4, 2); @@ -472,7 +472,7 @@ describe("Table Widget V2 property pane feature validation", function () { cy.enterTableCellValue(4, 2, "{enter}"); cy.get(".bp3-popover-content").should("not.exist"); - cy.wait(500); + cy.wait(1500); cy.discardTableRow(5, 2); // Check for Required property using currentRow, row with index 1 has id 7 @@ -489,9 +489,9 @@ describe("Table Widget V2 property pane feature validation", function () { cy.enterTableCellValue(4, 1, "1{enter}"); cy.get(".bp3-popover-content").should("not.exist"); - cy.wait(500); + cy.wait(1500); cy.discardTableRow(5, 1); - cy.wait(500); + cy.wait(1500); // Value isn't required in Row Index 2 cy.editTableCell(4, 2); @@ -503,7 +503,7 @@ describe("Table Widget V2 property pane feature validation", function () { cy.enterTableCellValue(4, 2, "{enter}"); cy.get(".bp3-popover-content").should("not.exist"); - cy.wait(500); + cy.wait(1500); cy.discardTableRow(5, 2); // Cleanup