From 1a40dee4cb8ede1d155b7aec11f8fdb91d5ef831 Mon Sep 17 00:00:00 2001 From: sharanya-appsmith <135708039+sharanya-appsmith@users.noreply.github.com> Date: Tue, 26 Dec 2023 15:41:42 +0530 Subject: [PATCH] ci: changed cypress dashboard url (#29864) ## Description > Changed the url from from > `https://internal.appsmith.com/app/cypress-dashboard/rundetails-64ec3df0c632e24c00764938 `to` https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5` > `https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-6541e22b0c243558fe2288ca?branch=master` to `https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master` #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed ## Summary by CodeRabbit - **Chores** - Updated URLs for the Cypress dashboard in CI/CD workflows to ensure accurate linking to test results and run details. --- .github/workflows/build-client-server.yml | 12 ++++++------ .github/workflows/ci-test-hosted.yml | 4 ++-- .github/workflows/integration-tests-command.yml | 8 ++++---- .../integration-tests-with-documentdb-command.yml | 8 ++++---- .github/workflows/test-build-docker-image.yml | 4 ++-- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build-client-server.yml b/.github/workflows/build-client-server.yml index 5d88091ce7..e975cf44c6 100644 --- a/.github/workflows/build-client-server.yml +++ b/.github/workflows/build-client-server.yml @@ -274,9 +274,9 @@ jobs: issue-number: ${{fromJson(needs.file-check.outputs.pr)}} body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. - Cypress dashboard: Click here! + Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR: ${{env.new_failed_spec_env}} - To know the list of identified flaky tests - Refer here + To know the list of identified flaky tests - Refer here - name: Add a comment on the PR when ci-test-limited is success if: needs.ci-test-limited.result == 'success' && needs.file-check.outputs.pr != '0' @@ -285,7 +285,7 @@ jobs: issue-number: ${{fromJson(needs.file-check.outputs.pr)}} body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. - Cypress dashboard url: Click here! + Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉 - name: Check ci-test-limited set status @@ -391,9 +391,9 @@ jobs: issue-number: ${{fromJson(needs.file-check.outputs.pr)}} body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. - Cypress dashboard: Click here! + Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR: ${{env.new_failed_spec_env}} - To know the list of identified flaky tests - Refer here + To know the list of identified flaky tests - Refer here - name: Add a comment on the PR when ci-test-limited-existing-docker-image is success if: needs.ci-test-limited-existing-docker-image.result == 'success' && needs.file-check.outputs.pr != '0' @@ -402,7 +402,7 @@ jobs: issue-number: ${{fromJson(needs.file-check.outputs.pr)}} body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. - Cypress dashboard url: Click here! + Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉 - name: Check ci-test-limited-existing-docker-image set status diff --git a/.github/workflows/ci-test-hosted.yml b/.github/workflows/ci-test-hosted.yml index 59ab1b42bb..5381d6fcf5 100644 --- a/.github/workflows/ci-test-hosted.yml +++ b/.github/workflows/ci-test-hosted.yml @@ -293,11 +293,11 @@ jobs: id: slack_notification run: | if [[ "${{ steps.test_status.outputs.run_result }}" == "failedtest" ]]; then - echo "slack_message=There are test failures in the run. Cypress Dashboard: " >> $GITHUB_OUTPUT + echo "slack_message=There are test failures in the run. Cypress Dashboard: " >> $GITHUB_OUTPUT echo "slack_color=#FF0000" >> $GITHUB_OUTPUT echo "slack_icon=:parachute:" >> $GITHUB_OUTPUT else - echo "slack_message=All tests passed successfully :tada: . Cypress Dashboard: " >> $GITHUB_OUTPUT + echo "slack_message=All tests passed successfully :tada: . Cypress Dashboard: " >> $GITHUB_OUTPUT echo "slack_color=#00FF00" >> $GITHUB_OUTPUT echo "slack_icon=:eight_spoked_asterisk:" >> $GITHUB_OUTPUT fi diff --git a/.github/workflows/integration-tests-command.yml b/.github/workflows/integration-tests-command.yml index c5c7efe575..66c9bf7181 100644 --- a/.github/workflows/integration-tests-command.yml +++ b/.github/workflows/integration-tests-command.yml @@ -226,9 +226,9 @@ jobs: body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. Commit: `${{ github.event.client_payload.slash_command.args.named.sha }}`. - Cypress dashboard: Click here! + Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR: ${{env.new_failed_spec_env}} - To know the list of identified flaky tests - Refer here + To know the list of identified flaky tests - Refer here - name: Add a comment on the PR when ci-test is failed but no specs found if: needs.ci-test.result != 'success' && steps.combine_ci.outputs.specs_failed == '0' @@ -238,7 +238,7 @@ jobs: body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. Commit: `${{ github.event.client_payload.slash_command.args.named.sha }}`. - Cypress dashboard url: Click here! + Cypress dashboard url: Click here! It seems like there are some failures 😔. We are not able to recognize it, please check this manually here. - name: Add a comment on the PR when ci-test is success @@ -249,7 +249,7 @@ jobs: body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. Commit: `${{ github.event.client_payload.slash_command.args.named.sha }}`. - Cypress dashboard url: Click here! + Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉 # Update check run called "ci-test-result" diff --git a/.github/workflows/integration-tests-with-documentdb-command.yml b/.github/workflows/integration-tests-with-documentdb-command.yml index a3acddcb3e..fc650de629 100644 --- a/.github/workflows/integration-tests-with-documentdb-command.yml +++ b/.github/workflows/integration-tests-with-documentdb-command.yml @@ -95,7 +95,7 @@ jobs: continue-on-error: true id: dashboard_url run: | - cypress_url="https://internal.appsmith.com/app/cypress-dashboard/rundetails-64ec3df0c632e24c00764938?branch=master&workflowId=${{ github.run_id }}&attempt=${{ github.run_attempt }}" + cypress_url="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=${{ github.run_id }}&attempt=${{ github.run_attempt }}" echo "dashboard_url=$cypress_url" >> $GITHUB_OUTPUT # Download failed_spec list for all jobs @@ -153,9 +153,9 @@ jobs: body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. Commit: `${{ github.event.client_payload.slash_command.args.named.sha }}`. - Cypress dashboard: Click here! + Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR: ${{env.new_failed_spec_env}} - To know the list of identified flaky tests - Refer here + To know the list of identified flaky tests - Refer here - name: Add a comment on the PR when ci-test is success if: needs.ci-test.result == 'success' || steps.combine_ci.outputs.specs_failed == '0' @@ -165,7 +165,7 @@ jobs: body: | Workflow run: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}>. Commit: `${{ github.event.client_payload.slash_command.args.named.sha }}`. - Cypress dashboard: Click here! + Cypress dashboard: Click here! All cypress tests have passed 🎉🎉🎉 # Update check run called "ci-test-result" diff --git a/.github/workflows/test-build-docker-image.yml b/.github/workflows/test-build-docker-image.yml index d52ee2094b..f0c261efa2 100644 --- a/.github/workflows/test-build-docker-image.yml +++ b/.github/workflows/test-build-docker-image.yml @@ -170,11 +170,11 @@ jobs: eventCommit=$(echo ${{env.EVENT_COMMITS}} | sed "s/'//g") echo "slack_username=$(echo "$eventCommit" | awk -F '\\\\n' '{print $1}' | sed 's/^"//;s/"$//')" >> $GITHUB_OUTPUT if [[ ${{ needs.ci-test.result }} == 'failure' ]]; then - echo "slack_message=There are test failures in the run. Cypress Dashboard: " >> $GITHUB_OUTPUT + echo "slack_message=There are test failures in the run. Cypress Dashboard: " >> $GITHUB_OUTPUT echo "slack_color=#FF0000" >> $GITHUB_OUTPUT echo "slack_icon=:no_entry:" >> $GITHUB_OUTPUT elif [[ ${{ needs.ci-test.result }} == 'success' ]]; then - echo "slack_message=All tests passed successfully :tada: Cypress Dashboard: " >> $GITHUB_OUTPUT + echo "slack_message=All tests passed successfully :tada: Cypress Dashboard: " >> $GITHUB_OUTPUT echo "slack_color=#00FF00" >> $GITHUB_OUTPUT echo "slack_icon=:white_check_mark:" >> $GITHUB_OUTPUT else