diff --git a/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts index dda428c061..c010131f91 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts @@ -135,7 +135,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNClick(_.propPane._actionCard, 3); _.agHelper.GetNAssertElementText( _.propPane._selectorViewButton, - "Select Modal", + "Select modal", ); }); @@ -559,18 +559,18 @@ describe("JS to non-JS mode in Action Selector", () => { ); _.agHelper.GetNClick(_.propPane._actionCard, 0); - _.agHelper.AssertElementVisible(_.propPane._navigateToType("Page Name")); + _.agHelper.AssertElementVisible(_.propPane._navigateToType("Page name")); _.agHelper.GetNAssertElementText( _.propPane._actionOpenDropdownSelectPage, - "Select Page", + "Select page", "have.text", 0, ); _.agHelper.GetNAssertElementText( _.propPane._actionPopupTextLabel, - "Query Params", + "Query params", "have.text", 0, ); @@ -598,7 +598,7 @@ describe("JS to non-JS mode in Action Selector", () => { ); _.agHelper.GetNClick(_.propPane._actionCard, 0); - _.agHelper.AssertElementVisible(_.propPane._navigateToType("Page Name")); + _.agHelper.AssertElementVisible(_.propPane._navigateToType("Page name")); _.agHelper.GetNAssertElementText( _.propPane._actionOpenDropdownSelectPage, @@ -609,7 +609,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionPopupTextLabel, - "Query Params", + "Query params", "have.text", 0, ); @@ -648,7 +648,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionPopupTextLabel, - "Query Params", + "Query params", "have.text", 1, ); @@ -741,7 +741,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionOpenDropdownSelectModal, - "Select Modal", + "Select modal", "have.text", 0, ); @@ -787,7 +787,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionOpenDropdownSelectModal, - "Select Modal", + "Select modal", "have.text", 0, ); @@ -894,7 +894,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionCard, - "Remove valueAdd Key", + "Remove valueAdd key", "have.text", 0, ); @@ -1098,7 +1098,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._selectorViewButton, - "Select Widget", + "Select widget", "have.text", 0, ); @@ -1188,7 +1188,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._selectorViewButton, - "Select Widget", + "Select widget", "have.text", 0, ); @@ -1279,7 +1279,7 @@ describe("JS to non-JS mode in Action Selector", () => { _.agHelper.GetNAssertElementText( _.propPane._actionCard, - "Clear intervalAdd ID", + "Clear intervalAdd Id", "have.text", 0, ); diff --git a/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts index 2f52f2b950..ebf6537408 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo_spec.ts @@ -25,11 +25,11 @@ describe("Navigate To feature", () => { }); ee.SelectEntityByName("Button1", "Widgets"); propPane.SelectPlatformFunction("onClick", "Navigate to"); - cy.get(".t--open-dropdown-Select-Page").click(); + cy.get(".t--open-dropdown-Select-page").click(); agHelper.AssertElementLength(".bp3-menu-item", 2); cy.get(locator._dropDownValue("Page2")).click(); cy.get("label") - .contains("Query Params") + .contains("Query params") .siblings() .find(".CodeEditorTarget") .then(($el) => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Binding/Input_NavigateTo_validation_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Binding/Input_NavigateTo_validation_spec.js index 52168a2758..b3c042b26c 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Binding/Input_NavigateTo_validation_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Binding/Input_NavigateTo_validation_spec.js @@ -42,7 +42,7 @@ describe("Binding the multiple Widgets and validating NavigateTo Page", function cy.openPropertyPane("inputwidgetv2"); cy.get(widgetsPage.defaultInput).type(testdata.defaultInputWidget); propPane.SelectPlatformFunction("onTextChanged", "Navigate to"); - cy.get(".t--open-dropdown-Select-Page").click(); + cy.get(".t--open-dropdown-Select-page").click(); cy.get(commonlocators.singleSelectMenuItem) .contains(pageid) .click({ force: true }); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2Widgets_NavigateTo_Validation_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2Widgets_NavigateTo_Validation_spec.js index 7b7f3f1bd8..26b76c7b54 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2Widgets_NavigateTo_Validation_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2Widgets_NavigateTo_Validation_spec.js @@ -43,7 +43,7 @@ describe("Table Widget V2 and Navigate to functionality validation", function () cy.testJsontext("tabledata", JSON.stringify(testdata.TablePagination)); cy.focused().blur(); propPane.SelectPlatformFunction("onRowSelected", "Navigate to"); - cy.get(".t--open-dropdown-Select-Page").click(); + cy.get(".t--open-dropdown-Select-page").click(); cy.get(commonlocators.singleSelectMenuItem) .contains(pageid) .click({ force: true }); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableWidgets_NavigateTo_Validation_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableWidgets_NavigateTo_Validation_spec.js index b3087f3642..add11100af 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableWidgets_NavigateTo_Validation_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableWidgets_NavigateTo_Validation_spec.js @@ -42,7 +42,7 @@ describe("Table Widget and Navigate to functionality validation", function () { cy.testJsontext("tabledata", JSON.stringify(testdata.TablePagination)); cy.focused().blur(); propPane.SelectPlatformFunction("onRowSelected", "Navigate to"); - cy.get(".t--open-dropdown-Select-Page").click(); + cy.get(".t--open-dropdown-Select-page").click(); cy.get(commonlocators.singleSelectMenuItem) .contains(pageid) .click({ force: true }); diff --git a/app/client/cypress/locators/ModalWidget.json b/app/client/cypress/locators/ModalWidget.json index 1ba8a62c05..c753eeb14c 100644 --- a/app/client/cypress/locators/ModalWidget.json +++ b/app/client/cypress/locators/ModalWidget.json @@ -1,9 +1,9 @@ { - "selectModal": ".t--open-dropdown-Select-Modal", + "selectModal": ".t--open-dropdown-Select-modal", "createModalButton": ".t--create-modal-btn", "controlModalType": ".t--property-control-modaltype .bp3-popover-target", "modalWidget": ".t--modal-widget", "modalName": ".t--modal-widget span.t--widget-name", "modelTextField": ".t--modal-widget .t--widget-textwidget", "closeButton": ".t--widget-iconwidget" -} \ No newline at end of file +} diff --git a/app/client/cypress/locators/Widgets.json b/app/client/cypress/locators/Widgets.json index d54ea5211f..ca4e28fb22 100644 --- a/app/client/cypress/locators/Widgets.json +++ b/app/client/cypress/locators/Widgets.json @@ -139,7 +139,7 @@ "toastActionText": ".ads-v2-toast .ads-v2-toast__body .ads-v2-text", "defaultColName": "[data-rbd-draggable-id='customColumn1'] input", "defaultColNameV2": "[data-rbd-draggable-id='customColumn1'] input[type='text']", - "selectWidget": ".t--open-dropdown-Select-Widget", + "selectWidget": ".t--open-dropdown-Select-widget", "switchWidget": ".t--widget-switchwidget", "toastMsg": ".ads-v2-toast .ads-v2-toast__body .ads-v2-text", "deleteToast": "div[class = 'undo-section'] span[type='h6']", diff --git a/app/client/cypress/locators/commonlocators.json b/app/client/cypress/locators/commonlocators.json index 869506c656..981b265a4d 100644 --- a/app/client/cypress/locators/commonlocators.json +++ b/app/client/cypress/locators/commonlocators.json @@ -101,7 +101,7 @@ "chooseAction": ".single-select", "chooseMsgType": ".t--open-dropdown-Select-type", "onPause": ".t--property-control-onpause .t--open-dropdown-Select-Action", - "chooseWidget": ".t--open-dropdown-Select-Widget", + "chooseWidget": ".t--open-dropdown-Select-widget", "onClick": ".t--property-control-onclick .t--open-dropdown-Select-Action", "changeZoomlevel": ".t--property-control-maxzoomlevel input", "selectedZoomlevel": ".t--property-control-maxzoomlevel .rc-select-selection-item span", diff --git a/app/client/cypress/support/Pages/PropertyPane.ts b/app/client/cypress/support/Pages/PropertyPane.ts index da170e0495..3e42631351 100644 --- a/app/client/cypress/support/Pages/PropertyPane.ts +++ b/app/client/cypress/support/Pages/PropertyPane.ts @@ -76,9 +76,9 @@ export class PropertyPane { _actionCallbackTitle = ".action-callback-add"; _actionTreeCollapse = ".callback-collapse"; _actionPopupTextLabel = '[data-testid="text-view-label"]'; - _actionOpenDropdownSelectModal = ".t--open-dropdown-Select-Modal"; + _actionOpenDropdownSelectModal = ".t--open-dropdown-Select-modal"; _selectorViewButton = ".selector-view .bp3-button-text"; - _actionOpenDropdownSelectPage = ".t--open-dropdown-Select-Page"; + _actionOpenDropdownSelectPage = ".t--open-dropdown-Select-page"; _sameWindowDropdownOption = ".t--open-dropdown-Same-window"; _navigateToType = (type: string) => "div.tab-view span:contains('" + type + "')"; diff --git a/app/client/src/components/editorComponents/ActionCreator/Field/FieldConfig.ts b/app/client/src/components/editorComponents/ActionCreator/Field/FieldConfig.ts index 4d2d7e009d..c0d653c0f8 100644 --- a/app/client/src/components/editorComponents/ActionCreator/Field/FieldConfig.ts +++ b/app/client/src/components/editorComponents/ActionCreator/Field/FieldConfig.ts @@ -122,7 +122,7 @@ export const FIELD_CONFIG: AppsmithFunctionConfigType = { view: ViewTypes.TEXT_VIEW, }, [FieldType.QUERY_PARAMS_FIELD]: { - label: () => "Query Params", + label: () => "Query params", defaultText: "", exampleText: "navigateTo('Page1', { a: 1 }, 'SAME_WINDOW')", options: () => null, @@ -365,9 +365,9 @@ export const FIELD_CONFIG: AppsmithFunctionConfigType = { view: ViewTypes.TEXT_VIEW, }, [FieldType.SHOW_MODAL_FIELD]: { - label: () => "Modal Name", + label: () => "Modal name", options: (props: FieldProps) => props.modalDropdownList, - defaultText: "Select Modal", + defaultText: "Select modal", exampleText: "showModal('Modal1')", getter: (value: any) => { return modalGetter(value); @@ -378,9 +378,9 @@ export const FIELD_CONFIG: AppsmithFunctionConfigType = { view: ViewTypes.SELECTOR_VIEW, }, [FieldType.CLOSE_MODAL_FIELD]: { - label: () => "Modal Name", + label: () => "Modal name", options: (props: FieldProps) => props.modalDropdownList, - defaultText: "Select Modal", + defaultText: "Select modal", exampleText: "closeModal('Modal1')", getter: (value: any) => { return modalGetter(value); @@ -394,7 +394,7 @@ export const FIELD_CONFIG: AppsmithFunctionConfigType = { label: () => "Widget", exampleText: "resetWidget('Modal1', true)", options: (props: FieldProps) => props.widgetOptionTree, - defaultText: "Select Widget", + defaultText: "Select widget", getter: (value: any) => { return enumTypeGetter(value, 0); }, @@ -421,10 +421,10 @@ export const FIELD_CONFIG: AppsmithFunctionConfigType = { view: ViewTypes.SELECTOR_VIEW, }, [FieldType.PAGE_SELECTOR_FIELD]: { - label: () => "Choose Page", + label: () => "Choose page", exampleText: "navigateTo('Page1', { a: 1 }, 'SAME_WINDOW')", options: (props: FieldProps) => props.pageDropdownOptions, - defaultText: "Select Page", + defaultText: "Select page", getter: (value: any) => { return enumTypeGetter(value, 0, ""); }, diff --git a/app/client/src/components/editorComponents/ActionCreator/FieldGroup/index.tsx b/app/client/src/components/editorComponents/ActionCreator/FieldGroup/index.tsx index 5e3cd0dc38..2e4c47f92f 100644 --- a/app/client/src/components/editorComponents/ActionCreator/FieldGroup/index.tsx +++ b/app/client/src/components/editorComponents/ActionCreator/FieldGroup/index.tsx @@ -13,7 +13,7 @@ function FieldGroup(props: FieldGroupProps) { const NAVIGATE_TO_TAB_SWITCHER: Array = [ { id: "page-name", - text: "Page Name", + text: "Page name", action: () => { setActiveTabNavigateTo(NAVIGATE_TO_TAB_SWITCHER[0]); }, diff --git a/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionBlockTree/utils.tsx b/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionBlockTree/utils.tsx index 14aa0d7eb0..7ed37cba9c 100644 --- a/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionBlockTree/utils.tsx +++ b/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionBlockTree/utils.tsx @@ -166,7 +166,7 @@ function getActionHeading( case AppsmithFunction.removeValue: return ( FIELD_CONFIG[FieldType.KEY_TEXT_FIELD_REMOVE_VALUE].getter(code) || - "Add Key" + "Add key" ); case AppsmithFunction.setInterval: @@ -177,7 +177,7 @@ function getActionHeading( case AppsmithFunction.clearInterval: return ( - FIELD_CONFIG[FieldType.CLEAR_INTERVAL_ID_FIELD].getter(code) || "Add ID" + FIELD_CONFIG[FieldType.CLEAR_INTERVAL_ID_FIELD].getter(code) || "Add Id" ); case AppsmithFunction.getGeolocation: diff --git a/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionSelectorView/index.tsx b/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionSelectorView/index.tsx index 134e147a61..c1182be59e 100644 --- a/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionSelectorView/index.tsx +++ b/app/client/src/components/editorComponents/ActionCreator/viewComponents/ActionSelectorView/index.tsx @@ -4,7 +4,7 @@ import { TreeDropdown } from "design-system-old"; import { Input } from "design-system"; import { debounce } from "lodash"; import { FIELD_CONFIG } from "../../Field/FieldConfig"; -import { FieldType } from "../../constants"; +import { AppsmithFunction, FieldType } from "../../constants"; import { flattenOptions, getCodeFromMoustache, @@ -113,7 +113,15 @@ export const ActionSelectorView: React.FC = ({ props.set(pageParams) diff --git a/app/client/src/components/editorComponents/ActionCreator/viewComponents/SelectorView/SelectorView.test.tsx b/app/client/src/components/editorComponents/ActionCreator/viewComponents/SelectorView/SelectorView.test.tsx index 446b45af76..ac6aa25e84 100644 --- a/app/client/src/components/editorComponents/ActionCreator/viewComponents/SelectorView/SelectorView.test.tsx +++ b/app/client/src/components/editorComponents/ActionCreator/viewComponents/SelectorView/SelectorView.test.tsx @@ -13,9 +13,9 @@ describe("Selector view component", () => { value: "'Page1'", }, ], - label: "Choose Page", + label: "Choose page", value: "{{navigateTo('Page1', {}, 'SAME_WINDOW')}}", - defaultText: "Select Page", + defaultText: "Select page", displayValue: "", get: () => { return 1; @@ -27,7 +27,7 @@ describe("Selector view component", () => { test("Renders selector view component correctly", () => { render(); expect(screen.getByTestId("selector-view-label")).toHaveTextContent( - "Choose Page", + "Choose page", ); }); }); diff --git a/app/client/src/components/editorComponents/ActionCreator/viewComponents/TabView/TabView.test.tsx b/app/client/src/components/editorComponents/ActionCreator/viewComponents/TabView/TabView.test.tsx index c72582c179..ca6fa9b305 100644 --- a/app/client/src/components/editorComponents/ActionCreator/viewComponents/TabView/TabView.test.tsx +++ b/app/client/src/components/editorComponents/ActionCreator/viewComponents/TabView/TabView.test.tsx @@ -9,7 +9,7 @@ describe("Tab View component", () => { label: "Type", activeObj: { id: "page-name", - text: "Page Name", + text: "Page name", action: () => { return 1; }, @@ -17,7 +17,7 @@ describe("Tab View component", () => { switches: [ { id: "page-name", - text: "Page Name", + text: "Page name", action: () => { return 1; },