chore: Added check to prevent infinite recursion in logs dependency chain helper (#26800)

## Description
`getDependencyChain` method goes into infinite recursion when there is a
cycle in the dependency map. This PR adds logic to exit early if the
path is processed already

>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes #26595 

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
>
## Testing
- [ ] Manual
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
arunvjn 2023-08-31 17:04:03 +05:30 committed by GitHub
parent 926235f70c
commit 159676abc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -179,26 +179,35 @@ export function getDependencyChain(
propertyPath: string,
inverseMap: DependencyMap,
) {
let currentChain: string[] = [];
const dependents = inverseMap[propertyPath];
const visited = new Set<string>();
if (!dependents || !dependents.length) return currentChain;
return getDependencyChainHelper(propertyPath);
const { entityName } = getEntityNameAndPropertyPath(propertyPath);
function getDependencyChainHelper(propertyPath: string): string[] {
let currentChain: string[] = [];
const dependents = inverseMap[propertyPath];
dependents.map((dependentPath) => {
if (!isChildPropertyPath(entityName, dependentPath)) {
currentChain.push(dependentPath);
if (!dependents || !dependents.length) return currentChain;
if (visited.has(propertyPath)) return currentChain;
const { entityName } = getEntityNameAndPropertyPath(propertyPath);
visited.add(propertyPath);
for (const dependentPath of dependents) {
if (!isChildPropertyPath(entityName, dependentPath)) {
currentChain.push(dependentPath);
}
if (dependentPath !== entityName) {
currentChain = union(
currentChain,
getDependencyChain(dependentPath, inverseMap),
);
}
}
if (dependentPath !== entityName) {
currentChain = union(
currentChain,
getDependencyChain(dependentPath, inverseMap),
);
}
});
return currentChain;
return currentChain;
}
}
export const doesEntityHaveErrors = (