From 138cb7928fc4e16f7f4dc1af83c925f7019de140 Mon Sep 17 00:00:00 2001 From: Rudraprasad Das Date: Mon, 30 Sep 2024 12:45:35 +0800 Subject: [PATCH] fix: fixing modal height by removing min-content (#36589) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description min-content css property is behaving weirdly in the latest update of the chrome browser Fixes https://github.com/appsmithorg/appsmith/issues/36586 ## Automation /ok-to-test tags="@tag.Git" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: a888acf77730a014fe6d708bf8ed9b48e0cb8029 > Cypress dashboard. > Tags: `@tag.Git` > Spec: >
Sat, 28 Sep 2024 14:34:20 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Style** - Removed the minimum height constraint from the modal body, allowing for more flexible vertical space allocation in the modal display. --- .../src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx b/app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx index 78d4c81889..2212d561a6 100644 --- a/app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx +++ b/app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx @@ -32,7 +32,6 @@ const StyledModalBody = styled(ModalBody)` overflow-y: initial; display: flex; flex-direction: column; - min-height: min-content; max-height: calc( 100vh - 200px - 32px - 56px - 44px ); // 200px offset, 32px outer padding, 56px footer, 44px header