Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: flicker issue when both the min max values collide (#18547)

Browse Source
This commit is contained in:
ankurrsinghal 2022-11-30 12:52:44 +05:30 committed by GitHub
parent 04ed5329a1
commit 11dfa2c8e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/client/src/components/autoHeightOverlay/index.tsx
View File

@ -159,6 +159,9 @@ const AutoHeightOverlay: React.FC<AutoHeightOverlayProps> = memo(
const finalMinY = minY + mindY; const finalMinY = minY + mindY;
useEffect(() => { useEffect(() => {
// reset the diff on backend update
setMindY(0);
setMaxdY(0);
setMaxY(maxDynamicHeight * GridDefaults.DEFAULT_GRID_ROW_HEIGHT); setMaxY(maxDynamicHeight * GridDefaults.DEFAULT_GRID_ROW_HEIGHT);
}, [maxDynamicHeight]); }, [maxDynamicHeight]);
@ -220,8 +223,6 @@ const AutoHeightOverlay: React.FC<AutoHeightOverlayProps> = memo(
if (heightToSet === minY + mindY) { if (heightToSet === minY + mindY) {
batchUpdate(heightToSet); batchUpdate(heightToSet);
setMindY(0);
setMaxdY(0);
} else { } else {
updateMaxHeight(heightToSet); updateMaxHeight(heightToSet);
setMaxdY(0); setMaxdY(0);
@ -231,6 +232,9 @@ const AutoHeightOverlay: React.FC<AutoHeightOverlayProps> = memo(
} }
useEffect(() => { useEffect(() => {
// reset the diff on backend update
setMindY(0);
setMaxdY(0);
setMinY(minDynamicHeight * GridDefaults.DEFAULT_GRID_ROW_HEIGHT); setMinY(minDynamicHeight * GridDefaults.DEFAULT_GRID_ROW_HEIGHT);
}, [minDynamicHeight]); }, [minDynamicHeight]);
@ -258,8 +262,6 @@ const AutoHeightOverlay: React.FC<AutoHeightOverlayProps> = memo(
if (heightToSet === maxY + maxdY) { if (heightToSet === maxY + maxdY) {
batchUpdate(heightToSet); batchUpdate(heightToSet);
setMindY(0);
setMaxdY(0);
} else { } else {
updateMinHeight(heightToSet); updateMinHeight(heightToSet);
setMindY(0); setMindY(0);