chore: add QA checklist for PR's (#17947)
This commit is contained in:
parent
1afbe27456
commit
10f755ee5b
24
.github/pull_request_template.md
vendored
24
.github/pull_request_template.md
vendored
|
|
@ -5,13 +5,19 @@
|
|||
## Description
|
||||
|
||||
> Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
|
||||
> and context. List any dependencies that are required for this change.
|
||||
> and context. List any dependencies that are required for this change
|
||||
> Links to Notion, Figma or any other documents that might be relevant to the PR
|
||||
|
||||
> Add a TL;DR when description is extra long (helps content team)
|
||||
|
||||
Fixes # (issue)
|
||||
|
||||
> if no issue exists, please create an issue and ask the maintainers about this first
|
||||
|
||||
|
||||
Media
|
||||
> A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
|
||||
|
||||
|
||||
## Type of change
|
||||
|
||||
> Please delete options that are not relevant.
|
||||
|
|
@ -23,7 +29,6 @@ Fixes # (issue)
|
|||
|
||||
|
||||
## How Has This Been Tested?
|
||||
|
||||
> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
|
||||
> Please also list any relevant details for your test configuration.
|
||||
> Delete anything that is not important
|
||||
|
|
@ -36,11 +41,11 @@ Fixes # (issue)
|
|||
> Add Testsmith test cases links that relate to this PR
|
||||
|
||||
### Issues raised during DP testing
|
||||
> Link issues raised during DP testing for better visiblity and tracking
|
||||
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
|
||||
|
||||
|
||||
## Checklist:
|
||||
|
||||
### Dev activity
|
||||
- [ ] My code follows the style guidelines of this project
|
||||
- [ ] I have performed a self-review of my own code
|
||||
- [ ] I have commented my code, particularly in hard-to-understand areas
|
||||
|
|
@ -48,3 +53,12 @@ Fixes # (issue)
|
|||
- [ ] My changes generate no new warnings
|
||||
- [ ] I have added tests that prove my fix is effective or that my feature works
|
||||
- [ ] New and existing unit tests pass locally with my changes
|
||||
- [ ] PR is being merged under a feature flag
|
||||
|
||||
|
||||
### QA activity:
|
||||
- [ ] Test plan has been approved by relevant developers
|
||||
- [ ] Test plan has been peer reviewed by QA
|
||||
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
|
||||
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
|
||||
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user