Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix Local setup changes to accommodate M1 chip Macbooks. (#2959)

Browse Source 
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
This commit is contained in:
Ashok Kumar M 2021-02-10 16:12:01 +05:30 committed by GitHub
parent 2a7f7ba8c4
commit 0da3421dc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/package.json
View File

@ -128,6 +128,7 @@
"scripts": { "scripts": {
"analyze": "source-map-explorer 'build/static/js/*.js'", "analyze": "source-map-explorer 'build/static/js/*.js'",
"start": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT HOST=dev.appsmith.com craco start", "start": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT HOST=dev.appsmith.com craco start",
"start-m1": "BROWSER=none EXTEND_ESLINT=true REACT_APP_ENVIRONMENT=DEVELOPMENT HOST=0.0.0.0 craco start",
"build": "./build.sh", "build": "./build.sh",
"build-local": "craco --max-old-space-size=4096 build --config craco.build.config.js", "build-local": "craco --max-old-space-size=4096 build --config craco.build.config.js",
"build-staging": "REACT_APP_ENVIRONMENT=STAGING craco --max-old-space-size=4096 build --config craco.build.config.js", "build-staging": "REACT_APP_ENVIRONMENT=STAGING craco --max-old-space-size=4096 build --config craco.build.config.js",

8
app/client/start-https.sh
View File

@ -87,6 +87,14 @@ case "${uname_out}" in
" "
;; ;;
Darwin*) machine=Mac Darwin*) machine=Mac
# workaround for apple silicon until host.docker.interal works as expected
if [[ "$(uname -m)" = "arm64" ]]; then
# if no server was passed
if [[ -z $1 ]]; then
server_proxy_pass='http://"$(ipconfig getifaddr en0)":8080'
fi
client_proxy_pass='http://"$(ipconfig getifaddr en0)":3000'
fi
echo " echo "
Starting nginx for MacOS... Starting nginx for MacOS...
" "

1
contributions/ClientSetup.md
View File

@ -70,6 +70,7 @@ On your development machine, please ensure that:
- By default your client app points to the local api server - `http://host.docker.internal:8080` for MacOS or `http://localhost:8080` for Linux. Your page will load with errors if you don't have the api server running on your local system. To setup the api server on your local system please follow the instructions [here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ServerSetup.md) - By default your client app points to the local api server - `http://host.docker.internal:8080` for MacOS or `http://localhost:8080` for Linux. Your page will load with errors if you don't have the api server running on your local system. To setup the api server on your local system please follow the instructions [here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ServerSetup.md)
- In case you are unable to setup the api server on your local system, you can also [use Appsmith's staging API server](#if-you-would-like-to-hit-a-different-appsmith-server). - In case you are unable to setup the api server on your local system, you can also [use Appsmith's staging API server](#if-you-would-like-to-hit-a-different-appsmith-server).
- In case you are using a M1 chip Macbook please run the client with `yarn start-m1`.
#### If yarn start throws mismatch node version error #### If yarn start throws mismatch node version error