move null check out (#2221)

This commit is contained in:
Piyush Mishra 2020-12-16 14:52:34 +05:30 committed by GitHub
parent 2f152bf5b1
commit 0ccc80127a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -464,11 +464,12 @@ export const renderCell = (
columnType: string,
isHidden: boolean,
) => {
if (!value) {
return <CellWrapper isHidden={isHidden}></CellWrapper>;
}
switch (columnType) {
case ColumnTypes.IMAGE:
if (!value) {
return <CellWrapper isHidden={isHidden}></CellWrapper>;
} else if (!isString(value)) {
if (!isString(value)) {
return (
<CellWrapper isHidden={isHidden}>
<div>Invalid Image </div>
@ -505,9 +506,7 @@ export const renderCell = (
);
case ColumnTypes.VIDEO:
const youtubeRegex = /^.*(youtu.be\/|v\/|u\/\w\/|embed\/|watch\?v=|&v=|\?v=)([^#&?]*).*/;
if (!value) {
return <CellWrapper isHidden={isHidden}></CellWrapper>;
} else if (isString(value) && youtubeRegex.test(value)) {
if (isString(value) && youtubeRegex.test(value)) {
return (
<CellWrapper isHidden={isHidden} className="video-cell">
<PopoverVideo url={value} />