feat: remove cloudHosting conditional check, change version name (#28086)

This commit is contained in:
Dipyaman Biswas 2023-10-15 02:11:29 +05:30 committed by GitHub
parent 6ddcf72efb
commit 0b9857d44f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 17 deletions

View File

@ -8,15 +8,10 @@ export function createMessage(
}
/*
For self hosted, it displays the string "Appsmith Community v1.10.0" or "Appsmith Business v1.10.0".
For cloud hosting, it displays "Appsmith v1.10.0".
This is because Appsmith Cloud doesn't support business features yet.
For self hosted CE, it displays the string "Appsmith Community v1.10.0".
*/
export const APPSMITH_DISPLAY_VERSION = (
edition: string,
version: string,
cloudHosting: boolean,
) => `Appsmith ${!cloudHosting ? edition : ""} ${version}`;
export const APPSMITH_DISPLAY_VERSION = (edition: string, version: string) =>
`Appsmith ${edition} ${version}`;
export const INTERCOM_CONSENT_MESSAGE = () =>
`Can we have your email for better support?`;
export const YES = () => `Yes`;

View File

@ -38,7 +38,7 @@ export function* FetchAdminSettingsSaga() {
const isValidResponse: boolean = yield validateResponse(response);
if (isValidResponse) {
const { appVersion, cloudHosting } = getAppsmithConfigs();
const { appVersion } = getAppsmithConfigs();
const settings = {
//@ts-expect-error: response is of type unknown
...response.data,
@ -46,7 +46,6 @@ export function* FetchAdminSettingsSaga() {
APPSMITH_DISPLAY_VERSION,
appVersion.edition,
appVersion.id,
cloudHosting,
),
};

View File

@ -78,7 +78,7 @@ function HelpMenu(props: {
>
Help & Resources
</Text>
<div className="flex gap-2 flex-wrap mt-2">
<div className="flex flex-wrap gap-2 mt-2">
<Button
data-testid="editor-welcome-tour"
kind="secondary"
@ -126,7 +126,6 @@ function HelpMenu(props: {
APPSMITH_DISPLAY_VERSION,
appVersion.edition,
appVersion.id,
cloudHosting,
)}
</StyledText>
<StyledText color="var(--ads-v2-color-fg-muted)" kind={"action-s"}>

View File

@ -299,7 +299,6 @@ function HelpButton() {
APPSMITH_DISPLAY_VERSION,
appVersion.edition,
appVersion.id,
cloudHosting,
)}
</span>
<span>

View File

@ -62,7 +62,7 @@ function LeftPaneBottomSection() {
const dispatch = useDispatch();
const onboardingWorkspaces = useSelector(getOnboardingWorkspaces);
const isFetchingApplications = useSelector(getIsFetchingApplications);
const { appVersion, cloudHosting } = getAppsmithConfigs();
const { appVersion } = getAppsmithConfigs();
const howMuchTimeBefore = howMuchTimeBeforeText(appVersion.releaseDate);
const user = useSelector(getCurrentUser);
const tenantPermissions = useSelector(getTenantPermissions);
@ -141,7 +141,6 @@ function LeftPaneBottomSection() {
APPSMITH_DISPLAY_VERSION,
appVersion.edition,
appVersion.id,
cloudHosting,
)}
</span>
{howMuchTimeBefore !== "" && (

View File

@ -86,7 +86,7 @@ const LeftPaneVersionData = styled.div`
export default function MobileSideBar(props: MobileSideBarProps) {
const user = useSelector(getCurrentUser);
const tenantPermissions = useSelector(getTenantPermissions);
const { appVersion, cloudHosting } = getAppsmithConfigs();
const { appVersion } = getAppsmithConfigs();
const howMuchTimeBefore = howMuchTimeBeforeText(appVersion.releaseDate);
const isFeatureEnabled = useFeatureFlag(FEATURE_FLAG.license_gac_enabled);
@ -156,7 +156,6 @@ export default function MobileSideBar(props: MobileSideBarProps) {
APPSMITH_DISPLAY_VERSION,
appVersion.edition,
appVersion.id,
cloudHosting,
)}
</span>
{howMuchTimeBefore !== "" && (