Merge pull request #1591 from appsmithorg/fix/args

Fix for args not splitting correctly with empty values
This commit is contained in:
Nikhil Nandagopal 2020-11-05 17:52:35 +05:30 committed by GitHub
commit 08b755bdcb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -107,13 +107,21 @@ const JSToString = (js: string): string => {
const argsStringToArray = (funcArgs: string): string[] => { const argsStringToArray = (funcArgs: string): string[] => {
const argsplitMatches = [...funcArgs.matchAll(FUNC_ARGS_REGEX)]; const argsplitMatches = [...funcArgs.matchAll(FUNC_ARGS_REGEX)];
return argsplitMatches const arr: string[] = [];
.map(match => { let isPrevUndefined = true;
return match[0]; argsplitMatches.forEach(match => {
}) const matchVal = match[0];
.filter(arg => { if (!matchVal || matchVal === "") {
return arg !== ""; if (isPrevUndefined) {
}); arr.push(matchVal);
}
isPrevUndefined = true;
} else {
isPrevUndefined = false;
arr.push(matchVal);
}
});
return arr;
}; };
const textSetter = ( const textSetter = (