From 0682a92d8798b31faa5112dc374756dd7bda49c4 Mon Sep 17 00:00:00 2001 From: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Date: Fri, 26 Feb 2021 14:13:24 +0530 Subject: [PATCH] Update useEffect dependency (#3239) --- app/client/src/components/editorComponents/EditableText.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/src/components/editorComponents/EditableText.tsx b/app/client/src/components/editorComponents/EditableText.tsx index 89f3e52074..c4fff83702 100644 --- a/app/client/src/components/editorComponents/EditableText.tsx +++ b/app/client/src/components/editorComponents/EditableText.tsx @@ -106,11 +106,11 @@ export const EditableText = (props: EditableTextProps) => { useEffect(() => { setIsEditing(!!props.isEditingDefault); - }, [props.defaultValue, props.isEditingDefault, setValue]); + }, [props.defaultValue, props.isEditingDefault]); useEffect(() => { if (props.forceDefault === true) setValue(props.defaultValue); - }, [props.forceDefault, props.defaultValue, setValue]); + }, [props.forceDefault, props.defaultValue]); // at times onTextChange is not fired // for example when the modal is closed on clicking the overlay