Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Update useEffect dependency (#3239)

Browse Source
This commit is contained in:
akash-codemonk 2021-02-26 14:13:24 +05:30 committed by GitHub
parent dc146a1a16
commit 0682a92d87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/src/components/editorComponents/EditableText.tsx
View File

@ -106,11 +106,11 @@ export const EditableText = (props: EditableTextProps) => {
useEffect(() => {
setIsEditing(!!props.isEditingDefault);
}, [props.defaultValue, props.isEditingDefault, setValue]);
}, [props.defaultValue, props.isEditingDefault]);
useEffect(() => {
if (props.forceDefault === true) setValue(props.defaultValue);
}, [props.forceDefault, props.defaultValue, setValue]);
}, [props.forceDefault, props.defaultValue]);
// at times onTextChange is not fired
// for example when the modal is closed on clicking the overlay