Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix triggering of onChange when value is the same (#892)

Browse Source 
Fixes: #710
This commit is contained in:
Nicholas 2020-10-03 17:52:59 +08:00 committed by GitHub
parent 09106780aa
commit 052bd2a5e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/client/src/widgets/DropdownWidget.tsx
View File

@ -136,11 +136,15 @@ class DropdownWidget extends BaseWidget<DropdownWidgetProps, WidgetState> {
} }
onOptionSelected = (selectedOption: DropdownOption) => { onOptionSelected = (selectedOption: DropdownOption) => {
let isChanged = true;
if (this.props.selectionType === "SINGLE_SELECT") { if (this.props.selectionType === "SINGLE_SELECT") {
this.updateWidgetMetaProperty( isChanged = !(this.props.selectedOption.value == selectedOption.value);
"selectedOptionValue", if (isChanged) {
selectedOption.value, this.updateWidgetMetaProperty(
); "selectedOptionValue",
selectedOption.value,
);
}
} else if (this.props.selectionType === "MULTI_SELECT") { } else if (this.props.selectionType === "MULTI_SELECT") {
const isAlreadySelected = this.props.selectedOptionValueArr.includes( const isAlreadySelected = this.props.selectedOptionValueArr.includes(
selectedOption.value, selectedOption.value,
@ -156,7 +160,8 @@ class DropdownWidget extends BaseWidget<DropdownWidgetProps, WidgetState> {
} }
this.updateWidgetMetaProperty("selectedOptionValueArr", newSelectedValue); this.updateWidgetMetaProperty("selectedOptionValueArr", newSelectedValue);
} }
if (this.props.onOptionChange) {
if (this.props.onOptionChange && isChanged) {
super.executeAction({ super.executeAction({
dynamicString: this.props.onOptionChange, dynamicString: this.props.onOptionChange,
event: { event: {