From 016e30b42debfbcfcf353f1aecfa076049777b09 Mon Sep 17 00:00:00 2001 From: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Date: Mon, 16 Dec 2024 17:27:07 +0530 Subject: [PATCH] test: Skipping one test in API Edit Spec for functional bugs (#38115) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts --> there is a bug hence commenting this test cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js --> there is a bug hence commenting one test in this spec file /ok-to-test tags="@tag.Sanity" > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: b7237c480acc2c974d124101c986caa13672049a > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Mon, 16 Dec 2024 10:00:38 UTC ## Summary by CodeRabbit - **Bug Fixes** - Updated the locator for the "settings" element to enhance precision. - Skipped a test case related to loading state after cancellation due to an existing bug. - Skipped a test case for creating an API with app URL due to an existing bug. - **Tests** - Adjusted test case statuses to reflect current functionality and known issues. --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”> --- .../e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js | 3 ++- .../e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts | 3 ++- app/client/cypress/locators/apiWidgetslocator.json | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js b/app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js index d0f1a21dd8..56bab8c02f 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js +++ b/app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js @@ -48,7 +48,8 @@ describe( PageLeftPane.assertAbsence("SecondAPI"); }); - it("2. Should update loading state after cancellation of confirmation for run query", function () { + //Existing Bug: https://github.com/appsmithorg/appsmith/issues/38165 + it.skip("2. Should update loading state after cancellation of confirmation for run query", function () { cy.CreateAPI("FirstAPI"); cy.get(".CodeMirror-placeholder") .first() diff --git a/app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts b/app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts index 9b52a88bcf..c6155bfd41 100644 --- a/app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts +++ b/app/client/cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts @@ -16,7 +16,8 @@ describe( function () { let clientId, clientSecret; - it("1. Create an API with app url and save as Datasource for Authorization code details test", function () { + //Existing Bug: https://github.com/appsmithorg/appsmith/issues/37353 + it.skip("1. Create an API with app url and save as Datasource for Authorization code details test", function () { dataSources.CreateOAuthClient("authorization_code"); apiPage.CreateAndFillApi( dataManager.dsValues[dataManager.defaultEnviorment].OAuth_ApiUrl + diff --git a/app/client/cypress/locators/apiWidgetslocator.json b/app/client/cypress/locators/apiWidgetslocator.json index da51eeb258..e410f4a252 100644 --- a/app/client/cypress/locators/apiWidgetslocator.json +++ b/app/client/cypress/locators/apiWidgetslocator.json @@ -47,7 +47,7 @@ "page": ".single-select >div", "propertyList": ".binding", "actionlist": ".action div div", - "settings": "span:contains('Settings')", + "settings": "[data-testid='t--action-settings-trigger']", "headers": "span:contains('Headers')", "onPageLoad": "[name=executeOnLoad]", "renameEntity": "div[role='menuitem']:contains('Rename')",