Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: For a public app, do not export the default permission group (#16409)

Browse Source 
* For a public app, do not export the default permission group

* Adding test to assert that exported application JSON is not public.
This commit is contained in:
Trisha Anand 2022-08-31 10:44:32 +05:30 committed by GitHub
parent 4c9484935b
commit 0163c22003
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Application.java
View File

@ -192,6 +192,7 @@ public class Application extends BaseDomain {
this.setServerSchemaVersion(null);
this.setIsManualUpdate(false);
this.sanitiseToExportBaseObject();
this.setDefaultPermissionGroup(null);
}
public List<ApplicationPage> getPages() {

33
app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/ImportExportApplicationServiceTests.java
View File

@ -106,6 +106,7 @@ import static com.appsmith.server.acl.AclPermission.MANAGE_PAGES;
import static com.appsmith.server.acl.AclPermission.READ_ACTIONS;
import static com.appsmith.server.acl.AclPermission.READ_APPLICATIONS;
import static com.appsmith.server.acl.AclPermission.READ_PAGES;
import static com.appsmith.server.acl.AclPermission.READ_WORKSPACES;
import static com.appsmith.server.constants.FieldName.DEFAULT_PAGE_LAYOUT;
import static org.assertj.core.api.Assertions.assertThat;
@ -292,6 +293,38 @@ public class ImportExportApplicationServiceTests {
.verify();
}
@Test
@WithUserDetails(value = "api_user")
public void exportPublicApplicationTest() {
Application application = new Application();
application.setName("exportPublicApplicationTest-Test");
Application createdApplication = applicationPageService.createApplication(application, workspaceId).block();
Mono<Workspace> workspaceResponse = workspaceService.findById(workspaceId, READ_WORKSPACES);
ApplicationAccessDTO applicationAccessDTO = new ApplicationAccessDTO();
applicationAccessDTO.setPublicAccess(true);
// Make the application public
applicationService.changeViewAccess(createdApplication.getId(), applicationAccessDTO).block();
Mono<ApplicationJson> resultMono =
importExportApplicationService.exportApplicationById(createdApplication.getId(), "");
StepVerifier
.create(resultMono)
.assertNext(applicationJson -> {
Application exportedApplication = applicationJson.getExportedApplication();
assertThat(exportedApplication).isNotNull();
// Assert that the exported application is NOT public
assertThat(exportedApplication.getDefaultPermissionGroup()).isNull();
assertThat(exportedApplication.getPolicies()).isNullOrEmpty();
})
.verifyComplete();
}
@Test
@WithUserDetails(value = "api_user")
public void exportApplication_withInvalidApplicationId_throwNoResourceFoundException() {