From 0158791e91c7364dd186f34ab1c7b717925ac51a Mon Sep 17 00:00:00 2001
From: Satbir Singh <satbir121@gmail.com>
Date: Wed, 18 Mar 2020 15:05:58 +0000
Subject: [PATCH] Refactor page events.

---
 .../src/pages/Editor/PropertyPane/index.tsx   | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/app/client/src/pages/Editor/PropertyPane/index.tsx b/app/client/src/pages/Editor/PropertyPane/index.tsx
index 1e99170f38..fa414160e8 100644
--- a/app/client/src/pages/Editor/PropertyPane/index.tsx
+++ b/app/client/src/pages/Editor/PropertyPane/index.tsx
@@ -173,34 +173,34 @@ class PropertyPane extends Component<
     }
   };
 
-  shouldComponentUpdate(nextProps: PropertyPaneProps & PropertyPaneFunctions) {
+  componentDidUpdate(prevProps: PropertyPaneProps & PropertyPaneFunctions) {
     if (
-      nextProps.widgetId !== this.props.widgetId &&
-      nextProps.widgetId !== undefined
+      this.props.widgetId !== prevProps.widgetId &&
+      this.props.widgetId !== undefined
     ) {
-      if (this.props.widgetId && this.props.widgetProperties) {
+      if (prevProps.widgetId && prevProps.widgetProperties) {
         AnalyticsUtil.logEvent("PROPERTY_PANE_CLOSE", {
-          widgetType: this.props.widgetProperties.type,
-          widgetId: this.props.widgetId,
+          widgetType: prevProps.widgetProperties.type,
+          widgetId: prevProps.widgetId,
         });
       }
-      if (nextProps.widgetProperties) {
+      if (this.props.widgetProperties) {
         AnalyticsUtil.logEvent("PROPERTY_PANE_OPEN", {
-          widgetType: nextProps.widgetProperties.type,
-          widgetId: nextProps.widgetId,
+          widgetType: this.props.widgetProperties.type,
+          widgetId: this.props.widgetId,
         });
       }
     }
 
     if (
-      nextProps.widgetId === this.props.widgetId &&
-      nextProps.isVisible &&
-      !this.props.isVisible &&
-      nextProps.widgetProperties !== undefined
+      this.props.widgetId === prevProps.widgetId &&
+      this.props.isVisible &&
+      !prevProps.isVisible &&
+      this.props.widgetProperties !== undefined
     ) {
       AnalyticsUtil.logEvent("PROPERTY_PANE_OPEN", {
-        widgetType: nextProps.widgetProperties.type,
-        widgetId: nextProps.widgetId,
+        widgetType: this.props.widgetProperties.type,
+        widgetId: this.props.widgetId,
       });
     }