Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Refactor page events.

Browse Source
This commit is contained in:
Satbir Singh 2020-03-18 15:05:58 +00:00
parent b377502720
commit 0158791e91
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
app/client/src/pages/Editor/PropertyPane/index.tsx
View File

@ -173,34 +173,34 @@ class PropertyPane extends Component<
}
};
shouldComponentUpdate(nextProps: PropertyPaneProps & PropertyPaneFunctions) {
componentDidUpdate(prevProps: PropertyPaneProps & PropertyPaneFunctions) {
if (
nextProps.widgetId !== this.props.widgetId &&
nextProps.widgetId !== undefined
this.props.widgetId !== prevProps.widgetId &&
this.props.widgetId !== undefined
) {
if (this.props.widgetId && this.props.widgetProperties) {
if (prevProps.widgetId && prevProps.widgetProperties) {
AnalyticsUtil.logEvent("PROPERTY_PANE_CLOSE", {
widgetType: this.props.widgetProperties.type,
widgetId: this.props.widgetId,
widgetType: prevProps.widgetProperties.type,
widgetId: prevProps.widgetId,
});
}
if (nextProps.widgetProperties) {
if (this.props.widgetProperties) {
AnalyticsUtil.logEvent("PROPERTY_PANE_OPEN", {
widgetType: nextProps.widgetProperties.type,
widgetId: nextProps.widgetId,
widgetType: this.props.widgetProperties.type,
widgetId: this.props.widgetId,
});
}
}
if (
nextProps.widgetId === this.props.widgetId &&
nextProps.isVisible &&
!this.props.isVisible &&
nextProps.widgetProperties !== undefined
this.props.widgetId === prevProps.widgetId &&
this.props.isVisible &&
!prevProps.isVisible &&
this.props.widgetProperties !== undefined
) {
AnalyticsUtil.logEvent("PROPERTY_PANE_OPEN", {
widgetType: nextProps.widgetProperties.type,
widgetId: nextProps.widgetId,
widgetType: this.props.widgetProperties.type,
widgetId: this.props.widgetId,
});
}