Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: Remove unused regexMatchIgnoreCase (#34824)

Browse Source 
This method isn't used anywhere, EE included, and we don't want it to be
used either. There's specialized methods for things this was used in the
past, `searchIgnoreCase` and `inIgnoresCase`, and should be preferred
instead of this. If a new need comes up that needs regex, we'll come up
with a specialized query method again.

**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9858374518>
> Commit: 7b4eef3f04e81ec96c4f88b8c3e354dae95e92b3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9858374518&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 09 Jul 2024 14:13:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed deprecated `regexMatchIgnoreCase` method for cleaner and more
maintainable code.
- Updated `equal` method to improve flexibility by accepting `int`
values without the `@NonNull` annotation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Shrikant Sharat Kandula 2024-07-10 06:39:45 +05:30 committed by GitHub
parent 65bded9fdb
commit 013869fae3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/bridge/Bridge.java
View File

@ -79,11 +79,6 @@ public final class Bridge {
return Bridge.<T>query().equal(key, value);
}
@Deprecated
public static <T extends BaseDomain> BridgeQuery<T> regexMatchIgnoreCase(@NonNull String key, String regexPattern) {
return Bridge.<T>query().regexMatchIgnoreCase(key, regexPattern);
}
public static <T extends BaseDomain> BridgeQuery<T> searchIgnoreCase(@NonNull String key, @NonNull String needle) {
return Bridge.<T>query().searchIgnoreCase(key, needle);
}

7
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/bridge/BridgeQuery.java
View File

@ -22,7 +22,7 @@ public final class BridgeQuery<T extends BaseDomain> extends Criteria {
return this;
}
public BridgeQuery<T> equal(@NonNull String key, @NonNull int value) {
public BridgeQuery<T> equal(@NonNull String key, int value) {
checks.add(Criteria.where(key).is(value));
return this;
}
@ -58,11 +58,6 @@ public final class BridgeQuery<T extends BaseDomain> extends Criteria {
return this;
}
public BridgeQuery<T> regexMatchIgnoreCase(@NonNull String key, @NonNull String regexPattern) {
checks.add(Criteria.where(key).regex(regexPattern, "i"));
return this;
}
public BridgeQuery<T> searchIgnoreCase(@NonNull String key, @NonNull String needle) {
if (key.contains(".")) {
throw new UnsupportedOperationException("Search-ignore-case is not supported for nested fields");