From 00c16e81b394bc46b1087ee4741620986d04fde8 Mon Sep 17 00:00:00 2001 From: sneha122 Date: Wed, 16 Oct 2024 12:09:01 +0530 Subject: [PATCH] chore: unskip redis test (#36863) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description This PR enables back the RedisPluginTest Junit test case. It was disabled earlier as it was failing in build promotion. I have ran the test case multiple times on local and it did not fail at all, hence enabling it back. Will run it couple of times in CI too. Fixes #36774 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > ๐ŸŸข ๐ŸŸข ๐ŸŸข All cypress tests have passed! ๐ŸŽ‰ ๐ŸŽ‰ ๐ŸŽ‰ > Workflow run: > Commit: 91dce61c3acc83d6c801e2f0b09142d14f2e81e5 > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Tue, 15 Oct 2024 15:38:37 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **Bug Fixes** - Enabled the `RedisPluginTest` class for execution, allowing all test methods to run and validate the Redis plugin's behavior. - **Tests** - No changes to the logic or structure of existing tests; focus remains on validating datasource configurations and command execution. Co-authored-by: โ€œsneha122โ€ <โ€œsneha@appsmith.comโ€> --- .../src/test/java/com/external/plugins/RedisPluginTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java b/app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java index 962e008ae4..9cbfbef371 100644 --- a/app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java +++ b/app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java @@ -15,7 +15,6 @@ import com.fasterxml.jackson.databind.node.ArrayNode; import lombok.extern.slf4j.Slf4j; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.BeforeAll; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.testcontainers.containers.GenericContainer; import org.testcontainers.junit.jupiter.Container; @@ -40,7 +39,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue; @Slf4j @Testcontainers -@Disabled public class RedisPluginTest { @Container public static final GenericContainer redis =