ci: added client-unit-tests, server-unit-tests in package-master needs (#29844)
## Description > Added client-unit-tests, server-unit-tests in package-master step #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > running tbp on the branch #### How Has This Been Tested? - [ ] TBP run ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the build process to require both client and server unit tests to pass before packaging. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
53172d6d5b
commit
003dd7c2aa
|
|
@ -308,7 +308,7 @@ jobs:
|
|||
${{ vars.DOCKER_HUB_ORGANIZATION }}/appsmith-${{ vars.EDITION }}:release
|
||||
|
||||
package-master:
|
||||
needs: ci-test
|
||||
needs: [ci-test, client-unit-tests, server-unit-tests]
|
||||
runs-on: ubuntu-latest
|
||||
# Set permissions since we're using OIDC token authentication between Depot and GitHub
|
||||
permissions:
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user