From 0015466de1cb88fb2ee3b81b38f26a76352d6dd4 Mon Sep 17 00:00:00 2001 From: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Date: Fri, 23 Aug 2024 12:49:09 +0530 Subject: [PATCH] feat: Update height of QUERY_DYNAMIC_TEXT to 200px fixed (#35838) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description This PR updated QUERY_DYNAMIC_TEXT field height to 200px. Before it was configured to 100vh / 4 Fixes #34322 ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 4fd018dfabf0d813d9a56acecc9ec70bcd1fc109 > Cypress dashboard. > Tags: `@tag.All` > Spec: >
Fri, 23 Aug 2024 06:32:50 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the height of the Dynamic Text Field Control for improved stability in rendering. - Fixed the responsive behavior by setting a fixed height, ensuring consistent layout across various views. --- .../src/components/formControls/DynamicTextFieldControl.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/src/components/formControls/DynamicTextFieldControl.tsx b/app/client/src/components/formControls/DynamicTextFieldControl.tsx index f4bbbf696f..de390e699e 100644 --- a/app/client/src/components/formControls/DynamicTextFieldControl.tsx +++ b/app/client/src/components/formControls/DynamicTextFieldControl.tsx @@ -73,7 +73,7 @@ class DynamicTextControl extends BaseControl< disabled={this.props.disabled} evaluatedPopUpLabel={this?.props?.label} evaluationSubstitutionType={evaluationSubstitutionType} - height="calc(100vh / 4)" + height="200px" mode={mode} name={this.props.configProperty} placeholder={placeholderText}