PromucFlow_constructor/app/client/src/sagas/editorContextSagas.ts

79 lines
2.2 KiB
TypeScript
Raw Normal View History

import {
ReduxAction,
ReduxActionTypes,
} from "@appsmith/constants/ReduxActionConstants";
import {
setPanelPropertySectionState,
setPanelSelectedPropertyTabIndex,
setWidgetPropertySectionState,
setWidgetSelectedPropertyTabIndex,
} from "actions/editorContextActions";
import { all, put, takeLatest } from "redux-saga/effects";
import {
CodeEditorFocusState,
setCodeEditorCursorAction,
setFocusableInputField,
} from "actions/editorContextActions";
import { FocusEntity, identifyEntityFromPath } from "navigation/FocusEntity";
/**
* This method appends the PageId along with the focusable propertyPath
* @param action
*/
function* setEditorFieldFocus(action: ReduxAction<CodeEditorFocusState>) {
const { cursorPosition, key } = action.payload;
feat: URL Navigation for Widgets (#20202) ## Description Widget selection is driven by URL changes. This would fix browser navigation for users as they can use browser back/forward buttons to travel across older contexts on Appsmith. > Fixing browser URL navigation for widgets Fixes #19571 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan > Add Testsmith [test cases](https://github.com/appsmithorg/TestSmith/issues/2171) links that relate to this PR ### Issues raised during DP testing - [X] When a selected widget is below viewport and user refreshes the page, then the widget property pane is open but the page does not navigate to the selected widget https://loom.com/share/09f1eda2f02d474981a0d48e4a6419ec - [ ] Drop 2 widgets one at a time > Delete both the widgets > Now click on back button of the browser > Observe the url it shows the widget id in the URL but the canvas remains empty https://loom.com/share/53cae28a5d224e67b783c8ccf53745f5 Dev Response: This issue is valid but not a major inconvenience. We will try to track it and see if it needed to be addressed. Many other web tools do not handle such cases - [X] Canvas scrolls down when all widgets are selected. https://loom.com/share/c8a68dadcdb040779abd3a73bde2b06c - [X] Widget is not getting highlighted when added from the API editor page. Please refer to the attached video:-https://jiju8jbmwa.vmaker.com/record/IkwiAqFgafK9dVmu ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [x] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-02-21 13:38:16 +00:00
const entityInfo = identifyEntityFromPath(window.location.pathname);
const ignoredEntities = [FocusEntity.DATASOURCE, FocusEntity.PROPERTY_PANE];
if (key) {
if (!ignoredEntities.includes(entityInfo.entity)) {
yield put(setFocusableInputField(key));
}
yield put(setCodeEditorCursorAction(key, cursorPosition));
}
}
function* setPropertySectionStateSaga(
action: ReduxAction<{
key: string;
isOpen: boolean;
panelPropertyPath?: string;
}>,
) {
const { isOpen, key, panelPropertyPath } = action.payload;
if (panelPropertyPath) {
yield put(setPanelPropertySectionState(key, isOpen, panelPropertyPath));
} else {
yield put(setWidgetPropertySectionState(key, isOpen));
}
}
function* setSelectedPropertyTabIndexSaga(
action: ReduxAction<{ index: number; panelPropertyPath?: string }>,
) {
const { index, panelPropertyPath } = action.payload;
if (panelPropertyPath) {
yield put(setPanelSelectedPropertyTabIndex(index, panelPropertyPath));
} else {
yield put(setWidgetSelectedPropertyTabIndex(index));
}
}
export default function* editorContextSagas() {
yield all([
takeLatest(
ReduxActionTypes.SET_PROPERTY_SECTION_STATE,
setPropertySectionStateSaga,
),
takeLatest(
ReduxActionTypes.SET_SELECTED_PROPERTY_TAB_INDEX,
setSelectedPropertyTabIndexSaga,
),
takeLatest(ReduxActionTypes.SET_EDITOR_FIELD_FOCUS, setEditorFieldFocus),
]);
}