PromucFlow_constructor/app/client/src/widgets/NumberSliderWidget/validations.ts

269 lines
4.7 KiB
TypeScript
Raw Normal View History

feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
import { NumberSliderWidgetProps } from "./widget";
export function minValueValidation(
min: unknown,
props: NumberSliderWidgetProps,
_: any,
) {
if (_.isNil(min) || min === "") {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "ValidationError",
message: "This value is required",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
const minValue = Number(min);
const maxValue = props.max;
if (!Number.isFinite(minValue)) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "TypeError",
message: "This value must be a number",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
if (!_.isNil(maxValue) && minValue >= maxValue) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: "This value must be less than max value",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
return {
isValid: true,
parsed: minValue,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "",
message: "",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
export function maxValueValidation(
max: unknown,
props: NumberSliderWidgetProps,
_: any,
) {
if (_.isNil(max) || max === "") {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "ValidationError",
message: "This value is required",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
const maxValue = Number(max);
const minValue = props.min;
if (!Number.isFinite(maxValue)) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "TypeError",
message: "This value must be a number",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
if (!_.isNil(minValue) && maxValue <= minValue) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: "This value must be greater than min value",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
return {
isValid: true,
parsed: maxValue,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "",
message: "",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
export function defaultValueValidation(
value: unknown,
props: NumberSliderWidgetProps,
_: any,
) {
if (_.isNil(value) || value === "") {
return {
isValid: true,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "",
message: "",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
const maxValue = props.max;
const minValue = props.min;
const defaultValue = Number(value);
if (!Number.isFinite(defaultValue)) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "TypeError",
message: "This value must be a number",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
if (!_.isNil(minValue) && defaultValue < minValue) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: "This value must be greater than or equal to the min value",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
if (!_.isNil(maxValue) && defaultValue > maxValue) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: "This value must be less than or equal to the max value",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
return {
isValid: true,
parsed: defaultValue,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "",
message: "",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
export function stepSizeValidation(
step: unknown,
props: NumberSliderWidgetProps,
_: any,
) {
if (_.isNil(step) || step === "") {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "ValidationError",
message: "This value is required",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
const stepValue = Number(step);
if (!Number.isFinite(stepValue)) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "TypeError",
message: "This value must be a number",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
if (stepValue < 0.1) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: "This value must be greater than 0.1",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
const minValue = props.min;
const maxValue = props.max;
const sliderRange = maxValue - minValue;
if (stepValue > sliderRange) {
return {
isValid: false,
parsed: undefined,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "RangeError",
message: `This value must be less than ${sliderRange}`,
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}
return {
isValid: true,
parsed: stepValue,
feat: Error handling phase 1 (#20629) ## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
2023-02-18 12:55:46 +00:00
messages: [
{
name: "",
message: "",
},
],
feat: implemented slider widgets (#15712) * feat: implemented slider widget from mantine ui * fix: remove widget from widgetName * fix: memoize marks, use primitives for rangeslider value * fix: use theme accentColor, remove xs and xl size * fix: renamed slider widget, added searchTags, parity properties * feat: added labels to the slider widgets. * fix: Rename SingleSlider components to Slider * feat: added basic disabled state * feat: added category slider widget, handled label callback function * fix: Renamed slider widgets fixed imports and bindings. * feat: widget redesign, added hover, focus, disabled states. * feat: added isDirty meta property to the slider widgets. * feat: Added onChange action triggers to the slider widgets. * feat: added show marks label property for category widget. * fix: fixed initial feedback on designs, issues. * feat: added the new tabbed property pane improvements. * feat: changes to the slider property panes. * fix: removed show label on hover and add tooltip always on property. * fix: slider sizes changed inline with the designs * feat: added initial logos. * fix: slider size subtext. * feat: added show marks to number and range sliders. * fix: Label will show one decimal point if step Size is in decimal. * feat: added validations for the slider widgets. * fix: remove mark dots when show marks is off, change icons. * fix: addressed validations feedback. * fix: added stepsize validation number widget & fixed top label aligning. * fix: Long label styles. * fix: wrapping removed for long labels, handled focus state. * fix: remove overflow hidden. * fix: added pointerEvents none to Marks. * fix: added default value in the Number Slider widget. * fix: refactor marks remove un-necessary function calls. * fix: Review changes done. * fix: remove transformstyles outside component. * fix: remove old proprty pane config. * fix: remove any type from widget files. * fix: small code refactor validations category slider. * fix: removed throttle, fixed slider setting to zero issue. * fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue. * fix: number and category slider fire events only if value has changed. * fix: added 0 as default for the min value, range and number sliders. * fix: remove tooltip always on from category slider. * fix: minRange validation accept only numbers. * fix: added old property pane method.
2022-09-22 15:56:50 +00:00
};
}