2023-07-12 06:42:16 +00:00
|
|
|
// Please follow naming convention : https://www.notion.so/appsmith/Using-Feature-Flags-in-Appsmith-d362fe7acc7d4ef0aa12e1f5f9b83b5f?pvs=4#f6d4242e56284e84af25cadef71b7aeb to create feature flags.
|
2023-06-27 10:45:33 +00:00
|
|
|
export const FEATURE_FLAG = {
|
|
|
|
|
TEST_FLAG: "TEST_FLAG",
|
2023-07-05 06:58:18 +00:00
|
|
|
release_datasource_environments_enabled:
|
|
|
|
|
"release_datasource_environments_enabled",
|
2023-07-21 08:43:36 +00:00
|
|
|
release_appnavigationlogoupload_enabled:
|
|
|
|
|
"release_appnavigationlogoupload_enabled",
|
2023-07-12 13:49:49 +00:00
|
|
|
release_embed_hide_share_settings_enabled:
|
|
|
|
|
"release_embed_hide_share_settings_enabled",
|
2023-10-12 08:24:03 +00:00
|
|
|
release_table_serverside_filtering_enabled:
|
|
|
|
|
"release_table_serverside_filtering_enabled",
|
2023-08-16 10:21:04 +00:00
|
|
|
license_branding_enabled: "license_branding_enabled",
|
2023-08-21 13:42:22 +00:00
|
|
|
license_sso_saml_enabled: "license_sso_saml_enabled",
|
|
|
|
|
license_sso_oidc_enabled: "license_sso_oidc_enabled",
|
2023-10-04 10:10:38 +00:00
|
|
|
license_private_embeds_enabled: "license_private_embeds_enabled",
|
2023-09-25 06:27:23 +00:00
|
|
|
release_show_publish_app_to_community_enabled:
|
|
|
|
|
"release_show_publish_app_to_community_enabled",
|
2023-09-29 20:42:56 +00:00
|
|
|
license_gac_enabled: "license_gac_enabled",
|
2023-10-19 15:20:17 +00:00
|
|
|
release_anvil_enabled: "release_anvil_enabled",
|
2023-11-07 14:55:02 +00:00
|
|
|
license_git_branch_protection_enabled:
|
|
|
|
|
"license_git_branch_protection_enabled",
|
2024-01-24 07:55:58 +00:00
|
|
|
license_git_continuous_delivery_enabled:
|
|
|
|
|
"license_git_continuous_delivery_enabled",
|
2023-11-03 10:48:13 +00:00
|
|
|
license_widget_rtl_support_enabled: "license_widget_rtl_support_enabled",
|
2023-11-27 09:30:20 +00:00
|
|
|
ab_one_click_learning_popover_enabled:
|
|
|
|
|
"ab_one_click_learning_popover_enabled",
|
2023-12-27 12:11:54 +00:00
|
|
|
release_side_by_side_ide_enabled: "release_side_by_side_ide_enabled",
|
2024-01-02 05:04:48 +00:00
|
|
|
release_global_add_pane_enabled: "release_global_add_pane_enabled",
|
2024-01-16 14:49:08 +00:00
|
|
|
ab_appsmith_ai_query: "ab_appsmith_ai_query",
|
2024-02-06 06:56:33 +00:00
|
|
|
release_actions_redesign_enabled: "release_actions_redesign_enabled",
|
2024-02-13 11:14:59 +00:00
|
|
|
rollout_remove_feature_walkthrough_enabled:
|
|
|
|
|
"rollout_remove_feature_walkthrough_enabled",
|
2024-03-08 09:05:02 +00:00
|
|
|
release_drag_drop_building_blocks_enabled:
|
|
|
|
|
"release_drag_drop_building_blocks_enabled",
|
feat: display label in table select cell (#35124)
## Description
**Issue**
In the table widget, the select column currently displays the value from
the dropdown when a user makes a selection, rather than the label. This
behaviour is inconsistent with the standalone select widget, which
correctly renders the label upon selection.
**Fix**
This PR addresses the inconsistency by modifying the table widget's
select column to display the label of the selected item, while
maintaining the table cell value and ensuring alignment with the
behaviour of the standalone select widget.
**Tested Cases**
Manual Test Cases for Table Select Widget Improvement
1. Default Value Display
**Objective:** Ensure that a new table displays the correct default
label key from the selectOptions in the cell.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Verify that the table cell displays the value from the label key of
the `selectOptions` by default.
2. Binding Check for Selected Row
**Objective:** Ensure that the table binding for the selected row
reflects the correct value key from the selectOptions.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Select a row and verify that `Table1.selectedRow.gender` matches the
value key from the `selectOptions`.
3. Updating Table Cell Content
**Objective:** Verify that updating the table cell content via the
dropdown updates the cell with the correct label key property.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Change the content of the table cell using the dropdown.
- Confirm that the cell content updates accordingly with the value key
property.
4. Add New Row Functionality
**Objective:** Ensure that adding a new row works as expected with the
enhanced functionality.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Add a new row to the table.
- Verify that the new row uses the label key property from the
`selectOptions` in the table display.
5. Deployed Mode Verification
**Objective:** Verify that the display functionality works correctly in
deployed mode.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Change the displayAs property to both value and label.
- Deploy the table.
- Verify that the table displays correctly in both value and label modes
in the deployed environment.
Fixes #26188
## Automation
/ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10080592979>
> Commit: 78b268d2b566aa07ef23fec567ce05e8c5a6add4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table, @tag.Binding, @tag.Sanity`
> Spec:
> <hr>Wed, 24 Jul 2024 17:17:06 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Improved display of selected options in table widgets by showing the
corresponding label instead of the raw value.
- Introduced a feature flag to toggle the table cell label value
functionality.
- **Bug Fixes**
- Enhanced test cases to ensure accurate validation of select options
behavior within the table widget.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-25 11:39:24 +00:00
|
|
|
release_table_cell_label_value_enabled:
|
|
|
|
|
"release_table_cell_label_value_enabled",
|
2024-03-13 07:42:08 +00:00
|
|
|
rollout_side_by_side_enabled: "rollout_side_by_side_enabled",
|
2024-04-11 11:51:14 +00:00
|
|
|
release_layout_conversion_enabled: "release_layout_conversion_enabled",
|
2024-07-05 08:27:59 +00:00
|
|
|
release_anvil_toggle_enabled: "release_anvil_toggle_enabled",
|
2024-10-14 11:04:16 +00:00
|
|
|
release_git_persist_branch_enabled: "release_git_persist_branch_enabled",
|
2024-09-09 10:55:50 +00:00
|
|
|
release_ide_animations_enabled: "release_ide_animations_enabled",
|
2023-06-27 10:45:33 +00:00
|
|
|
} as const;
|
|
|
|
|
|
|
|
|
|
export type FeatureFlag = keyof typeof FEATURE_FLAG;
|
|
|
|
|
|
|
|
|
|
export type FeatureFlags = Record<FeatureFlag, boolean>;
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
|
|
|
|
|
TEST_FLAG: true,
|
2023-07-05 06:58:18 +00:00
|
|
|
release_datasource_environments_enabled: false,
|
2023-07-21 08:43:36 +00:00
|
|
|
release_appnavigationlogoupload_enabled: false,
|
2023-07-12 13:49:49 +00:00
|
|
|
release_embed_hide_share_settings_enabled: false,
|
2023-10-12 08:24:03 +00:00
|
|
|
release_table_serverside_filtering_enabled: false,
|
2023-08-16 10:21:04 +00:00
|
|
|
license_branding_enabled: false,
|
2023-08-21 13:42:22 +00:00
|
|
|
license_sso_saml_enabled: false,
|
|
|
|
|
license_sso_oidc_enabled: false,
|
2023-10-04 10:10:38 +00:00
|
|
|
license_private_embeds_enabled: false,
|
2023-09-25 06:27:23 +00:00
|
|
|
release_show_publish_app_to_community_enabled: false,
|
2023-09-29 20:42:56 +00:00
|
|
|
license_gac_enabled: false,
|
2023-10-19 15:20:17 +00:00
|
|
|
release_anvil_enabled: false,
|
2024-03-08 09:05:02 +00:00
|
|
|
release_drag_drop_building_blocks_enabled: false,
|
feat: display label in table select cell (#35124)
## Description
**Issue**
In the table widget, the select column currently displays the value from
the dropdown when a user makes a selection, rather than the label. This
behaviour is inconsistent with the standalone select widget, which
correctly renders the label upon selection.
**Fix**
This PR addresses the inconsistency by modifying the table widget's
select column to display the label of the selected item, while
maintaining the table cell value and ensuring alignment with the
behaviour of the standalone select widget.
**Tested Cases**
Manual Test Cases for Table Select Widget Improvement
1. Default Value Display
**Objective:** Ensure that a new table displays the correct default
label key from the selectOptions in the cell.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Verify that the table cell displays the value from the label key of
the `selectOptions` by default.
2. Binding Check for Selected Row
**Objective:** Ensure that the table binding for the selected row
reflects the correct value key from the selectOptions.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Select a row and verify that `Table1.selectedRow.gender` matches the
value key from the `selectOptions`.
3. Updating Table Cell Content
**Objective:** Verify that updating the table cell content via the
dropdown updates the cell with the correct label key property.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Change the content of the table cell using the dropdown.
- Confirm that the cell content updates accordingly with the value key
property.
4. Add New Row Functionality
**Objective:** Ensure that adding a new row works as expected with the
enhanced functionality.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Add a new row to the table.
- Verify that the new row uses the label key property from the
`selectOptions` in the table display.
5. Deployed Mode Verification
**Objective:** Verify that the display functionality works correctly in
deployed mode.
**Steps:**
- Drop a new table widget.
- Add sample data to the table.
- Set a column (e.g., gender) to select type.
- Change the displayAs property to both value and label.
- Deploy the table.
- Verify that the table displays correctly in both value and label modes
in the deployed environment.
Fixes #26188
## Automation
/ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10080592979>
> Commit: 78b268d2b566aa07ef23fec567ce05e8c5a6add4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table, @tag.Binding, @tag.Sanity`
> Spec:
> <hr>Wed, 24 Jul 2024 17:17:06 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Improved display of selected options in table widgets by showing the
corresponding label instead of the raw value.
- Introduced a feature flag to toggle the table cell label value
functionality.
- **Bug Fixes**
- Enhanced test cases to ensure accurate validation of select options
behavior within the table widget.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-25 11:39:24 +00:00
|
|
|
release_table_cell_label_value_enabled: false,
|
2023-11-07 14:55:02 +00:00
|
|
|
license_git_branch_protection_enabled: false,
|
2024-01-24 07:55:58 +00:00
|
|
|
license_git_continuous_delivery_enabled: false,
|
2023-11-03 10:48:13 +00:00
|
|
|
license_widget_rtl_support_enabled: false,
|
2023-11-27 09:30:20 +00:00
|
|
|
ab_one_click_learning_popover_enabled: false,
|
2023-12-27 12:11:54 +00:00
|
|
|
release_side_by_side_ide_enabled: false,
|
2024-01-02 05:04:48 +00:00
|
|
|
release_global_add_pane_enabled: false,
|
2024-01-16 14:49:08 +00:00
|
|
|
ab_appsmith_ai_query: false,
|
2024-02-06 06:56:33 +00:00
|
|
|
release_actions_redesign_enabled: false,
|
2024-05-13 10:18:11 +00:00
|
|
|
rollout_remove_feature_walkthrough_enabled: true,
|
2024-03-13 07:42:08 +00:00
|
|
|
rollout_side_by_side_enabled: false,
|
2024-04-11 11:51:14 +00:00
|
|
|
release_layout_conversion_enabled: false,
|
2024-07-05 08:27:59 +00:00
|
|
|
release_anvil_toggle_enabled: false,
|
2024-10-14 11:04:16 +00:00
|
|
|
release_git_persist_branch_enabled: false,
|
2024-09-09 10:55:50 +00:00
|
|
|
release_ide_animations_enabled: false,
|
2023-07-12 06:42:16 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const AB_TESTING_EVENT_KEYS = {
|
|
|
|
|
abTestingFlagLabel: "abTestingFlagLabel",
|
|
|
|
|
abTestingFlagValue: "abTestingFlagValue",
|
2023-06-27 10:45:33 +00:00
|
|
|
};
|