chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type {
|
2022-07-14 07:02:35 +00:00
|
|
|
ColumnProperties,
|
|
|
|
|
CompactMode,
|
|
|
|
|
ReactTableFilter,
|
|
|
|
|
TableStyles,
|
|
|
|
|
SortOrderTypes,
|
|
|
|
|
} from "./component/Constants";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { WidgetProps } from "widgets/BaseWidget";
|
|
|
|
|
import type { WithMeta } from "widgets/MetaHOC";
|
|
|
|
|
import type { EventType } from "constants/AppsmithActionConstants/ActionConstants";
|
2022-07-14 07:02:35 +00:00
|
|
|
import { IconNames } from "@blueprintjs/icons";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ColumnAction } from "components/propertyControls/ColumnActionSelectorControl";
|
|
|
|
|
import type { Alignment } from "@blueprintjs/core";
|
|
|
|
|
import type { IconName } from "@blueprintjs/icons";
|
|
|
|
|
import type { ButtonVariant } from "components/constants";
|
2024-08-06 14:52:22 +00:00
|
|
|
import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
|
2022-07-14 07:02:35 +00:00
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface EditableCell {
|
2022-07-14 07:02:35 +00:00
|
|
|
column: string;
|
|
|
|
|
index: number;
|
2022-09-13 05:41:59 +00:00
|
|
|
value: string | number | null;
|
2022-07-14 07:02:35 +00:00
|
|
|
initialValue: string;
|
2022-09-13 05:41:59 +00:00
|
|
|
inputValue: string;
|
fix: Fixes currentRow calculation logic in table(property pane) (#35390)
## Description
<ins>Problem</ins>
`currentRow` variable which is availabe in property pane of col settings
- is not getting correct value during runtime if the table is sorted or
filtered.
<ins>Root cause</ins>
* We are considering `processedTableData` to get the `currentRow`.
* This property is not updated during filtering and sorting, another
property `filteredTableData` is updated instead.
* We CANNOT use `filteredTableData` as it depends on `primaryColumns`
property which we intend to update as well - this is leading to cyclic
dependency during evaluations.
<ins>Solution</ins>
Since the problem is related to edit cases and given the constraints
around using `filteredTableData` directly, we fixed the problem by
adding a new property to `editableCellValue` object called
`__originalIndex__`.
* This property stores the index of the row being edited in
`processedTableData`
* On top of this change, the PR adds a migration for updating the
current row binding in TableWidgetV2, ensuring accurate current row
calculation and improving the functionality of the widget.
* We also added unit test for migration changes.
* Additionally, This pull request refactors the DSLs for TableWidgetV2
migration test cases to update the DSLs to separate folder, drastically
reducing the file size to its core logic, improving the readability of
the code.
* We also updated relevant test cases to account for this change.
[Testing
plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487)
[Counter part EE
pr](https://github.com/appsmithorg/appsmith-ee/pull/4879)
Fixes #34346
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.All"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10451549845>
> Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 19 Aug 2024 11:15:04 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [x] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **New Features**
- Updated DSL migration process to support version 90, enhancing
compatibility and robustness.
- Introduced new migration logic for table widget data bindings,
improving inline editing capabilities.
- Enhanced validation logic for editable cells in table widgets,
allowing for more dynamic data handling.
- Added a method to discard edits in specific table cells, improving
user interaction.
- Introduced a new message constant for required fields, enhancing user
feedback.
- **Bug Fixes**
- Improved validation checks for table cells based on updated indices
and values.
- **Tests**
- Added comprehensive tests to validate migration functions related to
Table Widget, ensuring all aspects function correctly post-update.
- Enhanced test specifications for improved validation logic and
coverage in table widget functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: sneha122 <sneha@appsmith.com>
2024-08-20 08:01:45 +00:00
|
|
|
[ORIGINAL_INDEX_KEY]: number;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2022-07-14 07:02:35 +00:00
|
|
|
|
2023-04-13 10:08:46 +00:00
|
|
|
export enum PaginationDirection {
|
|
|
|
|
INITIAL = "INITIAL",
|
|
|
|
|
PREVIOUS_PAGE = "PREVIOUS_PAGE",
|
|
|
|
|
NEXT_PAGE = "NEXT_PAGE",
|
|
|
|
|
}
|
|
|
|
|
|
2022-07-14 07:02:35 +00:00
|
|
|
export enum EditableCellActions {
|
|
|
|
|
SAVE = "SAVE",
|
|
|
|
|
DISCARD = "DISCARD",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export enum InlineEditingSaveOptions {
|
|
|
|
|
ROW_LEVEL = "ROW_LEVEL",
|
|
|
|
|
TABLE_LEVEL = "TABLE_LEVEL",
|
|
|
|
|
CUSTOM = "CUSTOM",
|
|
|
|
|
}
|
|
|
|
|
|
2022-11-05 09:54:20 +00:00
|
|
|
interface AddNewRowProps {
|
|
|
|
|
isAddRowInProgress: boolean;
|
|
|
|
|
allowAddNewRow: boolean;
|
|
|
|
|
onAddNewRowSave: string;
|
|
|
|
|
onAddNewRowDiscard: string;
|
|
|
|
|
defaultNewRow: Record<string, unknown>;
|
|
|
|
|
}
|
|
|
|
|
export interface TableWidgetProps
|
|
|
|
|
extends WidgetProps,
|
|
|
|
|
WithMeta,
|
|
|
|
|
TableStyles,
|
|
|
|
|
AddNewRowProps {
|
2023-06-01 17:26:05 +00:00
|
|
|
pristine: boolean;
|
2022-07-14 07:02:35 +00:00
|
|
|
nextPageKey?: string;
|
|
|
|
|
prevPageKey?: string;
|
|
|
|
|
label: string;
|
|
|
|
|
searchText: string;
|
|
|
|
|
defaultSearchText: string;
|
|
|
|
|
defaultSelectedRowIndex?: number | string;
|
|
|
|
|
defaultSelectedRowIndices?: number[] | string;
|
|
|
|
|
tableData: Array<Record<string, unknown>>;
|
|
|
|
|
onPageChange?: string;
|
|
|
|
|
pageSize: number;
|
|
|
|
|
onRowSelected?: string;
|
|
|
|
|
onSearchTextChanged: string;
|
|
|
|
|
onSort: string;
|
|
|
|
|
selectedRowIndex?: number;
|
|
|
|
|
selectedRowIndices: number[];
|
|
|
|
|
serverSidePaginationEnabled?: boolean;
|
|
|
|
|
multiRowSelection?: boolean;
|
|
|
|
|
enableClientSideSearch?: boolean;
|
|
|
|
|
hiddenColumns?: string[];
|
|
|
|
|
columnOrder?: string[];
|
2023-02-15 11:42:46 +00:00
|
|
|
frozenColumnIndices: Record<string, number>;
|
|
|
|
|
canFreezeColumn?: boolean;
|
2022-07-14 07:02:35 +00:00
|
|
|
columnNameMap?: { [key: string]: string };
|
|
|
|
|
columnTypeMap?: {
|
|
|
|
|
[key: string]: { type: string; format: string; inputFormat?: string };
|
|
|
|
|
};
|
|
|
|
|
columnWidthMap?: { [key: string]: number };
|
|
|
|
|
filters?: ReactTableFilter[];
|
|
|
|
|
compactMode?: CompactMode;
|
|
|
|
|
isSortable?: boolean;
|
|
|
|
|
primaryColumnId?: string;
|
|
|
|
|
primaryColumns: Record<string, ColumnProperties>;
|
|
|
|
|
derivedColumns: Record<string, ColumnProperties>;
|
|
|
|
|
sortOrder: {
|
|
|
|
|
column: string;
|
|
|
|
|
order: SortOrderTypes | null;
|
|
|
|
|
};
|
|
|
|
|
totalRecordsCount?: number;
|
|
|
|
|
transientTableData: {
|
|
|
|
|
[key: string]: Record<string, string>;
|
|
|
|
|
};
|
2022-09-15 07:47:15 +00:00
|
|
|
editableCell?: EditableCell;
|
2022-07-14 07:02:35 +00:00
|
|
|
primaryColor: string;
|
|
|
|
|
borderRadius: string;
|
|
|
|
|
boxShadow?: string;
|
|
|
|
|
inlineEditingSaveOption?: InlineEditingSaveOptions;
|
|
|
|
|
showInlineEditingOptionDropdown?: boolean;
|
2022-10-14 04:53:31 +00:00
|
|
|
variant?: TableVariant;
|
2022-11-05 09:54:20 +00:00
|
|
|
isEditableCellsValid: Record<string, boolean>;
|
2022-09-30 04:03:53 +00:00
|
|
|
selectColumnFilterText?: Record<string, string>;
|
2022-11-05 09:54:20 +00:00
|
|
|
isAddRowInProgress: boolean;
|
|
|
|
|
newRow: Record<string, unknown>;
|
|
|
|
|
firstEditableColumnIdByOrder: string;
|
2023-08-22 11:27:02 +00:00
|
|
|
enableServerSideFiltering: boolean;
|
|
|
|
|
onTableFilterUpdate: string;
|
feat: Update TableWidgetV2 to include customIsLoading property (#36857)
## Description
<ins>Problem</ins>
There are many problems with table loader logic, for which many users
try to implement a modal for loader. These problems stem from dependency
and delay on eval, discussed comprehensively in #12308
<ins>Solution</ins>
This PR updates the TableWidgetV2 component to include a new property
called `customIsLoading`. This property controls the loading state of
the widget and is added to the TableWidgetProps interface. Additionally,
the component's state is updated to include the `customIsLoading`
property.
The `contentConfig` file for the TableWidgetV2 is also modified to
include the `customIsLoading` property with its corresponding label,
control type, help text, and validation.
These changes improve the flexibility and customization options of the
TableWidgetV2 component.
Fixes #12308
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.Table"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11456273525>
> Commit: 1c6f4f9caabc3aa45ec3916e5ccb465d946ab0a1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11456273525&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Tue, 22 Oct 2024 09:17:37 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced a new feature flag for custom loading states in the table
widget.
- Added properties for managing custom loading behavior in the
`TableWidgetV2`.
- **Bug Fixes**
- Enhanced loading state management to ensure accurate representation
based on new properties.
- **Tests**
- Added unit tests for loading behavior in the `TableWidgetV2`
component, covering default and custom loading scenarios.
- **Documentation**
- Updated help text for properties related to loading states to improve
clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-22 09:21:45 +00:00
|
|
|
customIsLoading: boolean;
|
|
|
|
|
customIsLoadingValue: boolean;
|
2025-02-14 09:39:24 +00:00
|
|
|
infiniteScrollEnabled: boolean;
|
2022-07-14 07:02:35 +00:00
|
|
|
}
|
|
|
|
|
|
2022-10-14 04:53:31 +00:00
|
|
|
export enum TableVariantTypes {
|
|
|
|
|
DEFAULT = "DEFAULT",
|
|
|
|
|
VARIANT2 = "VARIANT2",
|
|
|
|
|
VARIANT3 = "VARIANT3",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export type TableVariant = keyof typeof TableVariantTypes;
|
|
|
|
|
|
2022-07-14 07:02:35 +00:00
|
|
|
export const ORIGINAL_INDEX_KEY = "__originalIndex__";
|
|
|
|
|
|
|
|
|
|
export const PRIMARY_COLUMN_KEY_VALUE = "__primaryKey__";
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_COLUMN_WIDTH = 150;
|
|
|
|
|
|
|
|
|
|
export const COLUMN_MIN_WIDTH = 60;
|
|
|
|
|
|
2023-02-15 11:42:46 +00:00
|
|
|
export const TABLE_COLUMN_ORDER_KEY = "tableWidgetColumnOrder";
|
|
|
|
|
|
2022-07-14 07:02:35 +00:00
|
|
|
export enum ColumnTypes {
|
|
|
|
|
TEXT = "text",
|
|
|
|
|
URL = "url",
|
|
|
|
|
NUMBER = "number",
|
|
|
|
|
IMAGE = "image",
|
|
|
|
|
VIDEO = "video",
|
|
|
|
|
DATE = "date",
|
|
|
|
|
BUTTON = "button",
|
|
|
|
|
ICON_BUTTON = "iconButton",
|
|
|
|
|
MENU_BUTTON = "menuButton",
|
|
|
|
|
SELECT = "select",
|
|
|
|
|
EDIT_ACTIONS = "editActions",
|
2022-09-08 11:05:59 +00:00
|
|
|
CHECKBOX = "checkbox",
|
2022-09-16 04:34:11 +00:00
|
|
|
SWITCH = "switch",
|
2023-11-06 05:35:26 +00:00
|
|
|
CURRENCY = "currency",
|
2024-12-11 07:37:30 +00:00
|
|
|
HTML = "html",
|
2022-07-14 07:02:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export enum ReadOnlyColumnTypes {
|
|
|
|
|
TEXT = "text",
|
|
|
|
|
URL = "url",
|
|
|
|
|
NUMBER = "number",
|
|
|
|
|
IMAGE = "image",
|
|
|
|
|
VIDEO = "video",
|
|
|
|
|
DATE = "date",
|
2022-09-08 11:05:59 +00:00
|
|
|
CHECKBOX = "checkbox",
|
2022-09-16 04:34:11 +00:00
|
|
|
SWITCH = "switch",
|
2022-09-30 04:03:53 +00:00
|
|
|
SELECT = "select",
|
2024-12-11 07:37:30 +00:00
|
|
|
HTML = "html",
|
2022-07-14 07:02:35 +00:00
|
|
|
}
|
|
|
|
|
|
2022-11-05 09:54:20 +00:00
|
|
|
export const ActionColumnTypes = [
|
|
|
|
|
ColumnTypes.BUTTON,
|
|
|
|
|
ColumnTypes.ICON_BUTTON,
|
|
|
|
|
ColumnTypes.MENU_BUTTON,
|
|
|
|
|
ColumnTypes.EDIT_ACTIONS,
|
2024-12-11 07:37:30 +00:00
|
|
|
ColumnTypes.HTML,
|
2022-11-05 09:54:20 +00:00
|
|
|
];
|
|
|
|
|
|
2022-12-01 05:24:48 +00:00
|
|
|
export const FilterableColumnTypes = [
|
|
|
|
|
ColumnTypes.TEXT,
|
|
|
|
|
ColumnTypes.URL,
|
|
|
|
|
ColumnTypes.NUMBER,
|
|
|
|
|
ColumnTypes.DATE,
|
|
|
|
|
ColumnTypes.SELECT,
|
|
|
|
|
ColumnTypes.CHECKBOX,
|
|
|
|
|
ColumnTypes.SWITCH,
|
2024-12-11 07:37:30 +00:00
|
|
|
ColumnTypes.HTML,
|
2022-12-01 05:24:48 +00:00
|
|
|
];
|
|
|
|
|
|
2022-07-14 07:02:35 +00:00
|
|
|
export const DEFAULT_BUTTON_COLOR = "rgb(3, 179, 101)";
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_BUTTON_LABEL = "Action";
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_MENU_VARIANT = "PRIMARY";
|
|
|
|
|
|
|
|
|
|
export const DEFAULT_MENU_BUTTON_LABEL = "Open menu";
|
|
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface TransientDataPayload {
|
2022-09-08 11:05:59 +00:00
|
|
|
[key: string]: string | number | boolean;
|
2022-11-05 09:54:20 +00:00
|
|
|
__originalIndex__: number;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2022-07-14 07:02:35 +00:00
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface OnColumnEventArgs {
|
2022-07-14 07:02:35 +00:00
|
|
|
rowIndex: number;
|
|
|
|
|
action: string;
|
|
|
|
|
onComplete?: () => void;
|
|
|
|
|
triggerPropertyName: string;
|
|
|
|
|
eventType: EventType;
|
|
|
|
|
row?: Record<string, unknown>;
|
2022-09-30 04:03:53 +00:00
|
|
|
additionalData?: Record<string, unknown>;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2022-07-14 07:02:35 +00:00
|
|
|
|
|
|
|
|
export const ICON_NAMES = Object.keys(IconNames).map(
|
|
|
|
|
(name: string) => IconNames[name as keyof typeof IconNames],
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
export type ButtonColumnActions = ColumnAction & {
|
|
|
|
|
eventType: EventType;
|
|
|
|
|
iconName?: IconName;
|
|
|
|
|
variant: ButtonVariant;
|
|
|
|
|
backgroundColor?: string;
|
|
|
|
|
iconAlign?: Alignment;
|
|
|
|
|
borderRadius?: string;
|
|
|
|
|
isVisible?: boolean;
|
|
|
|
|
isDisabled?: boolean;
|
|
|
|
|
boxShadow?: string;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export enum DateInputFormat {
|
|
|
|
|
EPOCH = "Epoch",
|
|
|
|
|
MILLISECONDS = "Milliseconds",
|
|
|
|
|
}
|
2022-09-13 05:41:59 +00:00
|
|
|
|
fix: Invalid Date Display in Table Widget's Date Column When Using Unix Timestamp (ms) (#36455)
## Description
**Problem**
When populating a table widget with data that includes dates in Unix
timestamp (milliseconds) format, setting the column type to "Date," the
input format to "Unix timestamp (ms)," and selecting a display format
leads to an issue during inline editing. While the date picker behaves
correctly, selecting a new date results in the table cell showing an
"Invalid Date" error.
**Root Cause**
The platform currently uses DateInputFormat.MILLISECONDS for Unix
timestamp (ms) formatting. However, this value is not a valid option for
the moment.format() function, which expects the input format to be 'x'
for Unix timestamps in milliseconds. This mismatch leads to the "Invalid
Date" error.
**Solution**
Modify the logic to map DateInputFormat.MILLISECONDS to the correct
moment format string 'x'.
Adjust the table's transformDataPureFn to correctly process and display
dates in Unix timestamp (ms) format after inline edits, ensuring the
moment library can handle the input properly.
**Outcome**
This fix ensures that when a user selects a date via the date picker in
inline editing mode, the selected date is displayed correctly in the
table without any errors.
Fixes #35631, #25081
## Automation
/ok-to-test tags="@tag.Sanity, @tag.Binding, @tag.Table,
@tag.Datepicker"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11101758400>
> Commit: 6a3cae774f3824bd2ee126b501bfa4b6d71ae0c8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11101758400&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker`
> Spec:
> <hr>Mon, 30 Sep 2024 08:54:58 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **New Features**
- Enhanced date column editing in table widgets to accept Unix
timestamps in milliseconds without errors.
- Introduced a new enumeration for improved date formatting options.
- Added mock data structures for testing various date formats and
transformations in the table widget.
- New method for generating formatted date strings for tomorrow in both
verbose and ISO formats.
- **Bug Fixes**
- Improved validation logic for date inputs in the table, ensuring
proper handling of different date formats.
- **Tests**
- Added new test cases to validate date handling and input formats in
the table widget.
- Introduced a new test suite for transforming table data based on
specified column metadata.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-30 09:02:42 +00:00
|
|
|
export enum MomentDateInputFormat {
|
|
|
|
|
MILLISECONDS = "x",
|
|
|
|
|
SECONDS = "X",
|
|
|
|
|
}
|
|
|
|
|
|
fix: Fixes currentRow calculation logic in table(property pane) (#35390)
## Description
<ins>Problem</ins>
`currentRow` variable which is availabe in property pane of col settings
- is not getting correct value during runtime if the table is sorted or
filtered.
<ins>Root cause</ins>
* We are considering `processedTableData` to get the `currentRow`.
* This property is not updated during filtering and sorting, another
property `filteredTableData` is updated instead.
* We CANNOT use `filteredTableData` as it depends on `primaryColumns`
property which we intend to update as well - this is leading to cyclic
dependency during evaluations.
<ins>Solution</ins>
Since the problem is related to edit cases and given the constraints
around using `filteredTableData` directly, we fixed the problem by
adding a new property to `editableCellValue` object called
`__originalIndex__`.
* This property stores the index of the row being edited in
`processedTableData`
* On top of this change, the PR adds a migration for updating the
current row binding in TableWidgetV2, ensuring accurate current row
calculation and improving the functionality of the widget.
* We also added unit test for migration changes.
* Additionally, This pull request refactors the DSLs for TableWidgetV2
migration test cases to update the DSLs to separate folder, drastically
reducing the file size to its core logic, improving the readability of
the code.
* We also updated relevant test cases to account for this change.
[Testing
plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487)
[Counter part EE
pr](https://github.com/appsmithorg/appsmith-ee/pull/4879)
Fixes #34346
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.All"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10451549845>
> Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 19 Aug 2024 11:15:04 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [x] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **New Features**
- Updated DSL migration process to support version 90, enhancing
compatibility and robustness.
- Introduced new migration logic for table widget data bindings,
improving inline editing capabilities.
- Enhanced validation logic for editable cells in table widgets,
allowing for more dynamic data handling.
- Added a method to discard edits in specific table cells, improving
user interaction.
- Introduced a new message constant for required fields, enhancing user
feedback.
- **Bug Fixes**
- Improved validation checks for table cells based on updated indices
and values.
- **Tests**
- Added comprehensive tests to validate migration functions related to
Table Widget, ensuring all aspects function correctly post-update.
- Enhanced test specifications for improved validation logic and
coverage in table widget functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: sneha122 <sneha@appsmith.com>
2024-08-20 08:01:45 +00:00
|
|
|
export const defaultEditableCell: EditableCell = {
|
2022-09-13 05:41:59 +00:00
|
|
|
column: "",
|
|
|
|
|
index: -1,
|
|
|
|
|
inputValue: "",
|
|
|
|
|
value: "",
|
|
|
|
|
initialValue: "",
|
fix: Fixes currentRow calculation logic in table(property pane) (#35390)
## Description
<ins>Problem</ins>
`currentRow` variable which is availabe in property pane of col settings
- is not getting correct value during runtime if the table is sorted or
filtered.
<ins>Root cause</ins>
* We are considering `processedTableData` to get the `currentRow`.
* This property is not updated during filtering and sorting, another
property `filteredTableData` is updated instead.
* We CANNOT use `filteredTableData` as it depends on `primaryColumns`
property which we intend to update as well - this is leading to cyclic
dependency during evaluations.
<ins>Solution</ins>
Since the problem is related to edit cases and given the constraints
around using `filteredTableData` directly, we fixed the problem by
adding a new property to `editableCellValue` object called
`__originalIndex__`.
* This property stores the index of the row being edited in
`processedTableData`
* On top of this change, the PR adds a migration for updating the
current row binding in TableWidgetV2, ensuring accurate current row
calculation and improving the functionality of the widget.
* We also added unit test for migration changes.
* Additionally, This pull request refactors the DSLs for TableWidgetV2
migration test cases to update the DSLs to separate folder, drastically
reducing the file size to its core logic, improving the readability of
the code.
* We also updated relevant test cases to account for this change.
[Testing
plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487)
[Counter part EE
pr](https://github.com/appsmithorg/appsmith-ee/pull/4879)
Fixes #34346
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.All"
### :mag: Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10451549845>
> Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 19 Aug 2024 11:15:04 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [x] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **New Features**
- Updated DSL migration process to support version 90, enhancing
compatibility and robustness.
- Introduced new migration logic for table widget data bindings,
improving inline editing capabilities.
- Enhanced validation logic for editable cells in table widgets,
allowing for more dynamic data handling.
- Added a method to discard edits in specific table cells, improving
user interaction.
- Introduced a new message constant for required fields, enhancing user
feedback.
- **Bug Fixes**
- Improved validation checks for table cells based on updated indices
and values.
- **Tests**
- Added comprehensive tests to validate migration functions related to
Table Widget, ensuring all aspects function correctly post-update.
- Enhanced test specifications for improved validation logic and
coverage in table widget functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: sneha122 <sneha@appsmith.com>
2024-08-20 08:01:45 +00:00
|
|
|
[ORIGINAL_INDEX_KEY]: -1,
|
2022-09-13 05:41:59 +00:00
|
|
|
};
|
2023-02-22 15:32:05 +00:00
|
|
|
|
|
|
|
|
export const DEFAULT_COLUMN_NAME = "Table Column";
|
2023-10-12 08:24:03 +00:00
|
|
|
|
|
|
|
|
export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING =
|
|
|
|
|
FEATURE_FLAG["release_table_serverside_filtering_enabled"];
|
2025-02-14 09:39:24 +00:00
|
|
|
|
|
|
|
|
export const INFINITE_SCROLL_ENABLED =
|
|
|
|
|
FEATURE_FLAG["release_tablev2_infinitescroll_enabled"];
|