chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type {
|
2021-02-16 10:29:08 +00:00
|
|
|
ColumnProperties,
|
|
|
|
|
CompactMode,
|
|
|
|
|
ReactTableFilter,
|
|
|
|
|
TableStyles,
|
2021-08-25 13:20:06 +00:00
|
|
|
SortOrderTypes,
|
2021-09-09 15:10:22 +00:00
|
|
|
} from "./component/Constants";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { WidgetProps } from "widgets/BaseWidget";
|
|
|
|
|
import type { WithMeta } from "widgets/MetaHOC";
|
2021-02-16 10:29:08 +00:00
|
|
|
|
|
|
|
|
export interface TableWidgetProps extends WidgetProps, WithMeta, TableStyles {
|
|
|
|
|
nextPageKey?: string;
|
|
|
|
|
prevPageKey?: string;
|
|
|
|
|
label: string;
|
|
|
|
|
searchText: string;
|
|
|
|
|
defaultSearchText: string;
|
2021-08-30 06:58:45 +00:00
|
|
|
defaultSelectedRow?: number | number[] | string;
|
2021-02-16 10:29:08 +00:00
|
|
|
tableData: Array<Record<string, unknown>>;
|
|
|
|
|
onPageChange?: string;
|
|
|
|
|
pageSize: number;
|
|
|
|
|
onRowSelected?: string;
|
|
|
|
|
onSearchTextChanged: string;
|
2021-08-25 13:20:06 +00:00
|
|
|
onSort: string;
|
2021-02-16 10:29:08 +00:00
|
|
|
selectedRowIndex?: number;
|
|
|
|
|
selectedRowIndices: number[];
|
|
|
|
|
serverSidePaginationEnabled?: boolean;
|
|
|
|
|
multiRowSelection?: boolean;
|
2021-12-09 06:35:27 +00:00
|
|
|
enableClientSideSearch?: boolean;
|
2021-02-16 10:29:08 +00:00
|
|
|
hiddenColumns?: string[];
|
|
|
|
|
columnOrder?: string[];
|
|
|
|
|
columnNameMap?: { [key: string]: string };
|
|
|
|
|
columnTypeMap?: {
|
|
|
|
|
[key: string]: { type: string; format: string; inputFormat?: string };
|
|
|
|
|
};
|
|
|
|
|
columnSizeMap?: { [key: string]: number };
|
|
|
|
|
filters?: ReactTableFilter[];
|
|
|
|
|
compactMode?: CompactMode;
|
2021-11-09 05:08:39 +00:00
|
|
|
isSortable?: boolean;
|
2021-12-08 14:06:14 +00:00
|
|
|
primaryColumnId?: string;
|
2021-02-16 10:29:08 +00:00
|
|
|
primaryColumns: Record<string, ColumnProperties>;
|
|
|
|
|
derivedColumns: Record<string, ColumnProperties>;
|
2021-08-25 13:20:06 +00:00
|
|
|
sortOrder: {
|
2021-02-16 10:29:08 +00:00
|
|
|
column: string;
|
2021-08-25 13:20:06 +00:00
|
|
|
order: SortOrderTypes | null;
|
2021-02-16 10:29:08 +00:00
|
|
|
};
|
2021-08-30 09:24:59 +00:00
|
|
|
totalRecordsCount?: number;
|
2022-05-04 09:45:57 +00:00
|
|
|
primaryColor: string;
|
|
|
|
|
borderRadius: string;
|
|
|
|
|
boxShadow?: string;
|
2021-02-16 10:29:08 +00:00
|
|
|
}
|
2021-07-22 08:43:58 +00:00
|
|
|
|
|
|
|
|
export const getCurrentRowBinding = (
|
|
|
|
|
entityName: string,
|
|
|
|
|
userInput: string,
|
|
|
|
|
withBinding = true,
|
|
|
|
|
) => {
|
|
|
|
|
let rowBinding = `${entityName}.sanatizedTableData.map((currentRow) => ( ${userInput}))`;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2021-07-22 08:43:58 +00:00
|
|
|
if (withBinding) rowBinding = `{{${rowBinding}}}`;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2021-07-22 08:43:58 +00:00
|
|
|
return rowBinding;
|
|
|
|
|
};
|