chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { FocusState } from "reducers/uiReducers/focusHistoryReducer";
|
|
|
|
|
import type {
|
2023-02-21 13:38:16 +00:00
|
|
|
CallEffectDescriptor,
|
|
|
|
|
PutEffectDescriptor,
|
|
|
|
|
SimpleEffect,
|
|
|
|
|
} from "redux-saga/effects";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import { call, put, select, take } from "redux-saga/effects";
|
2023-02-21 13:38:16 +00:00
|
|
|
import { getCurrentFocusInfo } from "selectors/focusHistorySelectors";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { FocusEntityInfo } from "navigation/FocusEntity";
|
2023-02-21 13:38:16 +00:00
|
|
|
import {
|
|
|
|
|
FocusEntity,
|
|
|
|
|
FocusStoreHierarchy,
|
|
|
|
|
identifyEntityFromPath,
|
|
|
|
|
shouldStoreURLForFocus,
|
|
|
|
|
} from "navigation/FocusEntity";
|
2023-10-18 07:14:10 +00:00
|
|
|
import type { Config } from "navigation/FocusElements";
|
|
|
|
|
import { ConfigType, FocusElementsConfig } from "navigation/FocusElements";
|
2023-02-21 13:38:16 +00:00
|
|
|
import { setFocusHistory } from "actions/focusHistoryActions";
|
2023-10-18 07:14:10 +00:00
|
|
|
import { builderURL, datasourcesEditorURL } from "@appsmith/RouteBuilder";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { AppsmithLocationState } from "utils/history";
|
|
|
|
|
import history, { NavigationMethod } from "utils/history";
|
2023-04-26 07:18:16 +00:00
|
|
|
import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { Action } from "entities/Action";
|
2023-09-12 11:51:39 +00:00
|
|
|
import { getAction, getPlugin } from "@appsmith/selectors/entitiesSelector";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { Plugin } from "api/PluginApi";
|
2023-02-21 13:38:16 +00:00
|
|
|
import { getCurrentGitBranch } from "selectors/gitSyncSelectors";
|
|
|
|
|
import { has } from "lodash";
|
|
|
|
|
|
2023-10-18 07:14:10 +00:00
|
|
|
/**
|
|
|
|
|
* Context switching works by restoring the states of ui elements to as they were
|
|
|
|
|
* the last time the user was on a particular URL.
|
|
|
|
|
*
|
|
|
|
|
* To do this, there are two simple steps
|
|
|
|
|
* 1. When leaving an url, store the ui or url states
|
|
|
|
|
* 2. When entering an url, restore stored ui or url states, or defaults
|
|
|
|
|
*
|
|
|
|
|
* @param currentPath
|
|
|
|
|
* @param previousPath
|
|
|
|
|
* @param state
|
|
|
|
|
*/
|
2023-02-21 13:38:16 +00:00
|
|
|
export function* contextSwitchingSaga(
|
|
|
|
|
currentPath: string,
|
|
|
|
|
previousPath: string,
|
|
|
|
|
state: AppsmithLocationState,
|
|
|
|
|
) {
|
|
|
|
|
if (previousPath) {
|
2023-10-18 07:14:10 +00:00
|
|
|
/* STORE THE UI STATE OF PREVIOUS URL */
|
|
|
|
|
// First get all the entities
|
2023-02-21 13:38:16 +00:00
|
|
|
const storePaths: Array<{
|
|
|
|
|
key: string;
|
|
|
|
|
entityInfo: FocusEntityInfo;
|
|
|
|
|
}> = yield call(getEntitiesForStore, previousPath, currentPath);
|
|
|
|
|
for (const storePath of storePaths) {
|
|
|
|
|
yield call(
|
|
|
|
|
storeStateOfPath,
|
|
|
|
|
storePath.key,
|
|
|
|
|
storePath.entityInfo,
|
|
|
|
|
previousPath,
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
2023-10-18 07:14:10 +00:00
|
|
|
/* RESTORE THE UI STATE OF THE NEW URL */
|
2023-02-21 13:38:16 +00:00
|
|
|
yield call(waitForPathLoad, currentPath, previousPath);
|
|
|
|
|
const setPaths: Array<{
|
|
|
|
|
key: string;
|
|
|
|
|
entityInfo: FocusEntityInfo;
|
|
|
|
|
}> = yield call(getEntitiesForSet, previousPath, currentPath, state);
|
|
|
|
|
for (const setPath of setPaths) {
|
|
|
|
|
yield call(setStateOfPath, setPath.key, setPath.entityInfo);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* waitForPathLoad(currentPath: string, previousPath?: string) {
|
|
|
|
|
if (previousPath) {
|
|
|
|
|
const currentFocus = identifyEntityFromPath(currentPath);
|
|
|
|
|
const prevFocus = identifyEntityFromPath(previousPath);
|
|
|
|
|
|
|
|
|
|
if (currentFocus.pageId !== prevFocus.pageId) {
|
|
|
|
|
yield take(ReduxActionTypes.FETCH_PAGE_SUCCESS);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type StoreStateOfPathType = Generator<
|
2023-10-18 07:14:10 +00:00
|
|
|
| SimpleEffect<"CALL", CallEffectDescriptor<unknown>>
|
2023-02-21 13:38:16 +00:00
|
|
|
| SimpleEffect<
|
|
|
|
|
"PUT",
|
|
|
|
|
PutEffectDescriptor<{
|
|
|
|
|
payload: { focusState: FocusState; key: string };
|
|
|
|
|
type: string;
|
|
|
|
|
}>
|
|
|
|
|
>,
|
|
|
|
|
void,
|
|
|
|
|
FocusState | undefined
|
|
|
|
|
>;
|
|
|
|
|
|
|
|
|
|
function* storeStateOfPath(
|
|
|
|
|
key: string,
|
|
|
|
|
entityInfo: FocusEntityInfo,
|
|
|
|
|
fromPath: string,
|
|
|
|
|
): StoreStateOfPathType {
|
|
|
|
|
const selectors = FocusElementsConfig[entityInfo.entity];
|
|
|
|
|
const state: Record<string, any> = {};
|
|
|
|
|
for (const selectorInfo of selectors) {
|
2023-10-18 07:14:10 +00:00
|
|
|
state[selectorInfo.name] = yield call(getState, selectorInfo, fromPath);
|
2023-02-21 13:38:16 +00:00
|
|
|
}
|
|
|
|
|
if (entityInfo.entity === FocusEntity.PAGE) {
|
|
|
|
|
if (shouldStoreURLForFocus(fromPath)) {
|
|
|
|
|
if (fromPath) {
|
|
|
|
|
state._routingURL = fromPath;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
yield put(
|
|
|
|
|
setFocusHistory(key, {
|
|
|
|
|
entityInfo,
|
|
|
|
|
state,
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* setStateOfPath(key: string, entityInfo: FocusEntityInfo) {
|
|
|
|
|
const focusHistory: FocusState = yield select(getCurrentFocusInfo, key);
|
|
|
|
|
|
|
|
|
|
const selectors = FocusElementsConfig[entityInfo.entity];
|
|
|
|
|
|
|
|
|
|
if (focusHistory) {
|
|
|
|
|
for (const selectorInfo of selectors) {
|
2023-10-18 07:14:10 +00:00
|
|
|
yield call(setState, selectorInfo, focusHistory.state[selectorInfo.name]);
|
2023-02-21 13:38:16 +00:00
|
|
|
}
|
|
|
|
|
if (entityInfo.entity === FocusEntity.PAGE) {
|
|
|
|
|
if (focusHistory.state._routingURL) {
|
|
|
|
|
const params = history.location.search;
|
|
|
|
|
history.push(`${focusHistory.state._routingURL}${params ?? ""}`);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
const subType: string | undefined = yield call(
|
|
|
|
|
getEntitySubType,
|
|
|
|
|
entityInfo,
|
|
|
|
|
);
|
|
|
|
|
for (const selectorInfo of selectors) {
|
|
|
|
|
const { defaultValue, subTypes } = selectorInfo;
|
|
|
|
|
if (subType && subTypes && subType in subTypes) {
|
2023-10-18 07:14:10 +00:00
|
|
|
yield call(setState, selectorInfo, subTypes[subType].defaultValue);
|
2023-02-21 13:38:16 +00:00
|
|
|
} else if (defaultValue !== undefined) {
|
2023-10-24 09:58:21 +00:00
|
|
|
if (typeof defaultValue === "function") {
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
|
|
|
|
|
// @ts-ignore
|
|
|
|
|
const stateDefaultValue: unknown = yield select(defaultValue);
|
|
|
|
|
yield call(setState, selectorInfo, stateDefaultValue);
|
|
|
|
|
} else {
|
|
|
|
|
yield call(setState, selectorInfo, defaultValue);
|
|
|
|
|
}
|
2023-02-21 13:38:16 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* getEntitySubType(entityInfo: FocusEntityInfo) {
|
|
|
|
|
if ([FocusEntity.API, FocusEntity.QUERY].includes(entityInfo.entity)) {
|
2023-03-16 10:56:48 +00:00
|
|
|
const action: Action | undefined = yield select(getAction, entityInfo.id);
|
|
|
|
|
if (action) {
|
|
|
|
|
const plugin: Plugin = yield select(getPlugin, action.pluginId);
|
|
|
|
|
return plugin.packageName;
|
|
|
|
|
}
|
2023-02-21 13:38:16 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* This method returns boolean to indicate if state should be restored to the path
|
|
|
|
|
* @param prevPath
|
|
|
|
|
* @param currPath
|
|
|
|
|
* @param state
|
|
|
|
|
* @returns
|
|
|
|
|
*/
|
|
|
|
|
function shouldSetState(
|
|
|
|
|
prevPath: string,
|
|
|
|
|
currPath: string,
|
|
|
|
|
state?: AppsmithLocationState,
|
|
|
|
|
) {
|
|
|
|
|
if (
|
|
|
|
|
state &&
|
|
|
|
|
state.invokedBy &&
|
|
|
|
|
[NavigationMethod.CommandClick, NavigationMethod.Omnibar].includes(
|
|
|
|
|
state.invokedBy,
|
|
|
|
|
)
|
|
|
|
|
) {
|
|
|
|
|
// If it is a direct navigation, we will set the state
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
const prevFocusEntityInfo = identifyEntityFromPath(prevPath);
|
|
|
|
|
const currFocusEntityInfo = identifyEntityFromPath(currPath);
|
|
|
|
|
|
|
|
|
|
// While switching from selected widget state to canvas,
|
|
|
|
|
// it should not be restored stored state for canvas
|
|
|
|
|
return !(
|
|
|
|
|
prevFocusEntityInfo.entity === FocusEntity.PROPERTY_PANE &&
|
|
|
|
|
currFocusEntityInfo.entity === FocusEntity.CANVAS &&
|
|
|
|
|
prevFocusEntityInfo.pageId === currFocusEntityInfo.pageId
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const getEntityParentUrl = (
|
|
|
|
|
entityInfo: FocusEntityInfo,
|
|
|
|
|
parentEntity: FocusEntity,
|
|
|
|
|
): string => {
|
|
|
|
|
if (parentEntity === FocusEntity.CANVAS) {
|
|
|
|
|
const canvasUrl = builderURL({ pageId: entityInfo.pageId ?? "" });
|
|
|
|
|
return canvasUrl.split("?")[0];
|
|
|
|
|
}
|
2023-10-18 07:14:10 +00:00
|
|
|
if (parentEntity === FocusEntity.DATASOURCE_LIST) {
|
|
|
|
|
return datasourcesEditorURL({ pageId: entityInfo.pageId });
|
|
|
|
|
}
|
2023-02-21 13:38:16 +00:00
|
|
|
return "";
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const isPageChange = (prevPath: string, currentPath: string) => {
|
|
|
|
|
const prevFocusEntityInfo = identifyEntityFromPath(prevPath);
|
|
|
|
|
const currFocusEntityInfo = identifyEntityFromPath(currentPath);
|
|
|
|
|
if (prevFocusEntityInfo.pageId === "" || currFocusEntityInfo.pageId === "") {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
return prevFocusEntityInfo.pageId !== currFocusEntityInfo.pageId;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
function* getEntitiesForStore(previousPath: string, currentPath: string) {
|
|
|
|
|
const branch: string | undefined = yield select(getCurrentGitBranch);
|
|
|
|
|
const entities: Array<{ entityInfo: FocusEntityInfo; key: string }> = [];
|
|
|
|
|
const prevFocusEntityInfo = identifyEntityFromPath(previousPath);
|
|
|
|
|
if (isPageChange(previousPath, currentPath)) {
|
|
|
|
|
if (prevFocusEntityInfo.pageId) {
|
|
|
|
|
entities.push({
|
|
|
|
|
key: `${prevFocusEntityInfo.pageId}#${branch}`,
|
|
|
|
|
entityInfo: {
|
|
|
|
|
entity: FocusEntity.PAGE,
|
|
|
|
|
id: prevFocusEntityInfo.pageId,
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (prevFocusEntityInfo.entity in FocusStoreHierarchy) {
|
|
|
|
|
const parentEntity = FocusStoreHierarchy[prevFocusEntityInfo.entity];
|
|
|
|
|
if (parentEntity) {
|
|
|
|
|
const parentPath = getEntityParentUrl(prevFocusEntityInfo, parentEntity);
|
|
|
|
|
entities.push({
|
|
|
|
|
entityInfo: {
|
|
|
|
|
entity: parentEntity,
|
|
|
|
|
id: "",
|
|
|
|
|
pageId: prevFocusEntityInfo.pageId,
|
|
|
|
|
},
|
|
|
|
|
key: `${parentPath}#${branch}`,
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
entities.push({
|
|
|
|
|
entityInfo: prevFocusEntityInfo,
|
|
|
|
|
key: `${previousPath}#${branch}`,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return entities.filter(
|
|
|
|
|
(entity) => entity.entityInfo.entity !== FocusEntity.NONE,
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* getEntitiesForSet(
|
|
|
|
|
previousPath: string,
|
|
|
|
|
currentPath: string,
|
|
|
|
|
state: AppsmithLocationState,
|
|
|
|
|
) {
|
|
|
|
|
if (!shouldSetState(previousPath, currentPath, state)) {
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
const branch: string | undefined = yield select(getCurrentGitBranch);
|
|
|
|
|
const entities: Array<{ entityInfo: FocusEntityInfo; key: string }> = [];
|
|
|
|
|
const currentEntityInfo = identifyEntityFromPath(currentPath);
|
|
|
|
|
if (isPageChange(previousPath, currentPath)) {
|
|
|
|
|
if (currentEntityInfo.pageId) {
|
|
|
|
|
entities.push({
|
|
|
|
|
key: `${currentEntityInfo.pageId}#${branch}`,
|
|
|
|
|
entityInfo: {
|
|
|
|
|
entity: FocusEntity.PAGE,
|
|
|
|
|
id: currentEntityInfo.pageId,
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const focusHistory: FocusState = yield select(
|
|
|
|
|
getCurrentFocusInfo,
|
|
|
|
|
`${currentEntityInfo.pageId}#${branch}`,
|
|
|
|
|
);
|
|
|
|
|
if (has(focusHistory, "state._routingURL")) {
|
|
|
|
|
return entities;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
entities.push({
|
|
|
|
|
entityInfo: currentEntityInfo,
|
|
|
|
|
key: `${currentPath}#${branch}`,
|
|
|
|
|
});
|
|
|
|
|
return entities.filter(
|
|
|
|
|
(entity) => entity.entityInfo.entity !== FocusEntity.NONE,
|
|
|
|
|
);
|
|
|
|
|
}
|
2023-10-18 07:14:10 +00:00
|
|
|
|
|
|
|
|
function* getState(config: Config, previousURL: string): unknown {
|
|
|
|
|
if (config.type === ConfigType.Redux) {
|
|
|
|
|
return yield select(config.selector);
|
|
|
|
|
} else if (config.type === ConfigType.URL) {
|
|
|
|
|
return config.selector(previousURL);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* setState(config: Config, value: unknown): unknown {
|
|
|
|
|
if (config.type === ConfigType.Redux) {
|
|
|
|
|
yield put(config.setter(value));
|
|
|
|
|
} else if (config.type === ConfigType.URL) {
|
|
|
|
|
config.setter(value);
|
|
|
|
|
}
|
|
|
|
|
}
|