2023-02-21 13:38:16 +00:00
|
|
|
import { all, call, put, select, takeLeading } from "redux-saga/effects";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
|
|
|
import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
|
2022-10-17 15:16:38 +00:00
|
|
|
import { snipingModeBindToSelector } from "selectors/editorSelectors";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ActionData } from "reducers/entityReducers/actionsReducer";
|
2022-04-12 10:50:01 +00:00
|
|
|
import { getCanvasWidgets } from "selectors/entitiesSelector";
|
2021-07-26 16:44:10 +00:00
|
|
|
import {
|
|
|
|
|
setWidgetDynamicProperty,
|
|
|
|
|
updateWidgetPropertyRequest,
|
2022-04-12 10:50:01 +00:00
|
|
|
} from "actions/controlActions";
|
|
|
|
|
import AnalyticsUtil from "utils/AnalyticsUtil";
|
2021-09-09 15:10:22 +00:00
|
|
|
|
2021-09-07 04:45:13 +00:00
|
|
|
import {
|
|
|
|
|
SNIPING_NOT_SUPPORTED,
|
|
|
|
|
SNIPING_SELECT_WIDGET_AGAIN,
|
2022-02-11 18:08:46 +00:00
|
|
|
} from "@appsmith/constants/messages";
|
2021-07-26 16:44:10 +00:00
|
|
|
|
2021-09-09 15:10:22 +00:00
|
|
|
import WidgetFactory from "utils/WidgetFactory";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { CanvasWidgetsReduxState } from "reducers/entityReducers/canvasWidgetsReducer";
|
2022-10-17 15:16:38 +00:00
|
|
|
import { setSnipingMode } from "actions/propertyPaneActions";
|
2023-02-21 13:38:16 +00:00
|
|
|
import { selectWidgetInitAction } from "actions/widgetSelectionActions";
|
|
|
|
|
import { SelectionRequestType } from "sagas/WidgetSelectUtils";
|
2023-05-19 18:37:06 +00:00
|
|
|
import { toast } from "design-system";
|
2023-07-12 06:42:16 +00:00
|
|
|
import {
|
|
|
|
|
AB_TESTING_EVENT_KEYS,
|
|
|
|
|
FEATURE_FLAG,
|
|
|
|
|
} from "@appsmith/entities/FeatureFlag";
|
2023-07-12 08:45:37 +00:00
|
|
|
import { selectFeatureFlagCheck } from "@appsmith/selectors/featureFlagsSelectors";
|
2021-09-09 15:10:22 +00:00
|
|
|
|
|
|
|
|
const WidgetTypes = WidgetFactory.widgetTypes;
|
|
|
|
|
|
2021-07-26 16:44:10 +00:00
|
|
|
export function* bindDataToWidgetSaga(
|
|
|
|
|
action: ReduxAction<{
|
|
|
|
|
widgetId: string;
|
|
|
|
|
}>,
|
|
|
|
|
) {
|
2022-10-17 15:16:38 +00:00
|
|
|
const queryId: string = yield select(snipingModeBindToSelector);
|
2022-06-21 13:57:34 +00:00
|
|
|
const currentAction: ActionData | undefined = yield select((state) =>
|
2021-07-26 16:44:10 +00:00
|
|
|
state.entities.actions.find(
|
|
|
|
|
(action: ActionData) => action.config.id === queryId,
|
|
|
|
|
),
|
|
|
|
|
);
|
2022-06-21 13:57:34 +00:00
|
|
|
const widgetState: CanvasWidgetsReduxState = yield select(getCanvasWidgets);
|
2023-07-12 06:42:16 +00:00
|
|
|
const isDSBindingEnabled: boolean = yield select(
|
|
|
|
|
selectFeatureFlagCheck,
|
|
|
|
|
FEATURE_FLAG.ab_ds_binding_enabled,
|
|
|
|
|
);
|
2022-06-21 13:57:34 +00:00
|
|
|
const selectedWidget = widgetState[action.payload.widgetId];
|
2021-07-26 16:44:10 +00:00
|
|
|
|
2021-09-07 04:45:13 +00:00
|
|
|
if (!selectedWidget || !selectedWidget.type) {
|
2023-05-19 18:37:06 +00:00
|
|
|
toast.show(SNIPING_SELECT_WIDGET_AGAIN(), {
|
|
|
|
|
kind: "warning",
|
2021-09-07 04:45:13 +00:00
|
|
|
});
|
|
|
|
|
return;
|
|
|
|
|
}
|
2021-09-09 13:19:39 +00:00
|
|
|
const { widgetId } = action.payload;
|
2021-07-26 16:44:10 +00:00
|
|
|
let propertyPath = "";
|
|
|
|
|
let propertyValue: any = "";
|
|
|
|
|
let isValidProperty = true;
|
|
|
|
|
|
2022-06-21 13:57:34 +00:00
|
|
|
// Pranav has an Open PR for this file so just returning for now
|
|
|
|
|
if (!currentAction) return;
|
|
|
|
|
|
2023-06-22 10:41:56 +00:00
|
|
|
//TODO (Balaji): Abstraction leak. propertyPath should come from the widget
|
2021-07-26 16:44:10 +00:00
|
|
|
switch (selectedWidget.type) {
|
|
|
|
|
case WidgetTypes.BUTTON_WIDGET:
|
|
|
|
|
case WidgetTypes.FORM_BUTTON_WIDGET:
|
|
|
|
|
propertyPath = "onClick";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.run()}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.CHECKBOX_WIDGET:
|
|
|
|
|
propertyPath = "defaultCheckedState";
|
2021-09-09 13:19:39 +00:00
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2021-07-26 16:44:10 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.DATE_PICKER_WIDGET2:
|
|
|
|
|
propertyPath = "defaultDate";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.FILE_PICKER_WIDGET:
|
|
|
|
|
propertyPath = "onFilesSelected";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.run()}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.IFRAME_WIDGET:
|
|
|
|
|
propertyPath = "source";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.INPUT_WIDGET:
|
|
|
|
|
propertyPath = "defaultText";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2022-01-18 07:52:24 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.INPUT_WIDGET_V2:
|
|
|
|
|
propertyPath = "defaultText";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2021-07-26 16:44:10 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.LIST_WIDGET:
|
2022-05-18 07:33:52 +00:00
|
|
|
propertyPath = "listData";
|
2021-07-26 16:44:10 +00:00
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2023-02-14 16:07:31 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.LIST_WIDGET_V2:
|
|
|
|
|
propertyPath = "listData";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2021-07-26 16:44:10 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.MAP_WIDGET:
|
|
|
|
|
propertyPath = "defaultMarkers";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.RADIO_GROUP_WIDGET:
|
|
|
|
|
propertyPath = "options";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.RATE_WIDGET:
|
|
|
|
|
propertyPath = "onRateChanged";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.run()}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.RICH_TEXT_EDITOR_WIDGET:
|
|
|
|
|
propertyPath = "defaultText";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.DROP_DOWN_WIDGET:
|
|
|
|
|
propertyPath = "options";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
2022-02-02 14:15:07 +00:00
|
|
|
case WidgetTypes.SELECT_WIDGET:
|
2023-07-25 04:56:33 +00:00
|
|
|
propertyPath = "sourceData";
|
2022-02-02 14:15:07 +00:00
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
2021-07-26 16:44:10 +00:00
|
|
|
case WidgetTypes.SWITCH_WIDGET:
|
|
|
|
|
propertyPath = "defaultSwitchState";
|
2021-09-09 13:19:39 +00:00
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
2021-07-26 16:44:10 +00:00
|
|
|
break;
|
|
|
|
|
case WidgetTypes.TABLE_WIDGET:
|
|
|
|
|
propertyPath = "tableData";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
2022-07-14 07:02:35 +00:00
|
|
|
case WidgetTypes.TABLE_WIDGET_V2:
|
|
|
|
|
propertyPath = "tableData";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
2021-07-26 16:44:10 +00:00
|
|
|
case WidgetTypes.TEXT_WIDGET:
|
|
|
|
|
propertyPath = "text";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
|
|
|
|
case WidgetTypes.VIDEO_WIDGET:
|
|
|
|
|
propertyPath = "url";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
feat: JSON Form widget (#8472)
* initial layout
* updated parser to support nested array
* array field rendering
* changes
* ts fix
* minor revert FormWidget
* modified schema structure
* select and switch fields
* added checkbox field
* added RadioGroupField
* partial DateField and defaults, typing refactoring
* added label and field type change
* minor ts changes
* changes
* modified widget/utils for nested panelConfig, modified schema to object approach
* array/object label support
* hide field configuration when children not present
* added tooltip
* field visibility option
* disabled state
* upgraded tslib, form initial values
* custom field configuration - add/hide/edit
* field configuration - label change
* return input when field configuration reaches max depth
* minor changes
* form - scroll, fixedfooter, enitity defn and other minior changes
* form title
* unregister on unmount
* fixes
* zero state
* fix field padding
* patched updating form values, removed linting warnings
* configured action buttons
* minor fix
* minor change
* property pane - sort fields in field configuration
* refactor include all properties
* checkbox properties
* date properties
* refactor typings and radio group properties
* switch, multselect, select, array, object properties
* minor changes
* default value
* ts fixes
* checkbox field properties implementation
* date field prop implementation
* switch field
* select field and fix deep nested meta properties
* multiselect implementation
* minor change
* input field implementation
* fix position jump on field type change
* initial accordian
* field state property and auto-complete of JSONFormComputeControl
* merge fixes
* renamed FormBuilder to JSONForm
* source data validation minor change
* custom field default value fix
* Editable keys for custom field
* minor fixes
* replaced useFieldArray with custom logic, added widget icon
* array and object accordian with border/background styling
* minor change
* disabled states for array and objects
* default value minor fix
* form level styles
* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren
* added isValid for all field types
* fixed reset to default values
* debounce form values update
* minor change
* minor change
* fix crash - source data change multi-select to array, fix crash - change of options
* fix positioning
* detect date type in source data
* fix crash - when object is passed to regex input field
* fixed default sourceData path for fields
* accodion keep children mounted on collapse
* jest test for schemaParser
* widget/helper and useRegisterFieldInvalid test
* tests for property config helper and generatePanelPropertyConfig
* fix input field validation not appearing
* fix date field type detection
* rename data -> formData
* handle null/undefined field value change in sourceData
* added null/undefined as valid values for defaultValue text field
* auto detect email field
* set formData default value on initial load
* switch field inline positioning
* field margin fix for row direction
* select full width
* fiex date field default value - out of range
* fix any field type to array
* array default value logic change
* base cypress test changes
* initial json form render cy test
* key sanitization
* fix fieldState update logic
* required design, object/array background color, accordion changes, fix - add new custom field
* minor change
* cypress tests
* fix date formatted value, field state cypress test
* cypress - field properties test and fixes
* rename test file
* fix accessort change to blank value, cypress tests
* fix array field default value for modified accessor
* minor fix
* added animate loading
* fix empty state, add new custom field
* test data fix
* fix warnings
* fix timePrecision visibility
* button styling
* ported input v2
* fix jest tests
* fix cypress tests
* perf changes
* perf improvement
* added comments
* multiselect changes
* input field perf refactor
* array field, object field refactor performance
* checkbox field refactor
* refectored date, radio, select and switch
* fixes
* test fixes
* fixes
* minor fix
* rename field renderer
* remove tracked fieldRenderer field
* cypress test fixes
* cypress changes
* array default value fixes
* arrayfield passedDefaultValue
* auto enabled JS mode for few properties, reverted swith and date property controls
* cypress changes
* added widget sniping mode and fixed object passedDefaultValue
* multiselect v2
* select v2
* fix jest tests
* test fixes
* field limit
* rename field type dropdown texts
* field type changes fixes
* jest fixes
* loading state submit button
* default source data for new widget
* modify limit message
* multiseelct default value changes and cypress fix
* select default value
* keep default value intact on field type change
* TextTable cypress text fix
* review changes
* fixed footer changes
* collapse styles section by default
* fixed footer changes
* form modes
* custom field key rentention
* fixed footer fix in view mode
* non ascii characters
* fix meta merge in dataTreeWidget
* minor fixes
* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts
* modified dependency injection into evaluated values
* refactored fixedfooter logic
* minor change
* accessor update
* minor change
* fixes
* QA fixes date field, scroll content
* fix phone number field, removed visiblity option from array item
* fix sourceData autocomplete
* reset logic
* fix multiselect reset
* form values hydration on widget drag
* code review changes
* reverted order of merge dataTreeWidget
* fixes
* added button titles, fixed hydration issue
* default value fixes
* upgraded react hook form, modified array-level/field-level default value logic
* fixed select validation
* added icon entity explorer, modified icon align control
* modify accessor validation for mongo db _id
* update email field regex
* review changes
* explicitly handle empty source data validation
2022-03-24 07:13:25 +00:00
|
|
|
case WidgetTypes.JSON_FORM_WIDGET:
|
|
|
|
|
propertyPath = "sourceData";
|
|
|
|
|
propertyValue = `{{${currentAction.config.name}.data}}`;
|
|
|
|
|
break;
|
2021-07-26 16:44:10 +00:00
|
|
|
default:
|
|
|
|
|
isValidProperty = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
AnalyticsUtil.logEvent("WIDGET_SELECTED_VIA_SNIPING_MODE", {
|
|
|
|
|
widgetType: selectedWidget.type,
|
|
|
|
|
actionName: currentAction.config.name,
|
|
|
|
|
apiId: queryId,
|
|
|
|
|
propertyPath,
|
|
|
|
|
propertyValue,
|
2023-07-12 06:42:16 +00:00
|
|
|
[AB_TESTING_EVENT_KEYS.abTestingFlagLabel]:
|
|
|
|
|
FEATURE_FLAG.ab_ds_binding_enabled,
|
|
|
|
|
[AB_TESTING_EVENT_KEYS.abTestingFlagValue]: isDSBindingEnabled,
|
2021-07-26 16:44:10 +00:00
|
|
|
});
|
|
|
|
|
if (queryId && isValidProperty) {
|
2021-09-09 13:19:39 +00:00
|
|
|
// set the property path to dynamic, i.e. enable JS mode
|
|
|
|
|
yield put(setWidgetDynamicProperty(widgetId, propertyPath, true));
|
2021-07-26 16:44:10 +00:00
|
|
|
yield put(
|
2021-09-21 07:55:56 +00:00
|
|
|
updateWidgetPropertyRequest(widgetId, propertyPath, propertyValue),
|
2021-07-26 16:44:10 +00:00
|
|
|
);
|
2022-10-17 15:16:38 +00:00
|
|
|
yield call(resetSnipingModeSaga);
|
2023-02-21 13:38:16 +00:00
|
|
|
yield put(selectWidgetInitAction(SelectionRequestType.One, [widgetId]));
|
2021-07-26 16:44:10 +00:00
|
|
|
} else {
|
|
|
|
|
queryId &&
|
2023-05-19 18:37:06 +00:00
|
|
|
toast.show(SNIPING_NOT_SUPPORTED(), {
|
|
|
|
|
kind: "warning",
|
2021-07-26 16:44:10 +00:00
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* resetSnipingModeSaga() {
|
2022-10-17 15:16:38 +00:00
|
|
|
yield put(
|
|
|
|
|
setSnipingMode({
|
|
|
|
|
isActive: false,
|
|
|
|
|
bindTo: undefined,
|
|
|
|
|
}),
|
|
|
|
|
);
|
2021-07-26 16:44:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export default function* snipingModeSagas() {
|
|
|
|
|
yield all([
|
|
|
|
|
takeLeading(ReduxActionTypes.BIND_DATA_TO_WIDGET, bindDataToWidgetSaga),
|
|
|
|
|
takeLeading(ReduxActionTypes.RESET_SNIPING_MODE, resetSnipingModeSaga),
|
|
|
|
|
]);
|
|
|
|
|
}
|