chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { EmbeddedRestDatasource } from "entities/Datasource";
|
|
|
|
|
import type { DynamicPath } from "utils/DynamicBindingUtils";
|
2021-01-12 04:17:28 +00:00
|
|
|
import _ from "lodash";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { LayoutOnLoadActionErrors } from "constants/AppsmithActionConstants/ActionConstants";
|
2024-08-06 14:52:22 +00:00
|
|
|
import type { EventLocation } from "ee/utils/analyticsUtilTypes";
|
|
|
|
|
import type { ActionParentEntityTypeInterface } from "ee/entities/Engine/actionHelpers";
|
2025-01-15 05:59:32 +00:00
|
|
|
import {
|
|
|
|
|
PluginPackageName,
|
|
|
|
|
PluginType,
|
|
|
|
|
type Plugin,
|
|
|
|
|
type PluginName,
|
|
|
|
|
} from "../Plugin";
|
2025-04-30 05:44:26 +00:00
|
|
|
import type { ActionRunBehaviourType } from "PluginActionEditor/types/PluginActionTypes";
|
2023-06-08 09:09:19 +00:00
|
|
|
|
2020-06-04 13:49:22 +00:00
|
|
|
export enum PaginationType {
|
|
|
|
|
NONE = "NONE",
|
|
|
|
|
PAGE_NO = "PAGE_NO",
|
|
|
|
|
URL = "URL",
|
2022-09-09 15:59:47 +00:00
|
|
|
CURSOR = "CURSOR",
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
2024-03-11 04:52:24 +00:00
|
|
|
// Used for analytic events
|
|
|
|
|
export enum ActionCreationSourceTypeEnum {
|
|
|
|
|
SELF = "SELF",
|
|
|
|
|
GENERATE_PAGE = "GENERATE_PAGE",
|
|
|
|
|
ONE_CLICK_BINDING = "ONE_CLICK_BINDING",
|
|
|
|
|
CLONE_PAGE = "CLONE_PAGE",
|
|
|
|
|
FORK_APPLICATION = "FORK_APPLICATION",
|
|
|
|
|
COPY_ACTION = "COPY_ACTION",
|
|
|
|
|
}
|
|
|
|
|
|
2024-03-12 10:06:33 +00:00
|
|
|
// Used for analytic events
|
|
|
|
|
export enum ActionExecutionContext {
|
|
|
|
|
SELF = "SELF",
|
|
|
|
|
ONE_CLICK_BINDING = "ONE_CLICK_BINDING",
|
|
|
|
|
GENERATE_CRUD_PAGE = "GENERATE_CRUD_PAGE",
|
|
|
|
|
CLONE_PAGE = "CLONE_PAGE",
|
|
|
|
|
FORK_TEMPLATE_PAGE = "FORK_TEMPLATE_PAGE",
|
|
|
|
|
PAGE_LOAD = "PAGE_LOAD",
|
|
|
|
|
EVALUATION_ACTION_TRIGGER = "EVALUATION_ACTION_TRIGGER",
|
|
|
|
|
REFRESH_ACTIONS_ON_ENV_CHANGE = "REFRESH_ACTIONS_ON_ENV_CHANGE",
|
|
|
|
|
}
|
|
|
|
|
|
2021-12-28 12:14:32 +00:00
|
|
|
export interface KeyValuePair {
|
|
|
|
|
key?: string;
|
|
|
|
|
value?: unknown;
|
|
|
|
|
}
|
|
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface LimitOffset {
|
2022-09-09 15:59:47 +00:00
|
|
|
limit: Record<string, unknown>;
|
|
|
|
|
offset: Record<string, unknown>;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2022-09-09 15:59:47 +00:00
|
|
|
export interface SelfReferencingData {
|
|
|
|
|
limitBased?: LimitOffset;
|
|
|
|
|
curserBased?: {
|
|
|
|
|
previous?: LimitOffset;
|
|
|
|
|
next?: LimitOffset;
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-04 13:49:22 +00:00
|
|
|
export interface ActionConfig {
|
2021-01-12 04:17:28 +00:00
|
|
|
timeoutInMillisecond?: number;
|
2020-06-04 13:49:22 +00:00
|
|
|
paginationType?: PaginationType;
|
2021-08-23 07:34:44 +00:00
|
|
|
formData?: Record<string, unknown>;
|
2021-12-28 12:14:32 +00:00
|
|
|
pluginSpecifiedTemplates?: KeyValuePair[];
|
|
|
|
|
path?: string;
|
|
|
|
|
queryParameters?: KeyValuePair[];
|
2022-09-09 15:59:47 +00:00
|
|
|
selfReferencingData?: SelfReferencingData;
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export interface Property {
|
|
|
|
|
key: string;
|
|
|
|
|
value: string;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export interface BodyFormData {
|
|
|
|
|
editable: boolean;
|
|
|
|
|
mandatory: boolean;
|
|
|
|
|
description: string;
|
|
|
|
|
key: string;
|
|
|
|
|
value?: string;
|
|
|
|
|
type: string;
|
|
|
|
|
}
|
|
|
|
|
|
2025-01-16 16:56:34 +00:00
|
|
|
export interface AutoGeneratedHeader {
|
|
|
|
|
key: string;
|
|
|
|
|
value: string;
|
|
|
|
|
isInvalid: boolean;
|
|
|
|
|
}
|
|
|
|
|
|
feat: Support body in GET API requests (#7127)
* WIP
* Refactoring HTTP Method & Content Type to be objects instead of arrays
TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request
* Almost working implementation for the None type
Currently, the body still gets sent in non-GET requests even if the None tab is selected.
* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM
* WIP: Using enum & const for ts autocomplete
* working implementation for NONE type, apiContentType prop added to API actions
* WIP
* Refactoring HTTP Method & Content Type to be objects instead of arrays
TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request
* Almost working implementation for the None type
Currently, the body still gets sent in non-GET requests even if the None tab is selected.
* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM
* WIP: Using enum & const for ts autocomplete
* working implementation for NONE type, apiContentType prop added to API actions
* adds apiContentType to actionConfiguration.formData object
* Handling apiContentType property in Rest API formData
* change apiContentType when user types content-type value and switches http method
* makes api editor as similar as possible to postman, project postman.
* Correcting the import in ApiEditorConstants
* Resolved all merge conflicts
* replay DSL functtionality
* removes unneccessary files from worker
* Fixes type declarations, naming e.t.c.
* fix server side merge conflicts
* fix client side merge conflicts
* fix failing cypress tests
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
|
|
|
export interface ApiActionConfig extends Omit<ActionConfig, "formData"> {
|
2020-06-04 13:49:22 +00:00
|
|
|
headers: Property[];
|
2023-03-01 08:51:57 +00:00
|
|
|
autoGeneratedHeaders?: AutoGeneratedHeader[];
|
2020-06-04 13:49:22 +00:00
|
|
|
httpMethod: string;
|
2023-12-19 10:26:20 +00:00
|
|
|
httpVersion: string;
|
2020-06-04 13:49:22 +00:00
|
|
|
path?: string;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2020-06-04 13:49:22 +00:00
|
|
|
body?: JSON | string | Record<string, any> | null;
|
2021-02-16 15:01:35 +00:00
|
|
|
encodeParamsToggle: boolean;
|
2020-06-04 13:49:22 +00:00
|
|
|
queryParameters?: Property[];
|
|
|
|
|
bodyFormData?: BodyFormData[];
|
feat: Support body in GET API requests (#7127)
* WIP
* Refactoring HTTP Method & Content Type to be objects instead of arrays
TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request
* Almost working implementation for the None type
Currently, the body still gets sent in non-GET requests even if the None tab is selected.
* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM
* WIP: Using enum & const for ts autocomplete
* working implementation for NONE type, apiContentType prop added to API actions
* WIP
* Refactoring HTTP Method & Content Type to be objects instead of arrays
TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request
* Almost working implementation for the None type
Currently, the body still gets sent in non-GET requests even if the None tab is selected.
* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM
* WIP: Using enum & const for ts autocomplete
* working implementation for NONE type, apiContentType prop added to API actions
* adds apiContentType to actionConfiguration.formData object
* Handling apiContentType property in Rest API formData
* change apiContentType when user types content-type value and switches http method
* makes api editor as similar as possible to postman, project postman.
* Correcting the import in ApiEditorConstants
* Resolved all merge conflicts
* replay DSL functtionality
* removes unneccessary files from worker
* Fixes type declarations, naming e.t.c.
* fix server side merge conflicts
* fix client side merge conflicts
* fix failing cypress tests
Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
|
|
|
formData: Record<string, unknown>;
|
2022-09-09 15:59:47 +00:00
|
|
|
query?: string | null;
|
|
|
|
|
variable?: string | null;
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export interface QueryActionConfig extends ActionConfig {
|
2021-01-12 04:17:28 +00:00
|
|
|
body?: string;
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2021-01-12 04:17:28 +00:00
|
|
|
export const isStoredDatasource = (val: any): val is StoredDatasource => {
|
|
|
|
|
if (!_.isObject(val)) return false;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2021-01-12 04:17:28 +00:00
|
|
|
if (!("id" in val)) return false;
|
2024-09-18 16:35:28 +00:00
|
|
|
|
2021-01-12 04:17:28 +00:00
|
|
|
return true;
|
|
|
|
|
};
|
|
|
|
|
export interface StoredDatasource {
|
2023-06-08 09:09:19 +00:00
|
|
|
name?: string;
|
2021-01-12 04:17:28 +00:00
|
|
|
id: string;
|
2022-10-13 20:28:46 +00:00
|
|
|
pluginId?: string;
|
2023-05-26 10:13:18 +00:00
|
|
|
datasourceConfiguration?: { url?: string };
|
2021-01-12 04:17:28 +00:00
|
|
|
}
|
|
|
|
|
|
2025-03-12 12:59:36 +00:00
|
|
|
export interface VisualizationElements {
|
|
|
|
|
css: string;
|
|
|
|
|
js: string;
|
|
|
|
|
html: string;
|
|
|
|
|
}
|
|
|
|
|
|
2021-09-08 17:32:22 +00:00
|
|
|
export interface BaseAction {
|
2020-06-04 13:49:22 +00:00
|
|
|
id: string;
|
2024-07-31 02:54:51 +00:00
|
|
|
baseId: string;
|
2020-06-04 13:49:22 +00:00
|
|
|
name: string;
|
2022-06-15 15:37:41 +00:00
|
|
|
workspaceId: string;
|
2024-07-31 02:54:51 +00:00
|
|
|
applicationId: string;
|
2020-06-04 13:49:22 +00:00
|
|
|
pageId: string;
|
|
|
|
|
collectionId?: string;
|
|
|
|
|
pluginId: string;
|
2025-04-24 10:07:11 +00:00
|
|
|
runBehavior: ActionRunBehaviourType;
|
2020-11-12 11:23:32 +00:00
|
|
|
dynamicBindingPathList: DynamicPath[];
|
2020-06-04 13:49:22 +00:00
|
|
|
isValid: boolean;
|
|
|
|
|
invalids: string[];
|
|
|
|
|
jsonPathKeys: string[];
|
|
|
|
|
cacheResponse: string;
|
2020-09-08 04:57:13 +00:00
|
|
|
confirmBeforeExecute?: boolean;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2021-01-12 04:17:28 +00:00
|
|
|
eventData?: any;
|
2021-12-16 12:40:38 +00:00
|
|
|
messages: string[];
|
2022-12-01 06:30:50 +00:00
|
|
|
userPermissions?: string[];
|
2022-09-24 10:01:52 +00:00
|
|
|
errorReports?: Array<LayoutOnLoadActionErrors>;
|
2023-11-06 11:02:56 +00:00
|
|
|
isPublic?: boolean;
|
2024-09-19 12:44:26 +00:00
|
|
|
packageId?: string;
|
2023-11-06 11:02:56 +00:00
|
|
|
moduleId?: string;
|
2023-11-22 09:32:44 +00:00
|
|
|
moduleInstanceId?: string;
|
2023-12-13 17:43:43 +00:00
|
|
|
workflowId?: string;
|
2023-12-26 06:08:00 +00:00
|
|
|
contextType?: ActionParentEntityTypeInterface;
|
2023-12-18 11:15:18 +00:00
|
|
|
// This is used to identify the main js collection of a workflow
|
|
|
|
|
// added here to avoid ts error in entitiesSelector file, in practice
|
|
|
|
|
// will always be undefined for non js actions
|
|
|
|
|
isMainJSCollection?: boolean;
|
2024-03-11 04:52:24 +00:00
|
|
|
source?: ActionCreationSourceTypeEnum;
|
2025-03-12 12:59:36 +00:00
|
|
|
visualization?: {
|
|
|
|
|
result: VisualizationElements;
|
|
|
|
|
};
|
2025-03-25 06:27:13 +00:00
|
|
|
isDirtyMap?: {
|
2025-03-24 08:38:43 +00:00
|
|
|
SCHEMA_GENERATION: boolean;
|
|
|
|
|
};
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
2021-01-12 04:17:28 +00:00
|
|
|
interface BaseApiAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.API;
|
|
|
|
|
actionConfiguration: ApiActionConfig;
|
|
|
|
|
}
|
2021-04-22 03:30:09 +00:00
|
|
|
export interface SaaSAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.SAAS;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2021-04-22 03:30:09 +00:00
|
|
|
actionConfiguration: any;
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
2021-09-21 12:05:29 +00:00
|
|
|
export interface RemoteAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.REMOTE;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2021-09-21 12:05:29 +00:00
|
|
|
actionConfiguration: any;
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
2023-11-03 04:20:34 +00:00
|
|
|
export interface AIAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.AI;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2023-11-03 04:20:34 +00:00
|
|
|
actionConfiguration: any;
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
2024-01-22 12:50:22 +00:00
|
|
|
export interface InternalAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.INTERNAL;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2024-01-22 12:50:22 +00:00
|
|
|
actionConfiguration: any;
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
2021-01-12 04:17:28 +00:00
|
|
|
|
|
|
|
|
export interface EmbeddedApiAction extends BaseApiAction {
|
|
|
|
|
datasource: EmbeddedRestDatasource;
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
|
|
|
|
|
2021-01-12 04:17:28 +00:00
|
|
|
export interface StoredDatasourceApiAction extends BaseApiAction {
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export type ApiAction = EmbeddedApiAction | StoredDatasourceApiAction;
|
|
|
|
|
|
|
|
|
|
export interface QueryAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.DB;
|
2022-08-09 13:05:59 +00:00
|
|
|
pluginName?: PluginName;
|
2021-01-12 04:17:28 +00:00
|
|
|
actionConfiguration: QueryActionConfig;
|
|
|
|
|
datasource: StoredDatasource;
|
2020-06-04 13:49:22 +00:00
|
|
|
}
|
2021-01-12 04:17:28 +00:00
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface ActionViewMode {
|
2021-01-26 03:12:52 +00:00
|
|
|
id: string;
|
2024-07-31 02:54:51 +00:00
|
|
|
baseId: string;
|
2021-01-26 03:12:52 +00:00
|
|
|
name: string;
|
|
|
|
|
pageId: string;
|
|
|
|
|
jsonPathKeys: string[];
|
|
|
|
|
confirmBeforeExecute?: boolean;
|
|
|
|
|
timeoutInMillisecond?: number;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2021-01-26 03:12:52 +00:00
|
|
|
|
2025-01-07 06:21:08 +00:00
|
|
|
export interface ExternalSaasAction extends BaseAction {
|
|
|
|
|
pluginType: PluginType.EXTERNAL_SAAS;
|
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
|
|
|
actionConfiguration: any;
|
|
|
|
|
datasource: StoredDatasource;
|
|
|
|
|
}
|
|
|
|
|
|
2023-11-03 04:20:34 +00:00
|
|
|
export type Action =
|
|
|
|
|
| ApiAction
|
|
|
|
|
| QueryAction
|
|
|
|
|
| SaaSAction
|
|
|
|
|
| RemoteAction
|
2024-01-22 12:50:22 +00:00
|
|
|
| AIAction
|
2025-01-07 06:21:08 +00:00
|
|
|
| InternalAction
|
|
|
|
|
| ExternalSaasAction;
|
2021-09-22 16:59:47 +00:00
|
|
|
|
|
|
|
|
export enum SlashCommand {
|
|
|
|
|
NEW_API,
|
|
|
|
|
NEW_QUERY,
|
|
|
|
|
NEW_INTEGRATION,
|
2023-04-20 15:12:35 +00:00
|
|
|
ASK_AI,
|
2021-09-22 16:59:47 +00:00
|
|
|
}
|
|
|
|
|
|
2023-10-11 07:35:24 +00:00
|
|
|
export interface SlashCommandPayload {
|
2021-09-22 16:59:47 +00:00
|
|
|
actionType: SlashCommand;
|
|
|
|
|
callback?: (binding: string) => void;
|
2024-07-31 15:41:28 +00:00
|
|
|
// TODO: Fix this the next time the file is edited
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
2021-09-22 16:59:47 +00:00
|
|
|
args: any;
|
2023-10-11 07:35:24 +00:00
|
|
|
}
|
2021-12-07 09:45:18 +00:00
|
|
|
|
|
|
|
|
export function isAPIAction(action: Action): action is ApiAction {
|
|
|
|
|
return action.pluginType === PluginType.API;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function isQueryAction(action: Action): action is QueryAction {
|
|
|
|
|
return action.pluginType === PluginType.DB;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function isSaaSAction(action: Action): action is SaaSAction {
|
|
|
|
|
return action.pluginType === PluginType.SAAS;
|
|
|
|
|
}
|
2022-09-09 15:59:47 +00:00
|
|
|
|
2024-05-14 16:10:59 +00:00
|
|
|
export function isAIAction(action: Action): action is AIAction {
|
2024-01-16 14:49:08 +00:00
|
|
|
return action.pluginType === PluginType.AI;
|
|
|
|
|
}
|
|
|
|
|
|
2022-09-09 15:59:47 +00:00
|
|
|
export function getGraphQLPlugin(plugins: Plugin[]): Plugin | undefined {
|
2022-10-17 15:16:38 +00:00
|
|
|
return plugins.find((p) => p.packageName === PluginPackageName.GRAPHQL);
|
2022-09-09 15:59:47 +00:00
|
|
|
}
|
|
|
|
|
|
2024-01-16 14:49:08 +00:00
|
|
|
export function getAppsmithAIPlugin(plugins: Plugin[]): Plugin | undefined {
|
|
|
|
|
return plugins.find((p) => p.packageName === PluginPackageName.APPSMITH_AI);
|
|
|
|
|
}
|
|
|
|
|
|
2022-09-09 15:59:47 +00:00
|
|
|
export function isGraphqlPlugin(plugin: Plugin | undefined) {
|
2022-10-17 15:16:38 +00:00
|
|
|
return plugin?.packageName === PluginPackageName.GRAPHQL;
|
2022-09-09 15:59:47 +00:00
|
|
|
}
|
2023-07-27 13:00:23 +00:00
|
|
|
|
2023-12-19 10:26:20 +00:00
|
|
|
export function isRESTAPIPlugin(plugin: Plugin | undefined) {
|
|
|
|
|
return plugin?.packageName === PluginPackageName.REST_API;
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-27 13:00:23 +00:00
|
|
|
export const SCHEMA_SECTION_ID = "t--api-right-pane-schema";
|
2023-10-27 06:36:57 +00:00
|
|
|
|
|
|
|
|
export interface CreateApiActionDefaultsParams {
|
|
|
|
|
apiType: string;
|
|
|
|
|
from?: EventLocation;
|
2024-01-17 10:04:50 +00:00
|
|
|
newActionName?: string;
|
2023-10-27 06:36:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export interface CreateActionDefaultsParams {
|
|
|
|
|
datasourceId: string;
|
|
|
|
|
from?: EventLocation;
|
2024-01-17 10:04:50 +00:00
|
|
|
newActionName?: string;
|
feat: query should be populated based on table selected on datasource… (#30306)
## Description
We have a datasource preview and generate crud functionality implemented
on datasource review page. This functionality has been rolled out to all
100% of the users. This PR introduces an enhancement for that
functionality.
Whenever we are previewing datasource and have selected a particular
table from schema, and now when we create a new query, this query will
be constructed based on the table name we had selected. For eg, if
schema is showing 5 tables i.e table1, table2, table3, table4, table5,
and if we are previewing table3, and I click on new query CTA, it will
take me to query editor and the query body will have something like:
`select * from public.table3 limit 10`.
#### PR fixes following issue(s)
Fixes #29600
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- New feature (non-breaking change which adds functionality)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced the ability to select and remember a specific table during
data source preview.
- Enhanced query creation with the option to pre-select a default table.
- **Improvements**
- Updated components and sagas to handle the selection of a default
table when creating new queries.
- **Bug Fixes**
- Ensured consistent default table selection across the app when
interacting with data sources and queries.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-01-22 12:13:07 +00:00
|
|
|
queryDefaultTableName?: string;
|
2023-10-27 06:36:57 +00:00
|
|
|
}
|