2021-12-23 14:17:20 +00:00
|
|
|
import {
|
|
|
|
|
createMessage,
|
|
|
|
|
TRIGGER_ACTION_VALIDATION_ERROR,
|
2022-02-11 18:08:46 +00:00
|
|
|
} from "@appsmith/constants/messages";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ApiResponse } from "api/ApiResponses";
|
2021-10-14 11:04:43 +00:00
|
|
|
import { isString } from "lodash";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { Types } from "utils/TypeHelpers";
|
|
|
|
|
import type { ActionTriggerKeys } from "@appsmith/workers/Evaluation/fns/index";
|
|
|
|
|
import { getActionTriggerFunctionNames } from "@appsmith/workers/Evaluation/fns/index";
|
2023-02-20 11:56:40 +00:00
|
|
|
import { getAppsmithConfigs } from "@appsmith/configs";
|
2023-05-19 18:37:06 +00:00
|
|
|
import { toast } from "design-system";
|
|
|
|
|
import { getAppMode } from "@appsmith/selectors/applicationSelectors";
|
|
|
|
|
import AnalyticsUtil from "../../utils/AnalyticsUtil";
|
|
|
|
|
import {
|
|
|
|
|
setDebuggerSelectedTab,
|
|
|
|
|
showDebugger,
|
|
|
|
|
} from "../../actions/debuggerActions";
|
|
|
|
|
import { DEBUGGER_TAB_KEYS } from "../../components/editorComponents/Debugger/helpers";
|
|
|
|
|
import store from "store";
|
2023-02-20 11:56:40 +00:00
|
|
|
|
|
|
|
|
const APPSMITH_CONFIGS = getAppsmithConfigs();
|
2021-09-23 07:21:57 +00:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The base trigger error that also logs the errors in the debugger.
|
|
|
|
|
* Extend this error to make custom handling of errors
|
|
|
|
|
*/
|
|
|
|
|
export class TriggerFailureError extends Error {
|
|
|
|
|
error?: Error;
|
|
|
|
|
|
2021-12-23 14:17:20 +00:00
|
|
|
constructor(reason: string, error?: Error) {
|
2021-09-23 07:21:57 +00:00
|
|
|
super(reason);
|
|
|
|
|
this.error = error;
|
2021-12-23 14:17:20 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export class PluginTriggerFailureError extends TriggerFailureError {
|
|
|
|
|
responseData: unknown[] = [];
|
|
|
|
|
|
|
|
|
|
constructor(reason: string, responseData: unknown[]) {
|
|
|
|
|
super(reason);
|
|
|
|
|
this.responseData = responseData;
|
|
|
|
|
}
|
|
|
|
|
}
|
2021-09-23 07:21:57 +00:00
|
|
|
|
2021-12-23 14:17:20 +00:00
|
|
|
export class ActionValidationError extends TriggerFailureError {
|
|
|
|
|
constructor(
|
2023-01-06 12:02:08 +00:00
|
|
|
functionName: ActionTriggerKeys,
|
2021-12-23 14:17:20 +00:00
|
|
|
argumentName: string,
|
|
|
|
|
expectedType: Types,
|
|
|
|
|
received: Types,
|
|
|
|
|
) {
|
|
|
|
|
const errorMessage = createMessage(
|
|
|
|
|
TRIGGER_ACTION_VALIDATION_ERROR,
|
2023-02-20 11:56:40 +00:00
|
|
|
getActionTriggerFunctionNames(!!APPSMITH_CONFIGS.cloudHosting)[
|
|
|
|
|
functionName
|
|
|
|
|
],
|
2021-12-23 14:17:20 +00:00
|
|
|
argumentName,
|
|
|
|
|
expectedType,
|
|
|
|
|
received,
|
|
|
|
|
);
|
|
|
|
|
super(errorMessage);
|
2021-09-23 07:21:57 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export const logActionExecutionError = (
|
|
|
|
|
errorMessage: string,
|
2023-04-27 08:50:23 +00:00
|
|
|
isExecuteJSFunc = true,
|
2021-09-23 07:21:57 +00:00
|
|
|
) => {
|
2023-02-18 12:55:46 +00:00
|
|
|
//Commenting as per decision taken for the error hanlding epic to not show the trigger errors in the debugger.
|
|
|
|
|
// if (triggerPropertyName) {
|
|
|
|
|
// AppsmithConsole.addErrors([
|
|
|
|
|
// {
|
|
|
|
|
// payload: {
|
|
|
|
|
// id: `${source?.id}-${triggerPropertyName}`,
|
|
|
|
|
// logType: LOG_TYPE.TRIGGER_EVAL_ERROR,
|
|
|
|
|
// text: createMessage(DEBUGGER_TRIGGER_ERROR, triggerPropertyName),
|
|
|
|
|
// source: {
|
|
|
|
|
// type: ENTITY_TYPE.WIDGET,
|
|
|
|
|
// id: source?.id ?? "",
|
|
|
|
|
// name: source?.name ?? "",
|
|
|
|
|
// propertyPath: triggerPropertyName,
|
|
|
|
|
// },
|
|
|
|
|
// messages: [
|
|
|
|
|
// {
|
|
|
|
|
// type: errorType,
|
|
|
|
|
// message: { name: "TriggerExecutionError", message: errorMessage },
|
|
|
|
|
// },
|
|
|
|
|
// ],
|
|
|
|
|
// },
|
|
|
|
|
// },
|
|
|
|
|
// ]);
|
|
|
|
|
// }
|
2023-05-19 18:37:06 +00:00
|
|
|
|
|
|
|
|
function onDebugClick() {
|
|
|
|
|
const appMode = getAppMode(store.getState());
|
|
|
|
|
if (appMode === "PUBLISHED") return null;
|
|
|
|
|
|
|
|
|
|
AnalyticsUtil.logEvent("OPEN_DEBUGGER", {
|
|
|
|
|
source: "TOAST",
|
|
|
|
|
});
|
|
|
|
|
store.dispatch(showDebugger(true));
|
|
|
|
|
store.dispatch(setDebuggerSelectedTab(DEBUGGER_TAB_KEYS.ERROR_TAB));
|
|
|
|
|
}
|
|
|
|
|
|
2023-04-27 08:50:23 +00:00
|
|
|
isExecuteJSFunc &&
|
2023-05-19 18:37:06 +00:00
|
|
|
toast.show(errorMessage, {
|
|
|
|
|
kind: "error",
|
|
|
|
|
action: {
|
|
|
|
|
text: "debug",
|
|
|
|
|
effect: () => onDebugClick(),
|
|
|
|
|
className: "t--toast-debug-button",
|
2022-10-13 20:13:44 +00:00
|
|
|
},
|
2023-04-27 08:50:23 +00:00
|
|
|
});
|
2021-09-23 07:21:57 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Thrown when action execution fails for some reason
|
|
|
|
|
* */
|
|
|
|
|
export class PluginActionExecutionError extends Error {
|
|
|
|
|
response?: ApiResponse;
|
|
|
|
|
userCancelled: boolean;
|
|
|
|
|
|
|
|
|
|
constructor(message: string, userCancelled: boolean, response?: ApiResponse) {
|
|
|
|
|
super(message);
|
|
|
|
|
this.name = "PluginActionExecutionError";
|
|
|
|
|
this.userCancelled = userCancelled;
|
|
|
|
|
this.response = response;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The user cancelled the run of this action in a confirmation modal.
|
|
|
|
|
* This modal is shown if an action has a confirmation setting enabled.
|
|
|
|
|
* If they cancel, bail, dont show errors and dont run anything further
|
|
|
|
|
*/
|
|
|
|
|
export class UserCancelledActionExecutionError extends PluginActionExecutionError {
|
|
|
|
|
constructor() {
|
|
|
|
|
super("User cancelled action execution", true);
|
|
|
|
|
this.name = "UserCancelledActionExecutionError";
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2021-10-14 11:04:43 +00:00
|
|
|
export const getErrorAsString = (error: unknown): string => {
|
|
|
|
|
return isString(error) ? error : JSON.stringify(error);
|
|
|
|
|
};
|