2022-11-03 09:23:15 +00:00
|
|
|
import { setLintingErrors } from "actions/lintingActions";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
|
|
|
import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
|
2022-11-03 09:23:15 +00:00
|
|
|
import { APP_MODE } from "entities/App";
|
2022-12-21 17:14:47 +00:00
|
|
|
import { call, put, select, takeEvery } from "redux-saga/effects";
|
2023-09-12 11:51:39 +00:00
|
|
|
import { getAppMode } from "@appsmith/selectors/entitiesSelector";
|
2023-10-20 05:38:47 +00:00
|
|
|
import type { JSLibrary } from "workers/common/JSLibrary";
|
2022-11-03 09:23:15 +00:00
|
|
|
import { logLatestLintPropertyErrors } from "./PostLintingSagas";
|
2023-02-20 11:56:40 +00:00
|
|
|
import { getAppsmithConfigs } from "@appsmith/configs";
|
2023-04-03 10:41:15 +00:00
|
|
|
import type { AppState } from "@appsmith/reducers";
|
|
|
|
|
import type { LintError } from "utils/DynamicBindingUtils";
|
2023-07-05 13:34:03 +00:00
|
|
|
import { get, set, uniq } from "lodash";
|
2023-04-03 10:41:15 +00:00
|
|
|
import type { LintErrorsStore } from "reducers/lintingReducers/lintErrorsReducers";
|
|
|
|
|
import type { TJSPropertiesState } from "workers/Evaluation/JSObject/jsPropertiesState";
|
2023-07-05 13:34:03 +00:00
|
|
|
import type {
|
|
|
|
|
LintTreeRequestPayload,
|
|
|
|
|
LintTreeResponse,
|
|
|
|
|
LintTreeSagaRequestData,
|
|
|
|
|
} from "plugins/Linting/types";
|
|
|
|
|
import type { getUnevaluatedDataTree } from "selectors/dataTreeSelectors";
|
|
|
|
|
import { getEntityNameAndPropertyPath } from "@appsmith/workers/Evaluation/evaluationUtils";
|
|
|
|
|
import { Linter } from "plugins/Linting/Linter";
|
|
|
|
|
import log from "loglevel";
|
|
|
|
|
import { getFixedTimeDifference } from "workers/common/DataTreeEvaluator/utils";
|
2023-10-12 17:32:38 +00:00
|
|
|
import { selectFeatureFlags } from "@appsmith/selectors/featureFlagsSelectors";
|
2023-02-20 11:56:40 +00:00
|
|
|
|
|
|
|
|
const APPSMITH_CONFIGS = getAppsmithConfigs();
|
2022-11-03 09:23:15 +00:00
|
|
|
|
2024-01-04 09:56:18 +00:00
|
|
|
export const lintWorker = new Linter();
|
2022-11-03 09:23:15 +00:00
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
function* updateLintGlobals(
|
2023-10-20 05:38:47 +00:00
|
|
|
action: ReduxAction<{ add?: boolean; libs: JSLibrary[] }>,
|
2023-07-05 13:34:03 +00:00
|
|
|
) {
|
2022-12-21 17:14:47 +00:00
|
|
|
const appMode: APP_MODE = yield select(getAppMode);
|
|
|
|
|
const isEditorMode = appMode === APP_MODE.EDIT;
|
|
|
|
|
if (!isEditorMode) return;
|
2023-07-05 13:34:03 +00:00
|
|
|
yield call(lintWorker.updateJSLibraryGlobals, action.payload);
|
2022-12-21 17:14:47 +00:00
|
|
|
}
|
|
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
function* updateOldJSCollectionLintErrors(
|
|
|
|
|
lintedJSPaths: string[],
|
2023-04-03 10:41:15 +00:00
|
|
|
errors: LintErrorsStore,
|
|
|
|
|
jsObjectsState: TJSPropertiesState,
|
|
|
|
|
) {
|
2023-07-05 13:34:03 +00:00
|
|
|
const jsEntities = uniq(
|
|
|
|
|
lintedJSPaths.map((path) => getEntityNameAndPropertyPath(path).entityName),
|
|
|
|
|
);
|
2023-04-03 10:41:15 +00:00
|
|
|
const updatedJSCollectionLintErrors: LintErrorsStore = {};
|
|
|
|
|
for (const jsObjectName of jsEntities) {
|
|
|
|
|
const jsObjectBodyPath = `["${jsObjectName}.body"]`;
|
|
|
|
|
const oldJsBodyLintErrors: LintError[] = yield select((state: AppState) =>
|
|
|
|
|
get(state.linting.errors, jsObjectBodyPath, []),
|
|
|
|
|
);
|
|
|
|
|
const newJSBodyLintErrors = get(
|
|
|
|
|
errors,
|
|
|
|
|
jsObjectBodyPath,
|
|
|
|
|
[] as LintError[],
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const jsObjectState = get(jsObjectsState, jsObjectName, {});
|
2023-07-05 13:34:03 +00:00
|
|
|
const jsObjectProperties = Object.keys(jsObjectState).map(
|
|
|
|
|
(propertyName) => `${jsObjectName}.${propertyName}`,
|
|
|
|
|
);
|
2023-04-03 10:41:15 +00:00
|
|
|
|
|
|
|
|
const filteredOldJsObjectBodyLintErrors = oldJsBodyLintErrors.filter(
|
|
|
|
|
(lintError) =>
|
|
|
|
|
lintError.originalPath &&
|
2023-07-05 13:34:03 +00:00
|
|
|
jsObjectProperties.includes(lintError.originalPath) &&
|
|
|
|
|
!lintedJSPaths.includes(lintError.originalPath),
|
2023-04-03 10:41:15 +00:00
|
|
|
);
|
|
|
|
|
const updatedLintErrors = [
|
|
|
|
|
...filteredOldJsObjectBodyLintErrors,
|
|
|
|
|
...newJSBodyLintErrors,
|
|
|
|
|
];
|
|
|
|
|
set(updatedJSCollectionLintErrors, jsObjectBodyPath, updatedLintErrors);
|
|
|
|
|
}
|
|
|
|
|
return updatedJSCollectionLintErrors;
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
export function* lintTreeSaga(payload: LintTreeSagaRequestData) {
|
|
|
|
|
const { configTree, forceLinting, unevalTree } = payload;
|
2022-11-03 09:23:15 +00:00
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
const lintTreeRequestData: LintTreeRequestPayload = {
|
2022-12-02 12:45:11 +00:00
|
|
|
unevalTree,
|
2023-03-20 11:04:02 +00:00
|
|
|
configTree,
|
2023-02-20 11:56:40 +00:00
|
|
|
cloudHosting: !!APPSMITH_CONFIGS.cloudHosting,
|
2023-07-05 13:34:03 +00:00
|
|
|
forceLinting,
|
2022-11-03 09:23:15 +00:00
|
|
|
};
|
|
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
const { errors, jsPropertiesState, lintedJSPaths }: LintTreeResponse =
|
|
|
|
|
yield call(lintWorker.lintTree, lintTreeRequestData);
|
2022-11-03 09:23:15 +00:00
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
const updatedOldJSCollectionLintErrors: LintErrorsStore =
|
|
|
|
|
yield updateOldJSCollectionLintErrors(
|
|
|
|
|
lintedJSPaths,
|
2023-04-03 10:41:15 +00:00
|
|
|
errors,
|
|
|
|
|
jsPropertiesState,
|
|
|
|
|
);
|
|
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
const updatedErrors = { ...errors, ...updatedOldJSCollectionLintErrors };
|
2023-04-03 10:41:15 +00:00
|
|
|
|
|
|
|
|
yield put(setLintingErrors(updatedErrors));
|
|
|
|
|
yield call(logLatestLintPropertyErrors, {
|
|
|
|
|
errors,
|
|
|
|
|
dataTree: unevalTree,
|
|
|
|
|
});
|
2022-11-03 09:23:15 +00:00
|
|
|
}
|
2022-12-21 17:14:47 +00:00
|
|
|
|
2023-07-05 13:34:03 +00:00
|
|
|
export function* initiateLinting(
|
|
|
|
|
unEvalAndConfigTree: ReturnType<typeof getUnevaluatedDataTree>,
|
|
|
|
|
forceLinting: boolean,
|
|
|
|
|
) {
|
|
|
|
|
const lintingStartTime = performance.now();
|
|
|
|
|
const { configTree, unEvalTree: unevalTree } = unEvalAndConfigTree;
|
|
|
|
|
|
|
|
|
|
yield call(lintTreeSaga, {
|
|
|
|
|
unevalTree,
|
|
|
|
|
configTree,
|
|
|
|
|
forceLinting,
|
|
|
|
|
});
|
|
|
|
|
log.debug({
|
|
|
|
|
lintTime: getFixedTimeDifference(performance.now(), lintingStartTime),
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
2022-12-21 17:14:47 +00:00
|
|
|
export default function* lintTreeSagaWatcher() {
|
|
|
|
|
yield takeEvery(ReduxActionTypes.UPDATE_LINT_GLOBALS, updateLintGlobals);
|
2023-10-12 17:32:38 +00:00
|
|
|
yield takeEvery(ReduxActionTypes.START_EVALUATION, setupSaga);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
export function* setupSaga(): any {
|
|
|
|
|
const featureFlags = yield select(selectFeatureFlags);
|
|
|
|
|
yield call(lintWorker.setup, featureFlags);
|
2022-12-21 17:14:47 +00:00
|
|
|
}
|