2022-04-11 03:30:37 +00:00
/* eslint-disable cypress/no-unnecessary-waiting */
/* eslint-disable cypress/no-assigning-return-values */
2022-06-15 15:37:41 +00:00
/* Contains all methods related to Workspace features*/
2022-04-11 03:30:37 +00:00
2024-01-12 14:43:58 +00:00
import { AppSidebar } from "./Pages/EditorNavigation" ;
2022-04-11 03:30:37 +00:00
require ( "cy-verify-downloads" ) . addCustomCommand ( ) ;
require ( "cypress-file-upload" ) ;
import homePage from "../locators/HomePage" ;
2023-06-15 13:21:11 +00:00
import { ObjectsRegistry } from "../support/Objects/Registry" ;
const agHelper = ObjectsRegistry . AggregateHelper ;
2023-06-27 08:20:54 +00:00
const assertHelper = ObjectsRegistry . AssertHelper ;
2023-09-25 14:32:54 +00:00
const homePageTS = ObjectsRegistry . HomePage ;
2025-01-29 08:22:20 +00:00
const appSettings = ObjectsRegistry . AppSettings ;
2023-06-15 13:21:11 +00:00
2022-04-11 03:30:37 +00:00
export const initLocalstorage = ( ) => {
cy . window ( ) . then ( ( window ) => {
window . localStorage . setItem ( "ShowCommentsButtonToolTip" , "" ) ;
window . localStorage . setItem ( "updateDismissed" , "true" ) ;
} ) ;
} ;
2022-06-15 15:37:41 +00:00
Cypress . Commands . add ( "createWorkspace" , ( ) => {
cy . get ( homePage . createWorkspace )
2022-04-11 03:30:37 +00:00
. should ( "be.visible" )
. first ( )
. click ( { force : true } ) ;
} ) ;
2022-06-15 15:37:41 +00:00
Cypress . Commands . add ( "openWorkspaceOptionsPopup" , ( workspaceName ) => {
cy . get ( homePage . workspaceList . concat ( workspaceName ) . concat ( ")" ) )
2023-02-22 07:02:43 +00:00
. first ( )
2023-02-24 17:11:25 +00:00
. scrollIntoView ( )
. should ( "be.visible" ) ;
2023-02-22 07:02:43 +00:00
2022-06-15 15:37:41 +00:00
cy . get ( homePage . workspaceList . concat ( workspaceName ) . concat ( ")" ) )
. closest ( homePage . workspaceCompleteSection )
2022-04-11 03:30:37 +00:00
. find ( homePage . optionsIcon )
2023-05-19 18:37:06 +00:00
. first ( )
2022-04-11 03:30:37 +00:00
. click ( { force : true } ) ;
} ) ;
2022-12-26 05:11:33 +00:00
Cypress . Commands . add ( "enablePublicAccess" , ( editMode = false ) => {
2023-05-19 18:37:06 +00:00
cy . xpath ( homePage . enablePublicAccess ) . first ( ) . click ( { force : true } ) ;
2022-04-11 03:30:37 +00:00
cy . wait ( "@changeAccess" ) . should (
"have.nested.property" ,
"response.body.responseMeta.status" ,
200 ,
) ;
2023-05-19 18:37:06 +00:00
cy . wait ( 5000 ) ;
2022-12-26 05:11:33 +00:00
const closeButtonLocator = editMode
? homePage . editModeInviteModalCloseBtn
: homePage . closeBtn ;
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
cy . get ( closeButtonLocator ) . first ( ) . click ( { force : true } ) ;
2022-04-11 03:30:37 +00:00
} ) ;
Cypress . Commands . add ( "launchApp" , ( ) => {
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
cy . get ( homePage . appView ) . should ( "be.visible" ) . first ( ) . click ( ) ;
2022-04-11 03:30:37 +00:00
cy . get ( "#loading" ) . should ( "not.exist" ) ;
2024-01-24 06:44:16 +00:00
cy . wait ( "@getConsolidatedData" ) . should (
2022-04-11 03:30:37 +00:00
"have.nested.property" ,
"response.body.responseMeta.status" ,
200 ,
) ;
2025-01-29 08:22:20 +00:00
agHelper . AssertElementVisibility ( appSettings . locators . _applicationName ) ;
2022-04-11 03:30:37 +00:00
} ) ;
Cypress . Commands . add ( "AppSetupForRename" , ( ) => {
2023-09-25 14:32:54 +00:00
cy . wait ( 2000 ) ; //wait a bit for app to load
2022-04-11 03:30:37 +00:00
cy . get ( homePage . applicationName ) . then ( ( $appName ) => {
if ( ! $appName . hasClass ( homePage . editingAppName ) ) {
cy . get ( homePage . applicationName ) . click ( { force : true } ) ;
cy . get ( homePage . portalMenuItem )
2023-11-30 00:41:59 +00:00
. contains ( "Rename" , { matchCase : false } )
2022-04-11 03:30:37 +00:00
. click ( { force : true } ) ;
}
} ) ;
} ) ;
2022-06-15 15:37:41 +00:00
Cypress . Commands . add ( "CreateAppForWorkspace" , ( workspaceName , appname ) => {
cy . get (
homePage . workspaceList
. concat ( workspaceName )
. concat ( homePage . createAppFrWorkspace ) ,
)
2024-01-25 13:41:48 +00:00
. first ( )
2022-04-11 03:30:37 +00:00
. scrollIntoView ( )
. should ( "be.visible" )
. click ( { force : true } ) ;
2024-01-25 13:41:48 +00:00
agHelper . GetNClick ( homePage . newButtonCreateApplication , 0 , true ) ;
2022-04-11 03:30:37 +00:00
cy . wait ( "@createNewApplication" ) . then ( ( xhr ) => {
const response = xhr . response ;
expect ( response . body . responseMeta . status ) . to . eq ( 201 ) ;
localStorage . setItem ( "applicationId" , response . body . data . id ) ;
cy . wrap ( response . body . data . id ) . as ( "currentApplicationId" ) ;
} ) ;
cy . get ( "#loading" ) . should ( "not.exist" ) ;
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy . wait ( 2000 ) ;
2024-02-01 11:12:53 +00:00
homePageTS . RenameApplication ( appname ) ;
2022-04-11 03:30:37 +00:00
} ) ;
2023-10-25 14:03:07 +00:00
Cypress . Commands . add ( "CreateNewAppInNewWorkspace" , ( ) => {
2023-09-25 14:32:54 +00:00
let applicationId , appName ;
2023-10-25 14:03:07 +00:00
let toNavigateToHome = false ;
cy . get ( "body" ) . then ( ( $ele ) => {
if ( $ele . find ( ".t--appsmith-logo" ) . length < 0 ) {
toNavigateToHome = false ;
} else {
toNavigateToHome = true ;
}
} ) ;
homePageTS . CreateNewWorkspace ( "" , toNavigateToHome ) ; //Creating a new workspace for every test, since we are deleting the workspace in the end of the test
cy . get ( "@workspaceName" ) . then ( ( workspaceName ) => {
localStorage . setItem ( "workspaceName" , workspaceName ) ;
homePageTS . CreateAppInWorkspace ( localStorage . getItem ( "workspaceName" ) ) ;
} ) ;
cy . get ( "@createNewApplication" ) . then ( ( xhr ) => {
2022-04-11 03:30:37 +00:00
const response = xhr . response ;
expect ( response . body . responseMeta . status ) . to . eq ( 201 ) ;
applicationId = response . body . data . id ;
2023-09-25 14:32:54 +00:00
appName = response . body . data . name ;
cy . log ( "appName" , appName ) ;
2022-04-11 03:30:37 +00:00
localStorage . setItem ( "applicationId" , applicationId ) ;
2023-10-20 02:15:47 +00:00
localStorage . setItem ( "appName" , appName ) ;
2024-01-05 06:12:03 +00:00
agHelper . AssertElementAbsence ( "#loading" , Cypress . config ( ) . pageLoadTimeout ) ;
2023-09-25 14:32:54 +00:00
cy . url ( ) . then ( ( url ) => {
if ( url . indexOf ( "/applications" ) > - 1 ) {
homePageTS . EditAppFromAppHover ( appName ) ;
}
} ) ;
2022-04-11 03:30:37 +00:00
} ) ;
2024-01-12 14:43:58 +00:00
AppSidebar . assertVisible ( ) ;
2023-06-15 13:21:11 +00:00
2023-10-25 14:03:07 +00:00
// If the intro modal is open, close it
2023-05-02 09:52:05 +00:00
cy . skipSignposting ( ) ;
2023-10-20 02:15:47 +00:00
//Removing renaming of app from all tests, since its also verified in other separate tests
// cy.AppSetupForRename();
// cy.get(homePage.applicationName).type(appname + "{enter}");
// assertHelper.AssertNetworkStatus("@updateApplication");
// // Remove tooltip on the Application Name
2023-10-25 14:03:07 +00:00
// agHelper.RemoveTooltip("Tooltip","Rename application");
2022-04-11 03:30:37 +00:00
/ * T h e s e r v e r c r e a t e d a p p a l w a y s h a s a n o l d d s l s o t h e l a y o u t w i l l m i g r a t e
* To avoid race conditions between that update layout and this one
* we wait for that to finish before updating layout here
* /
2023-06-15 13:21:11 +00:00
//cy.wait("@updateLayout");
2022-04-11 03:30:37 +00:00
} ) ;