chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { PropertyPaneConfig } from "constants/PropertyControlConstants";
|
|
|
|
|
import type React from "react";
|
|
|
|
|
import type {
|
|
|
|
|
WidgetBuilder,
|
|
|
|
|
WidgetProps,
|
|
|
|
|
WidgetState,
|
|
|
|
|
} from "widgets/BaseWidget";
|
2022-04-22 09:44:22 +00:00
|
|
|
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { RenderMode } from "constants/WidgetConstants";
|
|
|
|
|
import type { Stylesheet } from "entities/AppTheming";
|
2021-11-05 05:49:19 +00:00
|
|
|
import * as log from "loglevel";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { WidgetConfigProps } from "reducers/entityReducers/widgetConfigReducer";
|
2023-04-07 13:51:35 +00:00
|
|
|
import type {
|
2023-04-14 06:27:49 +00:00
|
|
|
AutocompletionDefinitions,
|
2023-04-07 13:51:35 +00:00
|
|
|
AutoLayoutConfig,
|
|
|
|
|
CanvasWidgetStructure,
|
2023-06-01 17:26:05 +00:00
|
|
|
WidgetMethods,
|
2023-04-07 13:51:35 +00:00
|
|
|
} from "widgets/constants";
|
2022-04-22 09:44:22 +00:00
|
|
|
import {
|
|
|
|
|
addPropertyConfigIds,
|
2023-03-04 07:25:54 +00:00
|
|
|
addSearchConfigToPanelConfig,
|
2022-04-22 09:44:22 +00:00
|
|
|
convertFunctionsToString,
|
|
|
|
|
enhancePropertyPaneConfig,
|
2022-12-11 14:42:32 +00:00
|
|
|
generatePropertyPaneSearchConfig,
|
2022-11-23 09:48:23 +00:00
|
|
|
PropertyPaneConfigTypes,
|
2022-04-22 09:44:22 +00:00
|
|
|
} from "./WidgetFactoryHelpers";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { WidgetFeatures } from "./WidgetFeatures";
|
2023-04-07 13:51:35 +00:00
|
|
|
import { FILL_WIDGET_MIN_WIDTH } from "constants/minWidthConstants";
|
2019-02-10 13:06:05 +00:00
|
|
|
|
2020-01-17 09:28:26 +00:00
|
|
|
type WidgetDerivedPropertyType = any;
|
|
|
|
|
export type DerivedPropertiesMap = Record<string, string>;
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
export type WidgetType = (typeof WidgetFactory.widgetTypes)[number];
|
2021-09-09 15:10:22 +00:00
|
|
|
|
2022-11-23 09:48:23 +00:00
|
|
|
export enum NonSerialisableWidgetConfigs {
|
|
|
|
|
CANVAS_HEIGHT_OFFSET = "canvasHeightOffset",
|
|
|
|
|
}
|
2019-02-10 13:06:05 +00:00
|
|
|
class WidgetFactory {
|
2021-09-09 15:10:22 +00:00
|
|
|
static widgetTypes: Record<string, string> = {};
|
2020-04-13 08:24:13 +00:00
|
|
|
static widgetMap: Map<
|
|
|
|
|
WidgetType,
|
2022-08-19 10:10:36 +00:00
|
|
|
WidgetBuilder<CanvasWidgetStructure, WidgetState>
|
2020-04-13 08:24:13 +00:00
|
|
|
> = new Map();
|
2020-01-17 09:28:26 +00:00
|
|
|
static widgetDerivedPropertiesGetterMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
WidgetDerivedPropertyType
|
|
|
|
|
> = new Map();
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
static derivedPropertiesMap: Map<WidgetType, DerivedPropertiesMap> =
|
|
|
|
|
new Map();
|
|
|
|
|
static defaultPropertiesMap: Map<WidgetType, Record<string, string>> =
|
|
|
|
|
new Map();
|
2020-04-17 16:15:09 +00:00
|
|
|
static metaPropertiesMap: Map<WidgetType, Record<string, any>> = new Map();
|
2021-02-16 10:29:08 +00:00
|
|
|
static propertyPaneConfigsMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
readonly PropertyPaneConfig[]
|
|
|
|
|
> = new Map();
|
2022-08-04 05:31:05 +00:00
|
|
|
static propertyPaneContentConfigsMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
readonly PropertyPaneConfig[]
|
|
|
|
|
> = new Map();
|
|
|
|
|
static propertyPaneStyleConfigsMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
readonly PropertyPaneConfig[]
|
|
|
|
|
> = new Map();
|
2022-12-11 14:42:32 +00:00
|
|
|
// used to store the properties that appear in the search results
|
|
|
|
|
static propertyPaneSearchConfigsMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
readonly PropertyPaneConfig[]
|
|
|
|
|
> = new Map();
|
2022-09-13 05:40:08 +00:00
|
|
|
static loadingProperties: Map<WidgetType, Array<RegExp>> = new Map();
|
2022-11-28 04:44:31 +00:00
|
|
|
static stylesheetConfigMap: Map<WidgetType, Stylesheet> = new Map();
|
2023-04-14 06:27:49 +00:00
|
|
|
static autocompleteDefinitions: Map<WidgetType, AutocompletionDefinitions> =
|
|
|
|
|
new Map();
|
2019-09-09 09:08:54 +00:00
|
|
|
|
2021-09-09 15:10:22 +00:00
|
|
|
static widgetConfigMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
Partial<WidgetProps> & WidgetConfigProps & { type: string }
|
|
|
|
|
> = new Map();
|
|
|
|
|
|
2022-11-23 09:48:23 +00:00
|
|
|
static nonSerialisableWidgetConfigMap: Map<
|
|
|
|
|
WidgetType,
|
|
|
|
|
Record<NonSerialisableWidgetConfigs, unknown>
|
|
|
|
|
> = new Map();
|
|
|
|
|
|
2023-04-07 13:51:35 +00:00
|
|
|
static autoLayoutConfigMap: Map<WidgetType, AutoLayoutConfig> = new Map();
|
|
|
|
|
|
2023-06-01 17:26:05 +00:00
|
|
|
static widgetMethodsMap: Map<WidgetType, Record<string, any>> = new Map();
|
|
|
|
|
|
2019-09-09 09:08:54 +00:00
|
|
|
static registerWidgetBuilder(
|
2021-09-09 15:10:22 +00:00
|
|
|
widgetType: string,
|
2020-04-13 08:24:13 +00:00
|
|
|
widgetBuilder: WidgetBuilder<WidgetProps, WidgetState>,
|
2020-01-17 09:28:26 +00:00
|
|
|
derivedPropertiesMap: DerivedPropertiesMap,
|
2020-04-17 16:15:09 +00:00
|
|
|
defaultPropertiesMap: Record<string, string>,
|
|
|
|
|
metaPropertiesMap: Record<string, any>,
|
2021-02-16 10:29:08 +00:00
|
|
|
propertyPaneConfig?: PropertyPaneConfig[],
|
2022-08-04 05:31:05 +00:00
|
|
|
propertyPaneContentConfig?: PropertyPaneConfig[],
|
|
|
|
|
propertyPaneStyleConfig?: PropertyPaneConfig[],
|
2022-04-22 09:44:22 +00:00
|
|
|
features?: WidgetFeatures,
|
2022-09-13 05:40:08 +00:00
|
|
|
loadingProperties?: Array<RegExp>,
|
2022-11-28 04:44:31 +00:00
|
|
|
stylesheetConfig?: Stylesheet,
|
2023-04-14 06:27:49 +00:00
|
|
|
autocompleteDefinitions?: AutocompletionDefinitions,
|
2023-04-07 13:51:35 +00:00
|
|
|
autoLayoutConfig?: AutoLayoutConfig,
|
2019-09-09 09:08:54 +00:00
|
|
|
) {
|
2021-09-09 15:10:22 +00:00
|
|
|
if (!this.widgetTypes[widgetType]) {
|
|
|
|
|
this.widgetTypes[widgetType] = widgetType;
|
|
|
|
|
this.widgetMap.set(widgetType, widgetBuilder);
|
|
|
|
|
this.derivedPropertiesMap.set(widgetType, derivedPropertiesMap);
|
2022-11-23 09:48:23 +00:00
|
|
|
this.defaultPropertiesMap.set(
|
|
|
|
|
widgetType,
|
|
|
|
|
defaultPropertiesMap as Record<string, string>,
|
|
|
|
|
);
|
2021-09-09 15:10:22 +00:00
|
|
|
this.metaPropertiesMap.set(widgetType, metaPropertiesMap);
|
2022-09-13 05:40:08 +00:00
|
|
|
loadingProperties &&
|
|
|
|
|
this.loadingProperties.set(widgetType, loadingProperties);
|
2022-11-28 04:44:31 +00:00
|
|
|
stylesheetConfig &&
|
|
|
|
|
this.stylesheetConfigMap.set(widgetType, stylesheetConfig);
|
2023-04-14 06:27:49 +00:00
|
|
|
autocompleteDefinitions &&
|
|
|
|
|
this.autocompleteDefinitions.set(widgetType, autocompleteDefinitions);
|
2021-02-16 10:29:08 +00:00
|
|
|
|
2022-11-23 09:48:23 +00:00
|
|
|
if (Array.isArray(propertyPaneConfig) && propertyPaneConfig.length > 0) {
|
2022-04-22 09:44:22 +00:00
|
|
|
const enhancedPropertyPaneConfig = enhancePropertyPaneConfig(
|
2021-09-09 15:10:22 +00:00
|
|
|
propertyPaneConfig,
|
2022-04-22 09:44:22 +00:00
|
|
|
features,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const serializablePropertyPaneConfig = convertFunctionsToString(
|
|
|
|
|
enhancedPropertyPaneConfig,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const finalPropertyPaneConfig = addPropertyConfigIds(
|
|
|
|
|
serializablePropertyPaneConfig,
|
2021-09-09 15:10:22 +00:00
|
|
|
);
|
2021-07-26 05:50:46 +00:00
|
|
|
|
2021-09-09 15:10:22 +00:00
|
|
|
this.propertyPaneConfigsMap.set(
|
|
|
|
|
widgetType,
|
2022-04-22 09:44:22 +00:00
|
|
|
Object.freeze(finalPropertyPaneConfig),
|
2021-09-09 15:10:22 +00:00
|
|
|
);
|
|
|
|
|
}
|
2022-08-04 05:31:05 +00:00
|
|
|
|
|
|
|
|
if (propertyPaneContentConfig) {
|
|
|
|
|
const enhancedPropertyPaneConfig = enhancePropertyPaneConfig(
|
|
|
|
|
propertyPaneContentConfig,
|
|
|
|
|
features,
|
2022-11-23 09:48:23 +00:00
|
|
|
PropertyPaneConfigTypes.CONTENT,
|
2022-11-24 18:40:06 +00:00
|
|
|
widgetType,
|
2022-08-04 05:31:05 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const serializablePropertyPaneConfig = convertFunctionsToString(
|
|
|
|
|
enhancedPropertyPaneConfig,
|
|
|
|
|
);
|
|
|
|
|
|
2022-12-11 14:42:32 +00:00
|
|
|
const propertyPaneConfigWithIds = addPropertyConfigIds(
|
2022-08-04 05:31:05 +00:00
|
|
|
serializablePropertyPaneConfig,
|
|
|
|
|
);
|
|
|
|
|
|
2022-12-11 14:42:32 +00:00
|
|
|
const finalPropertyPaneConfig = addSearchConfigToPanelConfig(
|
|
|
|
|
propertyPaneConfigWithIds,
|
|
|
|
|
);
|
|
|
|
|
|
2022-08-04 05:31:05 +00:00
|
|
|
this.propertyPaneContentConfigsMap.set(
|
|
|
|
|
widgetType,
|
|
|
|
|
Object.freeze(finalPropertyPaneConfig),
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (propertyPaneStyleConfig) {
|
|
|
|
|
const enhancedPropertyPaneConfig = enhancePropertyPaneConfig(
|
|
|
|
|
propertyPaneStyleConfig,
|
|
|
|
|
features,
|
2022-11-23 09:48:23 +00:00
|
|
|
PropertyPaneConfigTypes.STYLE,
|
2022-08-04 05:31:05 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const serializablePropertyPaneConfig = convertFunctionsToString(
|
|
|
|
|
enhancedPropertyPaneConfig,
|
|
|
|
|
);
|
|
|
|
|
|
2022-12-11 14:42:32 +00:00
|
|
|
const propertyPaneConfigWithIds = addPropertyConfigIds(
|
2022-08-04 05:31:05 +00:00
|
|
|
serializablePropertyPaneConfig,
|
|
|
|
|
);
|
|
|
|
|
|
2022-12-11 14:42:32 +00:00
|
|
|
const finalPropertyPaneConfig = addSearchConfigToPanelConfig(
|
|
|
|
|
propertyPaneConfigWithIds,
|
|
|
|
|
);
|
|
|
|
|
|
2022-08-04 05:31:05 +00:00
|
|
|
this.propertyPaneStyleConfigsMap.set(
|
|
|
|
|
widgetType,
|
|
|
|
|
Object.freeze(finalPropertyPaneConfig),
|
|
|
|
|
);
|
|
|
|
|
}
|
2022-12-11 14:42:32 +00:00
|
|
|
|
|
|
|
|
this.propertyPaneSearchConfigsMap.set(
|
|
|
|
|
widgetType,
|
|
|
|
|
generatePropertyPaneSearchConfig(
|
|
|
|
|
WidgetFactory.getWidgetPropertyPaneContentConfig(widgetType),
|
|
|
|
|
WidgetFactory.getWidgetPropertyPaneStyleConfig(widgetType),
|
|
|
|
|
),
|
|
|
|
|
);
|
2023-04-07 13:51:35 +00:00
|
|
|
|
|
|
|
|
autoLayoutConfig &&
|
|
|
|
|
this.autoLayoutConfigMap.set(widgetType, {
|
|
|
|
|
...autoLayoutConfig,
|
|
|
|
|
widgetSize:
|
|
|
|
|
autoLayoutConfig.widgetSize?.map((sizeConfig) => ({
|
|
|
|
|
...sizeConfig,
|
|
|
|
|
configuration: (props: WidgetProps) => {
|
|
|
|
|
if (!props)
|
|
|
|
|
return {
|
|
|
|
|
minWidth:
|
|
|
|
|
this.widgetConfigMap.get(widgetType)?.minWidth ||
|
|
|
|
|
FILL_WIDGET_MIN_WIDTH,
|
|
|
|
|
minHeight:
|
|
|
|
|
this.widgetConfigMap.get(widgetType)?.minHeight || 80,
|
|
|
|
|
};
|
|
|
|
|
return sizeConfig.configuration(props);
|
|
|
|
|
},
|
|
|
|
|
})) || [],
|
|
|
|
|
autoDimension: autoLayoutConfig.autoDimension ?? {},
|
|
|
|
|
disabledPropsDefaults: autoLayoutConfig.disabledPropsDefaults ?? {},
|
|
|
|
|
});
|
2021-07-26 05:50:46 +00:00
|
|
|
}
|
2019-09-09 09:08:54 +00:00
|
|
|
}
|
|
|
|
|
|
2021-09-09 15:10:22 +00:00
|
|
|
static storeWidgetConfig(
|
|
|
|
|
widgetType: string,
|
|
|
|
|
config: Partial<WidgetProps> & WidgetConfigProps & { type: string },
|
|
|
|
|
) {
|
|
|
|
|
this.widgetConfigMap.set(widgetType, Object.freeze(config));
|
|
|
|
|
}
|
|
|
|
|
|
2022-11-23 09:48:23 +00:00
|
|
|
static storeNonSerialisablewidgetConfig(
|
|
|
|
|
widgetType: string,
|
|
|
|
|
config: Record<NonSerialisableWidgetConfigs, unknown>,
|
|
|
|
|
) {
|
|
|
|
|
this.nonSerialisableWidgetConfigMap.set(widgetType, config);
|
|
|
|
|
}
|
|
|
|
|
|
2019-09-17 10:11:50 +00:00
|
|
|
static createWidget(
|
2022-08-19 10:10:36 +00:00
|
|
|
widgetData: CanvasWidgetStructure,
|
2019-09-17 10:11:50 +00:00
|
|
|
renderMode: RenderMode,
|
2020-03-06 09:45:21 +00:00
|
|
|
): React.ReactNode {
|
2022-08-19 10:10:36 +00:00
|
|
|
const widgetProps = {
|
2019-09-17 10:11:50 +00:00
|
|
|
key: widgetData.widgetId,
|
2019-11-06 12:12:41 +00:00
|
|
|
isVisible: true,
|
2019-09-21 01:52:38 +00:00
|
|
|
...widgetData,
|
2021-09-09 15:10:22 +00:00
|
|
|
renderMode,
|
2019-09-17 10:11:50 +00:00
|
|
|
};
|
2019-09-17 10:09:00 +00:00
|
|
|
const widgetBuilder = this.widgetMap.get(widgetData.type);
|
2019-09-17 10:11:50 +00:00
|
|
|
if (widgetBuilder) {
|
|
|
|
|
const widget = widgetBuilder.buildWidget(widgetProps);
|
|
|
|
|
return widget;
|
|
|
|
|
} else {
|
2019-09-09 09:08:54 +00:00
|
|
|
const ex: WidgetCreationException = {
|
|
|
|
|
message:
|
2019-09-17 10:09:00 +00:00
|
|
|
"Widget Builder not registered for widget type" + widgetData.type,
|
2019-09-09 09:08:54 +00:00
|
|
|
};
|
2021-11-05 05:49:19 +00:00
|
|
|
log.error(ex);
|
2020-03-06 09:45:21 +00:00
|
|
|
return null;
|
2019-04-02 16:12:08 +00:00
|
|
|
}
|
2019-09-09 09:08:54 +00:00
|
|
|
}
|
2019-04-02 16:12:08 +00:00
|
|
|
|
2019-09-09 09:08:54 +00:00
|
|
|
static getWidgetTypes(): WidgetType[] {
|
|
|
|
|
return Array.from(this.widgetMap.keys());
|
|
|
|
|
}
|
2019-11-19 12:44:58 +00:00
|
|
|
|
2020-01-17 09:28:26 +00:00
|
|
|
static getWidgetDerivedPropertiesMap(
|
|
|
|
|
widgetType: WidgetType,
|
|
|
|
|
): DerivedPropertiesMap {
|
|
|
|
|
const map = this.derivedPropertiesMap.get(widgetType);
|
|
|
|
|
if (!map) {
|
2021-11-05 05:49:19 +00:00
|
|
|
log.error("Widget type validation is not defined");
|
2020-01-17 09:28:26 +00:00
|
|
|
return {};
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
2020-02-18 10:41:52 +00:00
|
|
|
|
2020-04-17 16:15:09 +00:00
|
|
|
static getWidgetDefaultPropertiesMap(
|
|
|
|
|
widgetType: WidgetType,
|
|
|
|
|
): Record<string, string> {
|
|
|
|
|
const map = this.defaultPropertiesMap.get(widgetType);
|
|
|
|
|
if (!map) {
|
2021-11-05 05:49:19 +00:00
|
|
|
log.error("Widget default properties not defined", widgetType);
|
2020-04-17 16:15:09 +00:00
|
|
|
return {};
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static getWidgetMetaPropertiesMap(
|
|
|
|
|
widgetType: WidgetType,
|
2022-01-28 11:10:05 +00:00
|
|
|
): Record<string, unknown> {
|
2020-04-17 16:15:09 +00:00
|
|
|
const map = this.metaPropertiesMap.get(widgetType);
|
|
|
|
|
if (!map) {
|
2021-11-05 05:49:19 +00:00
|
|
|
log.error("Widget meta properties not defined: ", widgetType);
|
2020-04-17 16:15:09 +00:00
|
|
|
return {};
|
|
|
|
|
}
|
|
|
|
|
return map;
|
2021-02-16 10:29:08 +00:00
|
|
|
}
|
|
|
|
|
|
2022-09-29 05:24:49 +00:00
|
|
|
static getWidgetPropertyPaneCombinedConfig(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): readonly PropertyPaneConfig[] {
|
|
|
|
|
const contentConfig = this.propertyPaneContentConfigsMap.get(type) || [];
|
|
|
|
|
const styleConfig = this.propertyPaneStyleConfigsMap.get(type) || [];
|
|
|
|
|
return [...contentConfig, ...styleConfig];
|
|
|
|
|
}
|
|
|
|
|
|
2021-02-16 10:29:08 +00:00
|
|
|
static getWidgetPropertyPaneConfig(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): readonly PropertyPaneConfig[] {
|
|
|
|
|
const map = this.propertyPaneConfigsMap.get(type);
|
2022-09-29 05:24:49 +00:00
|
|
|
if (!map || (map && map.length === 0)) {
|
|
|
|
|
const config = WidgetFactory.getWidgetPropertyPaneCombinedConfig(type);
|
2022-11-23 09:48:23 +00:00
|
|
|
if (config === undefined) {
|
2022-09-29 05:24:49 +00:00
|
|
|
log.error("Widget property pane config not defined", type);
|
|
|
|
|
}
|
|
|
|
|
return config;
|
2021-02-16 10:29:08 +00:00
|
|
|
}
|
|
|
|
|
return map;
|
2020-04-17 16:15:09 +00:00
|
|
|
}
|
2020-10-21 04:25:32 +00:00
|
|
|
|
2022-08-04 05:31:05 +00:00
|
|
|
static getWidgetPropertyPaneContentConfig(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): readonly PropertyPaneConfig[] {
|
|
|
|
|
const map = this.propertyPaneContentConfigsMap.get(type);
|
|
|
|
|
if (!map) {
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static getWidgetPropertyPaneStyleConfig(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): readonly PropertyPaneConfig[] {
|
|
|
|
|
const map = this.propertyPaneStyleConfigsMap.get(type);
|
|
|
|
|
if (!map) {
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
|
|
|
|
|
2022-12-11 14:42:32 +00:00
|
|
|
static getWidgetPropertyPaneSearchConfig(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): readonly PropertyPaneConfig[] {
|
|
|
|
|
const map = this.propertyPaneSearchConfigsMap.get(type);
|
|
|
|
|
if (!map) {
|
|
|
|
|
return [];
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
|
|
|
|
|
2023-04-07 13:51:35 +00:00
|
|
|
static getWidgetAutoLayoutConfig(type: WidgetType): AutoLayoutConfig {
|
|
|
|
|
const map = this.autoLayoutConfigMap.get(type);
|
|
|
|
|
if (!map) {
|
|
|
|
|
return {
|
|
|
|
|
autoDimension: {},
|
|
|
|
|
widgetSize: [],
|
|
|
|
|
disableResizeHandles: {},
|
|
|
|
|
disabledPropsDefaults: {},
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-21 04:25:32 +00:00
|
|
|
static getWidgetTypeConfigMap(): WidgetTypeConfigMap {
|
|
|
|
|
const typeConfigMap: WidgetTypeConfigMap = {};
|
2020-12-24 04:32:25 +00:00
|
|
|
WidgetFactory.getWidgetTypes().forEach((type) => {
|
2020-10-21 04:25:32 +00:00
|
|
|
typeConfigMap[type] = {
|
|
|
|
|
defaultProperties: WidgetFactory.getWidgetDefaultPropertiesMap(type),
|
|
|
|
|
derivedProperties: WidgetFactory.getWidgetDerivedPropertiesMap(type),
|
|
|
|
|
metaProperties: WidgetFactory.getWidgetMetaPropertiesMap(type),
|
|
|
|
|
};
|
|
|
|
|
});
|
|
|
|
|
return typeConfigMap;
|
|
|
|
|
}
|
2022-09-13 05:40:08 +00:00
|
|
|
|
2023-04-14 06:27:49 +00:00
|
|
|
static getAutocompleteDefinitions(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
): AutocompletionDefinitions | undefined {
|
|
|
|
|
const autocompleteDefinition = this.autocompleteDefinitions.get(type);
|
|
|
|
|
if (!autocompleteDefinition) {
|
|
|
|
|
log.error("Widget autocomplete properties not defined: ", type);
|
|
|
|
|
}
|
|
|
|
|
return autocompleteDefinition;
|
|
|
|
|
}
|
|
|
|
|
|
2022-09-13 05:40:08 +00:00
|
|
|
static getLoadingProperties(type: WidgetType): Array<RegExp> | undefined {
|
|
|
|
|
return this.loadingProperties.get(type);
|
|
|
|
|
}
|
2022-11-28 04:44:31 +00:00
|
|
|
|
|
|
|
|
static getWidgetStylesheetConfigMap(widgetType: WidgetType) {
|
|
|
|
|
const map = this.stylesheetConfigMap.get(widgetType);
|
|
|
|
|
if (!map) {
|
|
|
|
|
log.error("Widget stylesheet properties not defined: ", widgetType);
|
|
|
|
|
return undefined;
|
|
|
|
|
}
|
|
|
|
|
return map;
|
|
|
|
|
}
|
2023-06-01 17:26:05 +00:00
|
|
|
|
|
|
|
|
static setWidgetMethods(
|
|
|
|
|
type: WidgetType,
|
|
|
|
|
methods: Record<string, WidgetMethods>,
|
|
|
|
|
) {
|
|
|
|
|
this.widgetMethodsMap.set(type, methods);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static getWidgetMethods(type: WidgetType) {
|
|
|
|
|
const methods = this.widgetMethodsMap.get(type);
|
|
|
|
|
|
|
|
|
|
if (!methods) {
|
|
|
|
|
log.error("Widget methods are not defined: ", type);
|
|
|
|
|
return {};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return methods;
|
|
|
|
|
}
|
2019-02-10 13:06:05 +00:00
|
|
|
}
|
|
|
|
|
|
2020-10-21 04:25:32 +00:00
|
|
|
export type WidgetTypeConfigMap = Record<
|
|
|
|
|
string,
|
|
|
|
|
{
|
|
|
|
|
defaultProperties: Record<string, string>;
|
|
|
|
|
metaProperties: Record<string, any>;
|
2021-06-18 07:42:57 +00:00
|
|
|
derivedProperties: WidgetDerivedPropertyType;
|
2020-10-21 04:25:32 +00:00
|
|
|
}
|
|
|
|
|
>;
|
|
|
|
|
|
2019-08-29 11:22:09 +00:00
|
|
|
export interface WidgetCreationException {
|
2019-09-09 09:08:54 +00:00
|
|
|
message: string;
|
2019-02-10 13:06:05 +00:00
|
|
|
}
|
|
|
|
|
|
2019-09-09 09:08:54 +00:00
|
|
|
export default WidgetFactory;
|