chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { EventType } from "constants/AppsmithActionConstants/ActionConstants";
|
|
|
|
|
import type { TriggerMeta } from "@appsmith/sagas/ActionExecution/ActionExecutionSagas";
|
2023-02-11 18:33:20 +00:00
|
|
|
import { call, put, spawn, take } from "redux-saga/effects";
|
|
|
|
|
import { logActionExecutionError } from "sagas/ActionExecution/errorUtils";
|
|
|
|
|
import { setUserCurrentGeoLocation } from "actions/browserRequestActions";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type { Channel } from "redux-saga";
|
|
|
|
|
import { channel } from "redux-saga";
|
2023-02-11 18:33:20 +00:00
|
|
|
import { evalWorker } from "sagas/EvaluationsSaga";
|
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
|
|
|
import type {
|
2023-02-11 18:33:20 +00:00
|
|
|
TGetGeoLocationDescription,
|
|
|
|
|
TWatchGeoLocationDescription,
|
|
|
|
|
} from "workers/Evaluation/fns/geolocationFns";
|
|
|
|
|
|
|
|
|
|
class GeoLocationError extends Error {
|
|
|
|
|
constructor(message: string, private responseData?: any) {
|
|
|
|
|
super(message);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let successChannel: Channel<GeolocationPosition> | null = null;
|
|
|
|
|
let errorChannel: Channel<GeolocationPositionError> | null = null;
|
|
|
|
|
|
|
|
|
|
// Making the getCurrentPosition call in a promise fashion
|
|
|
|
|
export const getUserLocation = (options?: PositionOptions) =>
|
|
|
|
|
new Promise((resolve, reject) => {
|
|
|
|
|
navigator.geolocation.getCurrentPosition(
|
|
|
|
|
(location) => resolve(location),
|
|
|
|
|
(error) => reject(error),
|
|
|
|
|
options,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* We need to extract and set certain properties only because the
|
|
|
|
|
* return value is a "class" with functions as well and
|
|
|
|
|
* that cant be stored in the data tree
|
|
|
|
|
**/
|
|
|
|
|
export const extractGeoLocation = (
|
|
|
|
|
location: GeolocationPosition,
|
|
|
|
|
): GeolocationPosition => {
|
|
|
|
|
const {
|
|
|
|
|
coords: {
|
|
|
|
|
accuracy,
|
|
|
|
|
altitude,
|
|
|
|
|
altitudeAccuracy,
|
|
|
|
|
heading,
|
|
|
|
|
latitude,
|
|
|
|
|
longitude,
|
|
|
|
|
speed,
|
|
|
|
|
},
|
|
|
|
|
} = location;
|
|
|
|
|
const coords: GeolocationCoordinates = {
|
|
|
|
|
altitude,
|
|
|
|
|
altitudeAccuracy,
|
|
|
|
|
heading,
|
|
|
|
|
latitude,
|
|
|
|
|
longitude,
|
|
|
|
|
accuracy,
|
|
|
|
|
speed,
|
|
|
|
|
};
|
|
|
|
|
return {
|
|
|
|
|
coords,
|
|
|
|
|
timestamp: location.timestamp,
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* When location access is turned off in the browser, the error is a GeolocationPositionError instance
|
|
|
|
|
* We can't pass this instance to the worker thread as it uses structured cloning for copying the objects
|
|
|
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
|
|
|
|
|
* It doesn't support some entities like DOM Nodes, functions etc. for copying
|
|
|
|
|
* And will throw an error if we try to pass it
|
|
|
|
|
* GeolocationPositionError instance doesn't exist in worker thread hence not supported by structured cloning
|
|
|
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/GeolocationPositionError
|
|
|
|
|
* Hence we're creating a new object with same structure which can be passed to the worker thread
|
|
|
|
|
*/
|
|
|
|
|
function sanitizeGeolocationError(error: GeolocationPositionError) {
|
|
|
|
|
return {
|
2023-05-31 06:44:07 +00:00
|
|
|
code: error.code,
|
|
|
|
|
message: error.message,
|
2023-02-11 18:33:20 +00:00
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* successCallbackHandler(listenerId?: string) {
|
|
|
|
|
let payload: GeolocationPosition;
|
|
|
|
|
if (!successChannel) return;
|
|
|
|
|
while ((payload = yield take(successChannel))) {
|
|
|
|
|
const currentLocation = extractGeoLocation(payload);
|
|
|
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
|
|
|
if (listenerId)
|
|
|
|
|
yield call(evalWorker.ping, { data: currentLocation }, listenerId);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function* errorCallbackHandler(triggerMeta: TriggerMeta, listenerId?: string) {
|
|
|
|
|
if (!errorChannel) return;
|
|
|
|
|
let error: GeolocationPositionError;
|
|
|
|
|
while ((error = yield take(errorChannel))) {
|
|
|
|
|
if (listenerId)
|
|
|
|
|
yield call(
|
|
|
|
|
evalWorker.ping,
|
|
|
|
|
{ error: sanitizeGeolocationError(error) },
|
|
|
|
|
listenerId,
|
|
|
|
|
);
|
2023-06-09 13:58:45 +00:00
|
|
|
yield call(logActionExecutionError, error.message, true);
|
2023-02-11 18:33:20 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-05-19 18:37:06 +00:00
|
|
|
export function* getCurrentLocationSaga(action: TGetGeoLocationDescription) {
|
2023-02-11 18:33:20 +00:00
|
|
|
const { payload: actionPayload } = action;
|
|
|
|
|
try {
|
|
|
|
|
const location: GeolocationPosition = yield call(
|
|
|
|
|
getUserLocation,
|
|
|
|
|
actionPayload.options,
|
|
|
|
|
);
|
|
|
|
|
const currentLocation = extractGeoLocation(location);
|
|
|
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
|
|
|
return currentLocation;
|
|
|
|
|
} catch (error) {
|
2023-06-09 13:58:45 +00:00
|
|
|
yield call(logActionExecutionError, (error as Error).message, true);
|
2023-02-11 18:33:20 +00:00
|
|
|
if (error instanceof GeolocationPositionError) {
|
|
|
|
|
const sanitizedError = sanitizeGeolocationError(error);
|
|
|
|
|
throw new GeoLocationError(sanitizedError.message, [sanitizedError]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let watchId: number | undefined;
|
|
|
|
|
export function* watchCurrentLocation(
|
|
|
|
|
action: TWatchGeoLocationDescription,
|
|
|
|
|
_: EventType,
|
|
|
|
|
triggerMeta: TriggerMeta,
|
|
|
|
|
) {
|
|
|
|
|
const { payload: actionPayload } = action;
|
|
|
|
|
if (watchId) {
|
|
|
|
|
// When a watch is already active, we will not start a new watch.
|
|
|
|
|
// at a given point in time, only one watch is active
|
2023-06-09 13:58:45 +00:00
|
|
|
yield call(
|
|
|
|
|
logActionExecutionError,
|
2023-02-11 18:33:20 +00:00
|
|
|
"A watchLocation is already active. Clear it before before starting a new one",
|
2023-04-27 08:50:23 +00:00
|
|
|
true,
|
2023-02-11 18:33:20 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
successChannel = channel<GeolocationPosition>();
|
|
|
|
|
errorChannel = channel<GeolocationPositionError>();
|
|
|
|
|
yield spawn(successCallbackHandler, actionPayload.listenerId);
|
|
|
|
|
yield spawn(errorCallbackHandler, triggerMeta, actionPayload.listenerId);
|
|
|
|
|
watchId = navigator.geolocation.watchPosition(
|
|
|
|
|
(location) => {
|
|
|
|
|
successChannel?.put(location);
|
|
|
|
|
},
|
|
|
|
|
(error) => {
|
|
|
|
|
// When location is turned off, the watch fails but watchId is generated
|
|
|
|
|
// Resetting the watchId to undefined so that a new watch can be started
|
|
|
|
|
if (watchId) {
|
|
|
|
|
navigator.geolocation.clearWatch(watchId);
|
|
|
|
|
watchId = undefined;
|
|
|
|
|
}
|
|
|
|
|
errorChannel?.put(error);
|
|
|
|
|
},
|
|
|
|
|
actionPayload.options,
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
2023-05-19 18:37:06 +00:00
|
|
|
export function* stopWatchCurrentLocation() {
|
2023-02-11 18:33:20 +00:00
|
|
|
if (watchId === undefined) {
|
2023-06-09 13:58:45 +00:00
|
|
|
yield call(logActionExecutionError, "No location watch active", true);
|
2023-02-11 18:33:20 +00:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
navigator.geolocation.clearWatch(watchId);
|
|
|
|
|
watchId = undefined;
|
|
|
|
|
successChannel?.close();
|
|
|
|
|
errorChannel?.close();
|
|
|
|
|
}
|