chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
https://github.com/appsmithorg/appsmith/commit/7cbb12af886621256224be0c93e6a465dd710ad3,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 11:41:47 +00:00
import type {
2022-01-13 05:24:12 +00:00
PropertyPaneConfig ,
PropertyPaneControlConfig ,
2022-12-11 14:42:32 +00:00
PropertyPaneSectionConfig ,
2022-01-13 05:24:12 +00:00
ValidationConfig ,
} from "constants/PropertyControlConstants" ;
import { ValidationTypes } from "constants/WidgetValidation" ;
2022-12-11 14:42:32 +00:00
import { isFunction } from "lodash" ;
2022-06-23 15:09:00 +00:00
import WidgetFactory from "utils/WidgetFactory" ;
import { ALL_WIDGETS_AND_CONFIG , registerWidgets } from "./WidgetRegistry" ;
2022-01-13 05:24:12 +00:00
2022-10-20 14:06:32 +00:00
function validatePropertyPaneConfig (
config : PropertyPaneConfig [ ] ,
isWidgetHidden : boolean ,
) {
2022-01-13 05:24:12 +00:00
for ( const sectionOrControlConfig of config ) {
2022-12-11 14:42:32 +00:00
const sectionConfig = sectionOrControlConfig as PropertyPaneSectionConfig ;
if ( sectionConfig . sectionName && isFunction ( sectionConfig . sectionName ) ) {
return ` SectionName should be a string and not a function. Search won't work for functions at the moment ` ;
}
2022-01-13 05:24:12 +00:00
if ( sectionOrControlConfig . children ) {
for ( const propertyControlConfig of sectionOrControlConfig . children ) {
const propertyControlValidation = validatePropertyControl (
propertyControlConfig ,
2022-10-20 14:06:32 +00:00
isWidgetHidden ,
2022-01-13 05:24:12 +00:00
) ;
if ( propertyControlValidation !== true )
return propertyControlValidation ;
}
}
}
return true ;
}
2022-10-20 14:06:32 +00:00
function validatePropertyControl (
config : PropertyPaneConfig ,
isWidgetHidden : boolean ,
) : boolean | string {
2022-01-13 05:24:12 +00:00
const _config = config as PropertyPaneControlConfig ;
const controls = [ "INPUT_TEXT" ] ;
2022-12-11 14:42:32 +00:00
if ( _config . label && isFunction ( _config . label ) ) {
return ` ${ _config . propertyName } : Label should be a string and not a function. Search won't work for functions at the moment ` ;
}
2022-10-20 14:06:32 +00:00
if (
! isWidgetHidden &&
_config . label &&
! _config . invisible &&
2023-02-14 16:07:31 +00:00
! ( _config . helpText || _config . helperText )
2022-10-20 14:06:32 +00:00
) {
2023-02-14 16:07:31 +00:00
return ` ${ _config . propertyName } ( ${ _config . label } ): Help text or Helper textis mandatory for property controls ` ;
2022-10-20 14:06:32 +00:00
}
2022-01-13 05:24:12 +00:00
if (
( _config . isJSConvertible || controls . includes ( _config . controlType ) ) &&
! _config . isTriggerProperty
) {
if ( ! _config . isBindProperty )
return ` ${
_config . propertyName
} : isBindProperty should be true if isJSConvertible is true or when control type is [ $ { controls . join (
" | " ,
) } ] ` ;
if ( ! _config . validation )
return ` ${
_config . propertyName
} : validation should be defined if isJSConvertible is true or when control type is [ $ { controls . join (
" | " ,
) } ] ` ;
}
2022-09-22 19:00:55 +00:00
if ( controls . includes ( _config . controlType ) && _config . isJSConvertible ) {
return ` ${
_config . propertyName
} : No need of setting isJSConvertible since users can write JS inside [ $ { controls . join (
" | " ,
) } ] ` ;
}
2022-01-13 05:24:12 +00:00
if ( _config . validation !== undefined ) {
const res = validateValidationStructure ( _config . validation ) ;
if ( res !== true ) return ` ${ _config . propertyName } : ${ res } ` ;
}
if ( _config . children ) {
for ( const child of _config . children ) {
2022-10-20 14:06:32 +00:00
const res = validatePropertyControl ( child , isWidgetHidden ) ;
2022-01-13 05:24:12 +00:00
if ( res !== true ) return ` ${ _config . propertyName } . ${ res } ` ;
}
}
if ( _config . panelConfig ) {
2022-09-29 05:24:49 +00:00
if ( _config . panelConfig . children ) {
2022-10-20 14:06:32 +00:00
const res = validatePropertyPaneConfig (
_config . panelConfig . children ,
isWidgetHidden ,
) ;
2022-09-29 05:24:49 +00:00
if ( res !== true ) return ` ${ _config . propertyName } . ${ res } ` ;
}
if ( _config . panelConfig . contentChildren ) {
const res = validatePropertyPaneConfig (
_config . panelConfig . contentChildren ,
2022-10-20 14:06:32 +00:00
isWidgetHidden ,
2022-09-29 05:24:49 +00:00
) ;
if ( res !== true ) return ` ${ _config . propertyName } . ${ res } ` ;
}
if ( _config . panelConfig . styleChildren ) {
2022-10-20 14:06:32 +00:00
const res = validatePropertyPaneConfig (
_config . panelConfig . styleChildren ,
isWidgetHidden ,
) ;
2022-09-29 05:24:49 +00:00
if ( res !== true ) return ` ${ _config . propertyName } . ${ res } ` ;
}
2022-01-13 05:24:12 +00:00
}
return true ;
}
function validateValidationStructure (
config : ValidationConfig ,
) : boolean | string {
if (
config . type === ValidationTypes . FUNCTION &&
config . params &&
config . params . fn
) {
if ( ! config . params . expected )
return ` For a ${ ValidationTypes . FUNCTION } type validation, expected type and example are mandatory ` ;
}
return true ;
}
2022-09-29 05:24:49 +00:00
2022-01-21 10:19:10 +00:00
const isNotFloat = ( n : any ) = > {
return Number ( n ) === n && n % 1 === 0 ;
} ;
2022-09-29 05:24:49 +00:00
2022-01-13 05:24:12 +00:00
describe ( "Tests all widget's propertyPane config" , ( ) = > {
2022-06-23 15:09:00 +00:00
beforeAll ( ( ) = > {
registerWidgets ( ) ;
} ) ;
2022-01-21 10:19:10 +00:00
ALL_WIDGETS_AND_CONFIG . forEach ( ( widgetAndConfig ) = > {
const [ widget , config ] : any = widgetAndConfig ;
2022-01-13 05:24:12 +00:00
it ( ` Checks ${ widget . getWidgetType ( ) } 's propertyPaneConfig ` , ( ) = > {
const propertyPaneConfig = widget . getPropertyPaneConfig ( ) ;
2022-10-20 14:06:32 +00:00
expect (
validatePropertyPaneConfig ( propertyPaneConfig , config . hideCard ) ,
) . toStrictEqual ( true ) ;
2022-09-29 05:24:49 +00:00
const propertyPaneContentConfig = widget . getPropertyPaneContentConfig ( ) ;
expect (
2022-10-20 14:06:32 +00:00
validatePropertyPaneConfig (
propertyPaneContentConfig ,
config . isDeprecated ,
) ,
2022-09-29 05:24:49 +00:00
) . toStrictEqual ( true ) ;
const propertyPaneStyleConfig = widget . getPropertyPaneStyleConfig ( ) ;
2022-10-20 14:06:32 +00:00
expect (
validatePropertyPaneConfig (
propertyPaneStyleConfig ,
config . isDeprecated ,
) ,
) . toStrictEqual ( true ) ;
2022-01-13 05:24:12 +00:00
} ) ;
2022-01-21 10:19:10 +00:00
it ( ` Check if ${ widget . getWidgetType ( ) } 's dimensions are always integers ` , ( ) = > {
expect ( isNotFloat ( config . defaults . rows ) ) . toBe ( true ) ;
expect ( isNotFloat ( config . defaults . columns ) ) . toBe ( true ) ;
} ) ;
2023-02-28 12:18:35 +00:00
if ( config . isDeprecated ) {
2022-06-23 15:09:00 +00:00
it ( ` Check if ${ widget . getWidgetType ( ) } 's deprecation config has a proper replacement Widget ` , ( ) = > {
const widgetType = widget . getWidgetType ( ) ;
2023-02-28 12:18:35 +00:00
if ( config . replacement === undefined ) {
fail ( ` ${ widgetType } 's replacement widget is not defined ` ) ;
}
2022-06-23 15:09:00 +00:00
const replacementWidgetType = config . replacement ;
const replacementWidgetConfig = WidgetFactory . widgetConfigMap . get (
replacementWidgetType ,
) ;
if ( replacementWidgetConfig === undefined ) {
fail (
` ${ widgetType } 's replacement widget ${ replacementWidgetType } does not resolve to an actual widget Config ` ,
) ;
}
if ( replacementWidgetConfig ? . isDeprecated ) {
fail (
` ${ widgetType } 's replacement widget ${ replacementWidgetType } itself is deprecated. Cannot have a deprecated widget as a replacement for another deprecated widget ` ,
) ;
}
if ( replacementWidgetConfig ? . hideCard ) {
fail (
` ${ widgetType } 's replacement widget ${ replacementWidgetType } should be available in the entity Explorer ` ,
) ;
}
} ) ;
}
2022-01-13 05:24:12 +00:00
} ) ;
} ) ;